[Pywikipedia-bugs] [Maniphest] [Commented On] T272088: Logging (pywiki module) always verbose if enabled

[So9q]

So9q added a comment.


  In T272088#8389652 , 
@WolfgangFahl wrote:
  
  > 7.3 seems to work thanks god ...
  
  Thanks for the update. Then I can retire my fork and upgrade to 7.3 in 
wcdimportbot 😀

TASK DETAIL
  https://phabricator.wikimedia.org/T272088

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: maynorc, So9q
Cc: WolfgangFahl, So9q, maynorc, AntiCompositeNumber, CONFIQ, Xqt, Aklapper, 
Inductiveload, pywikibot-bugs-list, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, 
Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T272088: Logging (pywiki module) always verbose if enabled

[WolfgangFahl]

WolfgangFahl added a comment.


  7.3 seems to work thanks god ...

TASK DETAIL
  https://phabricator.wikimedia.org/T272088

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: maynorc, WolfgangFahl
Cc: WolfgangFahl, So9q, maynorc, AntiCompositeNumber, CONFIQ, Xqt, Aklapper, 
Inductiveload, pywikibot-bugs-list, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, 
Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T272088: Logging (pywiki module) always verbose if enabled

[WolfgangFahl]

WolfgangFahl added a comment.


  This is quite a horror show. I do not even use pywikibot just import it and 
it throws a ton of log stuff at me. Unfortunately this is marked as resolved 
without given the clear answer what version makes sure that the logging is not 
verbose by default.

TASK DETAIL
  https://phabricator.wikimedia.org/T272088

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: maynorc, WolfgangFahl
Cc: WolfgangFahl, So9q, maynorc, AntiCompositeNumber, CONFIQ, Xqt, Aklapper, 
Inductiveload, pywikibot-bugs-list, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, 
Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T272088: Logging (pywiki module) always verbose if enabled

[maynorc]

maynorc added a comment.


  Sorry for the delay, hoping to get to it next week.

TASK DETAIL
  https://phabricator.wikimedia.org/T272088

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: maynorc
Cc: So9q, maynorc, AntiCompositeNumber, CONFIQ, Xqt, Aklapper, Inductiveload, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T272088: Logging (pywiki module) always verbose if enabled

[So9q]

So9q added a comment.


  I'm leaning towards forking pywikibot and removing the offending lines in 
bot.py causing the verbose log of files.

TASK DETAIL
  https://phabricator.wikimedia.org/T272088

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: maynorc, So9q
Cc: So9q, maynorc, AntiCompositeNumber, CONFIQ, Xqt, Aklapper, Inductiveload, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T272088: Logging (pywiki module) always verbose if enabled

[So9q]

So9q added a comment.


  In T272088#7772946 , 
@maynorc wrote:
  
  > In T272088#7661705 , 
@So9q wrote:
  >
  >> In T272088#6751351 , 
@Xqt wrote:
  >>
  >>> I see. 'pywiki' logger will be initialized to level 11 and there is no 
easy way to change that. As a work-around you can modify the logger after it 
was initialized e.g.
  >>>
  >>>   import logging
  >>>   import pywikibot
  >>>   pywikibot.output('This will initialize the logger')
  >>>   logger = logging.getLogger('pywiki')
  >>>   logger.setLevel(logging.WARNING)
  >>>   pywikibot.output('This message will not be logged anymore')
  >>>   pywikibot.log('Also verbose lgs are hidden')
  >>>   pywikibot.warning('Warnings are still logged')
  >>>   pywikibot.error('Errors are logged too.)
  >>
  >> This workaround did not work for me  :/
  >>
  >> I commented out the whole content of bot.py: writelogheader() and that did 
the trick!
  >
  > @So9q, starting to work on this item now; by "did not work" do you mean you 
still see the ~300 lines of verbose log output? What platform are you running 
on?
  
  Yes, PyCharm on W10 . Version 7.2.0
  See the source code here 
https://github.com/internetarchive/wcdimportbot/blob/92ee7310a10195ce8d202a1b829ddb9a2afd8578/src/__init__.py#L18
  F35103737: bild.png 

TASK DETAIL
  https://phabricator.wikimedia.org/T272088

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: maynorc, So9q
Cc: So9q, maynorc, AntiCompositeNumber, CONFIQ, Xqt, Aklapper, Inductiveload, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T272088: Logging (pywiki module) always verbose if enabled

[Xqt]

Xqt added a comment.


  @maynorc: Are you still working on it? Do you need any help?

TASK DETAIL
  https://phabricator.wikimedia.org/T272088

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: maynorc, Xqt
Cc: So9q, maynorc, AntiCompositeNumber, CONFIQ, Xqt, Aklapper, Inductiveload, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T272088: Logging (pywiki module) always verbose if enabled

[maynorc]

maynorc added a comment.


  In T272088#7661705 , @So9q 
wrote:
  
  > In T272088#6751351 , 
@Xqt wrote:
  >
  >> I see. 'pywiki' logger will be initialized to level 11 and there is no 
easy way to change that. As a work-around you can modify the logger after it 
was initialized e.g.
  >>
  >>   import logging
  >>   import pywikibot
  >>   pywikibot.output('This will initialize the logger')
  >>   logger = logging.getLogger('pywiki')
  >>   logger.setLevel(logging.WARNING)
  >>   pywikibot.output('This message will not be logged anymore')
  >>   pywikibot.log('Also verbose lgs are hidden')
  >>   pywikibot.warning('Warnings are still logged')
  >>   pywikibot.error('Errors are logged too.)
  >
  > This workaround did not work for me  :/
  >
  > I commented out the whole content of bot.py: writelogheader() and that did 
the trick!
  
  @So9q, starting to work on this item now; by "did not work" do you mean you 
still see the ~300 lines of verbose log output? What platform are you running 
on?

TASK DETAIL
  https://phabricator.wikimedia.org/T272088

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: maynorc
Cc: So9q, maynorc, AntiCompositeNumber, CONFIQ, Xqt, Aklapper, Inductiveload, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T272088: Logging (pywiki module) always verbose if enabled

[So9q]

So9q added a comment.


  In T272088#6751351 , @Xqt 
wrote:
  
  > I see. 'pywiki' logger will be initialized to level 11 and there is no easy 
way to change that. As a work-around you can modify the logger after it was 
initialized e.g.
  >
  >   import logging
  >   import pywikibot
  >   pywikibot.output('This will initialize the logger')
  >   logger = logging.getLogger('pywiki')
  >   logger.setLevel(logging.WARNING)
  >   pywikibot.output('This message will not be logged anymore')
  >   pywikibot.log('Also verbose lgs are hidden')
  >   pywikibot.warning('Warnings are still logged')
  >   pywikibot.error('Errors are logged too.)
  
  This workaround did not work for me  :/
  
  I commented out the whole content of bot.py: writelogheader() and that did 
the trick!

TASK DETAIL
  https://phabricator.wikimedia.org/T272088

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: maynorc, So9q
Cc: So9q, maynorc, AntiCompositeNumber, CONFIQ, Xqt, Aklapper, Inductiveload, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T272088: Logging (pywiki module) always verbose if enabled

[Xqt]

Xqt added a comment.


  In T272088#7551453 , 
@maynorc wrote:
  
  >> 'pywiki' logger will be initialized to level 11 and there is no easy way 
to change that
  >
  > Python's `logging` module offers a lot of options 
 for 
configuration; would it make sense to move some of this hardcoded configuration 
to a config file?
  
  user-config.py is able to hold such settings already e.g. with the sample 
given above:
  
logger = logging.getLogger('pywiki')
logger.setLevel(logging.WARNING)
  
  but a config file should be preferred anyway.

TASK DETAIL
  https://phabricator.wikimedia.org/T272088

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: maynorc, AntiCompositeNumber, CONFIQ, Xqt, Aklapper, Inductiveload, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T272088: Logging (pywiki module) always verbose if enabled

[maynorc]

maynorc added a comment.


  > 'pywiki' logger will be initialized to level 11 and there is no easy way to 
change that
  
  Python's `logging` module offers a lot of options 
 for 
configuration; would it make sense to move some of this hardcoded configuration 
to a config file?

TASK DETAIL
  https://phabricator.wikimedia.org/T272088

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: maynorc
Cc: maynorc, AntiCompositeNumber, CONFIQ, Xqt, Aklapper, Inductiveload, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T272088: Logging (pywiki module) always verbose if enabled

[Xqt]

Xqt added a comment.


  I see. 'pywiki' logger will be initialized to level 11 and there is no easy 
way to change that. As a work-around you can modify the logger after it was 
initialized e.g.
  
import logging
import pywikibot
pywikibot.output('This will initialize the logger')
logger = logging.getLogger('pywiki')
logger.setLevel(logging.WARNING)
pywikibot.output('This message will not be logged anymore')
pywikibot.log('Also verbose lgs are hidden')
pywikibot.warning('Warnings are still logged')
pywikibot.error('Errors are logged too.)

TASK DETAIL
  https://phabricator.wikimedia.org/T272088

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Xqt, Aklapper, Inductiveload, pywikibot-bugs-list, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, 
Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T272088: Logging (pywiki module) always verbose if enabled

[Inductiveload]

Inductiveload added a comment.


  @Xqt sure, but the following program should not produce any logging:
  
#! /usr/bin/env python3

import pywikibot
import logging

logging.basicConfig(level=logging.WARNING)
  
  But instead it produces 298 lines that all start with `VERBOSE:pywiki:  `
  
  This is with Pywikibot `5.5.0`

TASK DETAIL
  https://phabricator.wikimedia.org/T272088

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Inductiveload
Cc: Xqt, Aklapper, Inductiveload, pywikibot-bugs-list, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, 
Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T272088: Logging (pywiki module) always verbose if enabled

[Xqt]

Xqt added a comment.


  Logging is a facility Pyhton module and part of ist standard library. How is 
this related to pywikibot framework and what dou you expect on our side? 
Probably use Python's bug Tracker: https://docs.python.org/3/bugs.html

TASK DETAIL
  https://phabricator.wikimedia.org/T272088

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Xqt, Aklapper, Inductiveload, pywikibot-bugs-list, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, 
Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs