[Pywikipedia-bugs] [Maniphest] [Commented On] T313785: Archive variables being changed onwiki and saved as such

2022-07-27 Thread MarcoAurelio 
MarcoAurelio added a comment.


  Thanks @Xqt - This is what I get:
  
tools.mabot@tools-sgebastion-10:/data/project/shared/pywikipedia/core$ 
python3 pwb.py version
Pywikibot: [https] r-pywikibot-core.git (3cec5b0, g1, 2022/07/26, 21:40:46, 
master)
Release version: 7.6.0.dev2
setuptools version: 40.8.0
mwparserfromhell version: 0.6.3
wikitextparser version: n/a
requests version: 2.21.0
  cacerts: /etc/ssl/certs/ca-certificates.crt
certificate test: ok
Python: 3.7.3 (default, Jan 22 2021, 20:04:44)
[GCC 8.3.0]

TASK DETAIL
  https://phabricator.wikimedia.org/T313785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt, MarcoAurelio
Cc: Chenzw, matej_suchanek, MarcoAurelio, Xqt, Aklapper, PotsdamLamb, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, MJL, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, 
Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T313785: Archive variables being changed onwiki and saved as such

2022-07-26 Thread gerritbot 
gerritbot added a comment.


  Change 817363 **merged** by Xqt:
  
  [pywikibot/core@stable] [backport] backport archivebot.py from master
  
  https://gerrit.wikimedia.org/r/817363

TASK DETAIL
  https://phabricator.wikimedia.org/T313785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt, gerritbot
Cc: Chenzw, matej_suchanek, MarcoAurelio, Xqt, Aklapper, PotsdamLamb, 
pywikibot-bugs-list, Hellket777, 786, Biggs657, Jyoo1011, JohnsonLee01, 
Juan90264, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, 
Hook696, MJL, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, 
Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, 
JJMC89, Maathavan, Dvorapa, Altostratus, Neuronton, Avicennasis, mys_721tx, 
jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T313785: Archive variables being changed onwiki and saved as such

2022-07-26 Thread gerritbot 
gerritbot added a comment.


  Change 817363 had a related patch set uploaded (by Xqt; author: Xqt):
  
  [pywikibot/core@stable] [backport] backport archivebot.py from master
  
  https://gerrit.wikimedia.org/r/817363

TASK DETAIL
  https://phabricator.wikimedia.org/T313785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Chenzw, matej_suchanek, MarcoAurelio, Xqt, Aklapper, PotsdamLamb, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, MJL, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, 
Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T313785: Archive variables being changed onwiki and saved as such

2022-07-26 Thread PotsdamLamb 
PotsdamLamb added a comment.


  @MarcoAurelio To get it to change back I had to delete my .pywikibot folder 
and then clone the master that left it at d, however, I have to run AWB to get 
all of the changes made from d to s back to d.

TASK DETAIL
  https://phabricator.wikimedia.org/T313785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: PotsdamLamb
Cc: Chenzw, matej_suchanek, MarcoAurelio, Xqt, Aklapper, PotsdamLamb, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, MJL, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, 
Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T313785: Archive variables being changed onwiki and saved as such

2022-07-26 Thread MarcoAurelio 
MarcoAurelio added a comment.


  Hello @Xqt. By reading the above I see it's safe to continue to run the 
script, right? I'm asking because my bot (which runs on Toolforge's 
`/shared/pywikipedia/core/scripts`) did change 
 on July 25th 
`%(counter)d` to `%(counter)s` and I just wanted to inquire if that'll cause 
any issues.  My bot is //not// running on any of the following languages: bn, 
chb fa, gu, hi, km, kn, lo, lo, ml, or, pa, te. Thank you.

TASK DETAIL
  https://phabricator.wikimedia.org/T313785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: MarcoAurelio
Cc: Chenzw, matej_suchanek, MarcoAurelio, Xqt, Aklapper, PotsdamLamb, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, MJL, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, 
Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T313785: Archive variables being changed onwiki and saved as such

2022-07-26 Thread PotsdamLamb 
PotsdamLamb added a comment.


  Bureaucrat - https://simple.wikipedia.org/wiki/User:Chenzw

TASK DETAIL
  https://phabricator.wikimedia.org/T313785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: PotsdamLamb
Cc: matej_suchanek, MarcoAurelio, Xqt, Aklapper, PotsdamLamb, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, MJL, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, 
Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T313785: Archive variables being changed onwiki and saved as such

2022-07-26 Thread Xqt 
Xqt added a comment.


  In T313785#8105161 , 
@PotsdamLamb wrote:
  
  > Ok, so what will be the impact going forward? Will the stable version 
change the variable on wiki when released, or will it leave it as %d? I just 
need the solid answer as our BC wants to know before I can do more trials as it 
changed everyone's from d to s.
  >
  > Yes, it will change all "d" to "s" on-wiki in the future due to.
  >
  > No, it will not change the "d" to "s" on the wiki, so there will be no 
issues, including backward compatibility.
  >
  > Thanks.
  
  See the table above.
  
  - Running the current master (7.6) will do **no changed** from %d to %s when 
find a %d field except for the new  fields
  - Running the current stable (7.5.1) will **change** from %d to %s when find 
a %d field
  - Running older release 7.5 will **always fail** when find a %d field
  - Running older release 7.4 and below will **always fail on several wikis** 
when find a %d field
  - Running any release will **never fail** and no template changes are made 
when find a %s field
  - **%s fields are** backward **compatible** and upward compatible
  - new **local fields are not** backward **compatible**
  - The current master will become stable in August I guess

TASK DETAIL
  https://phabricator.wikimedia.org/T313785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: matej_suchanek, MarcoAurelio, Xqt, Aklapper, PotsdamLamb, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, MJL, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, 
Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T313785: Archive variables being changed onwiki and saved as such

2022-07-26 Thread PotsdamLamb 
PotsdamLamb added a comment.


  Ok, so what will be the impact going forward? Will the stable version change 
the variable on wiki when released, or will it leave it as %d? I just need the 
solid answer as our BC wants to know before I can do more trials as it changed 
everyone's from d to s.
  
  Yes, it will change all "d" to "s" on-wiki in the future due to.
  
  No, it will not change the "d" to "s" on the wiki, so there will be no 
issues, including backward compatibility.
  
  Thanks.

TASK DETAIL
  https://phabricator.wikimedia.org/T313785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: PotsdamLamb
Cc: matej_suchanek, MarcoAurelio, Xqt, Aklapper, PotsdamLamb, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, MJL, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, 
Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T313785: Archive variables being changed onwiki and saved as such

2022-07-26 Thread Xqt 
Xqt added a comment.


  You can also run the  master branch on toolforge. There is no impact to 
convert fields from %d to %s. The master branch is the development fork. It is 
merged to the stable branch roughly every month.

TASK DETAIL
  https://phabricator.wikimedia.org/T313785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: matej_suchanek, MarcoAurelio, Xqt, Aklapper, PotsdamLamb, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, MJL, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, 
Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T313785: Archive variables being changed onwiki and saved as such

2022-07-26 Thread PotsdamLamb 
PotsdamLamb added a comment.


  matej_suchanek,
  
  I ran a test on my talk page and it again converted the "d" to "s" on wiki as 
you can see in this diff 
https://simple.wikipedia.org/w/index.php?title=User_talk:PotsdamLamb&type=revision&diff=8362575&oldid=8362568&diffmode=source.
  
  Before I ran it, I did clone using git clone --recursive --branch stable 
"https://gerrit.wikimedia.org/r/pywikibot/core"; $HOME/pywikibot
  
  Now what I did was on my local install I ran git clone --recursive --branch 
master "https://gerrit.wikimedia.org/r/pywikibot/core"; $HOME/pywikibot
  
  This did not change the variable from "%d" to "%s" on-wiki as you can see in 
this diff 
https://simple.wikipedia.org/w/index.php?title=User_talk:PotsdamLamb&type=revision&diff=8362590&oldid=8362580&diffmode=source.
 Prior to running this I had changed the %s back to %d; this has the desired 
effect.
  
  Is it possible the master branch did not replicate to the stable version?

TASK DETAIL
  https://phabricator.wikimedia.org/T313785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: PotsdamLamb
Cc: matej_suchanek, MarcoAurelio, Xqt, Aklapper, PotsdamLamb, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, MJL, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, 
Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T313785: Archive variables being changed onwiki and saved as such

2022-07-26 Thread Xqt 
Xqt added a comment.


  > It should leave it as %d or it breaks backwards compatibility.
  
  Having %s instead of %d does not break anything because %s can work with any 
python types whereas %d accepts real numbers only.
  
  Having %d instead of %s lead archivebot to fail on a few of small wikis like 
bn, chk, fa, hi and others for seven years but it would work with %s. With 
Python 7.5.0 the textlib.to_local_number function was fixed but unfortunately 
this broke archivebot when having %d variable fields. Therefore a patch was 
made fix this issue by converting %d to %s because all fields are strings not 
numbers after textlib.to_local_number changes.
  
  With  rPWBC5178710 

 the 7 years old patch was dropped and few new fields were intoduced. This 
patch is part of the current master and will be ported to stable release in 
about 4 weeks. The new fields must use %s formatting whereas the old field can 
use %d formatting for the number fields. The following table shows what happens 
for `counter` field and the new `localcounter` field as a sample.
  
  Small wikis
  ---
  
  Language code: bn, chb fa, gu, hi, km, kn, lo, lo, ml, or, pa, te
  All numbers are localized with Pywikibot 7.5.1 and below. With Pywikibot 7.6 
the `local...` fields must be used instead.
  
  | **Pywikibot release** | **%(counter)s**  | **%(counter)d**  
| **%(localcounter)s**  | **%(localcounter)d** |
  | 7.6.0  //master// | {icon check color=green} | {icon check color=green} 
| {icon check  color=green} | {icon check-circle color=yellow} |
  | 7.5.1 //stable//  | {icon check color=green} | {icon check-circle 
color=yellow} | {icon times color=red}| {icon times color=red}   |
  | 7.5.0 | {icon check color=green} | {icon times color=red}   
| {icon times color=red}| {icon times color=red}   |
  | 7.4.0 and below   | {icon check color=green} | {icon times color=red}   
| {icon times color=red}| {icon times color=red}   |
  |
  
  
  
  Other wikis
  ---
  
  | **Pywikibot release** | **%(counter)s**  | **%(counter)d**  
| **%(localcounter)s**  | **%(localcounter)d** |
  | 7.6.0 //master//  | {icon check color=green} | {icon check color=green} 
| {icon check  color=green} | {icon check-circle color=yellow} |
  | 7.5.1 //stable//  | {icon check color=green} | {icon check-circle 
color=yellow} | {icon times color=red}| {icon times color=red}   |
  | 7.5.0 | {icon check color=green} | {icon times color=red}   
| {icon times color=red}| {icon times color=red}   |
  | 7.4.0 and below   | {icon check color=green} | {icon check color=green} 
| {icon times color=red}| {icon times color=red}   |
  |
  
  Legend
  --
  
  | **icon** | **behavior**|
  | {icon check color=green} | Bot works   |
  | {icon check-circle color=yellow} | Bot works but templates are changed |
  | {icon times color=red}   | Bot fails   |
  |
  
  
  
  WARNING: The fields `monthname` and `monthnameshort` must always **%s** 
format.

TASK DETAIL
  https://phabricator.wikimedia.org/T313785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: matej_suchanek, MarcoAurelio, Xqt, Aklapper, PotsdamLamb, 
pywikibot-bugs-list, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, MJL, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, 
Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T313785: Archive variables being changed onwiki and saved as such

2022-07-26 Thread Stashbot 
Stashbot added a comment.


  Mentioned in SAL (#wikimedia-cloud) [2022-07-26T09:11:12Z]  
 Temporarily suspend archivebot operations refs. T313785 


TASK DETAIL
  https://phabricator.wikimedia.org/T313785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stashbot
Cc: Xqt, Aklapper, PotsdamLamb, pywikibot-bugs-list, Jyoo1011, JohnsonLee01, 
SHEKH, Dijkstra, Khutuck, Zkhalido, MJL, Viztor, Wenyi, Tbscho, MayS, Mdupont, 
JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T313785: Archive variables being changed onwiki and saved as such

2022-07-26 Thread PotsdamLamb 
PotsdamLamb added a comment.


  Also, from the trial run it had converted my %d to %s so that needs to be 
reverted as well.

TASK DETAIL
  https://phabricator.wikimedia.org/T313785

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: PotsdamLamb
Cc: Xqt, Aklapper, PotsdamLamb, pywikibot-bugs-list, Jyoo1011, JohnsonLee01, 
SHEKH, Dijkstra, Khutuck, Zkhalido, MJL, Viztor, Wenyi, Tbscho, MayS, Mdupont, 
JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org