[Pywikipedia-bugs] [Maniphest] [Commented On] T57185: cosmetic_changes bug on citation's number and punctuation

[gerritbot]

gerritbot added a comment.Restricted Application added a subscriber: Cyberpower678.
Change 478641 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [doc] Fix task number of T57185

https://gerrit.wikimedia.org/r/478641TASK DETAILhttps://phabricator.wikimedia.org/T57185EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Cyberpower678, gerritbot, jayvdb, Aklapper, Xqt, Legoktm, pywikibot-bugs-list, Ladsgroup, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T57185: cosmetic_changes bug on citation's number and punctuation

[gerritbot]

gerritbot added a comment.
Change 478641 merged by jenkins-bot:
[pywikibot/core@master] [doc] Fix task number of T57185

https://gerrit.wikimedia.org/r/478641TASK DETAILhttps://phabricator.wikimedia.org/T57185EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Cyberpower678, gerritbot, jayvdb, Aklapper, Xqt, Legoktm, pywikibot-bugs-list, Ladsgroup, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Mahveotm, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T57185: cosmetic_changes bug on citation's number and punctuation

[jayvdb]

jayvdb added a comment.


  In https://phabricator.wikimedia.org/T57185#616503, @Legoktm wrote:
  
  > thank you also please disable punctuation part , to ، is not correct and it 
needs to define many exceptions.
  >
  > 
http://fa.wikipedia.org/w/index.php?title=%D9%81%D9%87%D8%B1%D8%B3%D8%AA\_%D8%AC%D9%85%D8%A7%D8%B9%D8%AA%E2%80%8C%D9%87%D8%A7%DB%8C\_%D8%AA%D8%A7%D8%AC%DB%8C%DA%A9%D8%B3%D8%AA%D8%A7%D9%86&diff=prev&oldid=7333963
  
  
  I am unable to reproduce this now.  I believe it was fixed with 
https://phabricator.wikimedia.org/rPWBO7c13ecbb21ddb70a3cbdaf93b18e1ac12c1b9caa

TASK DETAIL
  https://phabricator.wikimedia.org/T57185

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, jayvdb
Cc: jayvdb, Aklapper, Xqt, Legoktm, pywikibot-bugs-list, Ladsgroup, Anshoe



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T57185: cosmetic_changes bug on citation's number and punctuation

[gerritbot]

gerritbot added a comment.


  Change 246793 had a related patch set uploaded (by John Vandenberg):
  Add CC -experimental to use disabled fixes
  
  https://gerrit.wikimedia.org/r/246793

TASK DETAIL
  https://phabricator.wikimedia.org/T57185

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: gerritbot, jayvdb, Aklapper, Xqt, Legoktm, pywikibot-bugs-list, Ladsgroup, 
Anshoe



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T57185: cosmetic_changes bug on citation's number and punctuation

[jayvdb]

jayvdb added a comment.


  A page which can be used to show digits are still problematic is 
https://fa.wikipedia.org/wiki/.aq 
  If that is run in normal cc , no problems.
  Enable `-experimental -simulate` with my patch, and it will try to convert 
the Latin digits in the dates to Farsi digits.  To fix this, we need to convert 
the Latin based dates into other calendar dates.

TASK DETAIL
  https://phabricator.wikimedia.org/T57185

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, jayvdb
Cc: gerritbot, jayvdb, Aklapper, Xqt, Legoktm, pywikibot-bugs-list, Ladsgroup, 
Lewizho99, Anshoe



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T57185: cosmetic_changes bug on citation's number and punctuation

[Xqt]

Xqt added a comment.


  Deactivated code due to T57185 
  
# valid digits
digits = {
'ckb': ('٠١٢٣٤٥٦٧٨٩', 'fa'),
'fa': ('۰۱۲۳۴۵۶۷۸۹', 'ckb'),
}

# For replacing old digits by new one
new, old_key = digits[self.site.code]
old = digits[old_key][0]

# FIXME: split this function into two.
# replace persian/arabic digits
# deactivated due to bug T57185
for i in range(0, 10):
text = textlib.replaceExcept(text, old[i], new[i], exceptions)
# do not change digits in class, style and table params
pattern = re.compile(r'\w+=(".+?"|\d+)', re.UNICODE)
exceptions.append(pattern)
# do not change digits inside html-tags
pattern = re.compile('<[/]*?[^', re.UNICODE)
exceptions.append(pattern)
exceptions.append('table')  # exclude tables for now
# replace digits
for i in range(0, 10):
text = textlib.replaceExcept(text, str(i), new[i], exceptions)
return text

TASK DETAIL
  https://phabricator.wikimedia.org/T57185

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Cyberpower678, gerritbot, jayvdb, Aklapper, Xqt, Legoktm, 
pywikibot-bugs-list, Ladsgroup, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T57185: cosmetic_changes bug on citation's number and punctuation

[gerritbot]

gerritbot added a comment.


  Change 246793 abandoned by Xqt:
  Add CC -experimental to use disabled fixes
  
  Reason:
  -experimental does not solve that issue
  
  https://gerrit.wikimedia.org/r/246793

TASK DETAIL
  https://phabricator.wikimedia.org/T57185

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Cyberpower678, gerritbot, jayvdb, Aklapper, Xqt, Legoktm, 
pywikibot-bugs-list, Ladsgroup, JohnsonLee01, SHEKH, Dijkstra, Khutuck, 
Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs