[Pywikipedia-bugs] [Maniphest] [Commented On] T76615: Claim equality operator
Lokal_Profil added a comment. In T76615#4946521, @matej_suchanek wrote: Yep, being fixed in https://gerrit.wikimedia.org/r/c/pywikibot/core/+/489733. ThanksTASK DETAILhttps://phabricator.wikimedia.org/T76615EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, Lokal_ProfilCc: gerritbot, Dalba, Xqt, matej_suchanek, Lokal_Profil, jayvdb, Aklapper, pywikibot-bugs-list, Wenyi, Mahveotm, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, Ricordisamoa, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T76615: Claim equality operator
Lokal_Profil added a comment. After this merged I'm getting downstream errors because Claim is now an unhashable type.TASK DETAILhttps://phabricator.wikimedia.org/T76615EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, Lokal_ProfilCc: gerritbot, Dalba, Xqt, matej_suchanek, Lokal_Profil, jayvdb, Aklapper, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Mahveotm, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, Ricordisamoa, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T76615: Claim equality operator
gerritbot added a comment. Change 378987 merged by jenkins-bot: [pywikibot/core@master] Implement Claim.eq https://gerrit.wikimedia.org/r/378987TASK DETAILhttps://phabricator.wikimedia.org/T76615EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, gerritbotCc: gerritbot, Dalba, Xqt, matej_suchanek, Lokal_Profil, jayvdb, Aklapper, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Mahveotm, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, Ricordisamoa, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T76615: Claim equality operator
gerritbot added a comment. Change 378987 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek): [pywikibot/core@master] Implement Claim.eq https://gerrit.wikimedia.org/r/378987TASK DETAILhttps://phabricator.wikimedia.org/T76615EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Dalba, Xqt, matej_suchanek, Lokal_Profil, jayvdb, Aklapper, pywikibot-bugs-list, Ricordisamoa___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T76615: Claim equality operator
Lokal_Profil added a comment. Thanks. That strengthens my belief that they should not be included in a comparison. What speaks for them being included though is that they are properties of the pywikibot.Claim object (which is thus an hybrid of a claim and a statement)TASK DETAILhttps://phabricator.wikimedia.org/T76615EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: matej_suchanek, Lokal_Profil, jayvdb, Aklapper, pywikibot-bugs-list, Ricordisamoa___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T76615: Claim equality operator
matej_suchanek added a comment. A Statement consists of two parts: a claim that something is the case (e.g., the claim "Berlin has a population of 3,499,879") and a list of references for that claim (e.g., a publication by the statistical office for Berlin-Brandenburg).[1] [1] https://www.mediawiki.org/wiki/Wikibase/DataModel#Overview_of_the_data_model In other words, references (sources) are not part of a claim.TASK DETAILhttps://phabricator.wikimedia.org/T76615EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: matej_suchanek, Lokal_Profil, jayvdb, Aklapper, pywikibot-bugs-list, Ricordisamoa___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T76615: Claim equality operator
Lokal_Profil added a comment. Now that there are equality operators for all allowed claim targets this should be easier to handle. With regards to order of qualifiers/sources and (statements in each source), per this discussion the order should not be assumed to carry any meaning. So we would probably want to disregard it. My main question is if we want to include sources in the comparison. If you want to check if an existing claim is the same as that in another source then it isn't useful to include the source in the comparison. On the other hand, yes it is partTASK DETAILhttps://phabricator.wikimedia.org/T76615EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: Lokal_Profil, jayvdb, Aklapper, pywikibot-bugs-list, Ricordisamoa___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
