[Pywikipedia-bugs] [Maniphest] [Commented On] T90149: LDAP based login is broken in pywikibot because lgdomain is not set
gerritbot added a comment. Change 330144 merged by jenkins-bot: Fix broken LDAP based login https://gerrit.wikimedia.org/r/330144TASK DETAILhttps://phabricator.wikimedia.org/T90149EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Phantom42, gerritbotCc: gerritbot, maiden_taiwan, David.august, AbdealiJK, TerraCodes, Riddlesj, darthbhyrava, jayvdb, XZise, pywikibot-bugs-list, Aklapper, Multichill, Th3d3v1ls, SacredWKnight, JakeTheDeveloper, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, D3r1ck01, Avicennasis, MuhammadShuaib, Dalba, droid, Masti, Alchimista, Rxy, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T90149: LDAP based login is broken in pywikibot because lgdomain is not set
gerritbot added a comment. Change 330144 had a related patch set uploaded (by Phantom42): Fix broken LDAP based login https://gerrit.wikimedia.org/r/330144TASK DETAILhttps://phabricator.wikimedia.org/T90149EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Phantom42, gerritbotCc: gerritbot, maiden_taiwan, David.august, AbdealiJK, TerraCodes, Riddlesj, darthbhyrava, jayvdb, XZise, pywikibot-bugs-list, Aklapper, Multichill, SacredWKnight, JakeTheDeveloper, Magul, Tbscho, MayS, Mdupont, JJMC89, D3r1ck01, Avicennasis, MuhammadShuaib, Dalba, droid, Masti, Alchimista, Rxy, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T90149: LDAP based login is broken in pywikibot because lgdomain is not set
David.august added a comment. The modification to api.py outlined here resolved the issue for me: https://www.linkedin.com/pulse/how-correct-pywikibot-ldap-authentication-error-armando-trinchillo LDAP authentication worked until I added a second domain to the authentication options in my LocalSettings.php. I have not had an opportunity to revert the change and test, but I wanted to mention it just in case it helps reproduce the issue.TASK DETAILhttps://phabricator.wikimedia.org/T90149EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: David.augustCc: David.august, AbdealiJK, TerraCodes, Riddlesj, darthbhyrava, jayvdb, XZise, pywikibot-bugs-list, Aklapper, Multichill, MayS, Mdupont, JJMC89, MuhammadShuaib, droid, Alchimista, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T90149: LDAP based login is broken in pywikibot because lgdomain is not set
AbdealiJK added a comment. why in API.py? Can't it be done in the login.py like how it was done in compact?TASK DETAILhttps://phabricator.wikimedia.org/T90149EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: AbdealiJK, TerraCodes, Riddlesj, darthbhyrava, jayvdb, XZise, pywikibot-bugs-list, Aklapper, Multichill, MayS, Mdupont, JJMC89, MuhammadShuaib, droid, Alchimista, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T90149: LDAP based login is broken in pywikibot because lgdomain is not set
Riddlesj added a comment.Herald added a subscriber: TerraCodes. Hi, I am interested in working on this bug. As far as I understand (from the discussions above) there needs to be a check on ldapDomain and lgdomain should be set accordingly, somewhere near line no. 3036 in api.py i.e. just after the initialisation. I'm completely new to this so please correct me if I'm wrong somewhere and should I move ahead resolving this bug?TASK DETAILhttps://phabricator.wikimedia.org/T90149EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: RiddlesjCc: TerraCodes, Riddlesj, darthbhyrava, jayvdb, XZise, pywikibot-bugs-list, Aklapper, Multichill, MayS, Mdupont, JJMC89, MuhammadShuaib, droid, Alchimista, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T90149: LDAP based login is broken in pywikibot because lgdomain is not set
jayvdb added a comment. @multichill, are you able to test patches for this? TASK DETAIL https://phabricator.wikimedia.org/T90149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: jayvdb, XZise, pywikibot-bugs-list, Aklapper, Multichill, droid ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs