[Pywikipedia-bugs] [Maniphest] [Updated] T213804: Archivebot changes parameter order between Python 2 and 3

2019-01-15 Thread gerritbot 
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T213804EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Dvorapa, gerritbotCc: gerritbot, Xqt, Aklapper, pywikibot-bugs-list, Dvorapa, CucyNoiD, NebulousIris, Wenyi, Kieubinhtb, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Mahveotm, Adrian1985, Asad_Ali_Palijo, Cpaulf30, Lahi, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Soteriaspace, RazeSoldier, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, TerraCodes, Avicennasis, MuhammadShuaib, SimmeD, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T213804: Archivebot changes parameter order between Python 2 and 3

2019-01-15 Thread Xqt 
Xqt added a project: good first bug.Xqt added a comment.
self.attributes is a dict and the sorting order is not deterministic

https://stackoverflow.com/questions/14956313/why-is-dictionary-ordering-non-deterministic

Probably either an OrderedDict could help or sorting the keys before returning the list:

def saveables(self):
"""Return a list of saveable attributes."""
return [a for a in sorted(self.attributes) if self.attributes[a][1]
and a != 'maxage']TASK DETAILhttps://phabricator.wikimedia.org/T213804EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Xqt, Aklapper, pywikibot-bugs-list, Dvorapa, Wenyi, Kieubinhtb, Mahveotm, Asad_Ali_Palijo, Lahi, Soteriaspace, RazeSoldier, JakeTheDeveloper, Tbscho, MayS, Mdupont, JJMC89, TerraCodes, Avicennasis, MuhammadShuaib, SimmeD, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T213804: Archivebot changes parameter order between Python 2 and 3

2019-01-15 Thread Dvorapa 
Dvorapa added a parent task: T60053: Pywikibot Python 3 compatibility (tracking).
TASK DETAILhttps://phabricator.wikimedia.org/T213804EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Aklapper, pywikibot-bugs-list, Dvorapa, Wenyi, Mahveotm, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs