Hi Sinny, I have created a review here: https://phab.qadevel.cloud.fedoraproject.org/D813
I used our Phabricator, because it makes it easy to comment on particular lines. You can log in using your FAS email [1] and reply there, or here in the mailing list, it doesn't matter. I'm pleasantly surprised that despite our very lacking documentation, you managed to create a very good Taskotron task :-) One additional thing that I noticed today - when I ran the abipkgdiff comparison on lyx package, it used up to 6 GB RAM. That is really high and I believe our test clients don't have that many available. I don't know how abipkgdiff works and whether it is able to adjust its memory requirements based on the amount of available system memory (so that it would use less memory on a less equipped system and still work properly). Do you know if this is going to be a problem or not? And do you know what is the peak memory usage for very big packages (e.g. what about comparing two kernel packages)? Is there any solution that we could use to limit the memory consumption of abipkgdiff? Thanks, Kamil [1] Please note we've been experiencing some problems with authentication recently, so it might not work for you: https://phab.qadevel.cloud.fedoraproject.org/T761 _______________________________________________ qa-devel mailing list qa-devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/qa-devel@lists.fedoraproject.org
