Re: [PATCH] hw/sd: sdhci: Enable 64-bit system bus capability in the default SD/MMC host controller

[Joanne Koong]

Awesome! Thank you, Philippe and Bin!

On Mon, Jul 5, 2021 at 2:54 AM Philippe Mathieu-Daudé 
wrote:

> On 6/23/21 8:59 PM, Joanne Koong wrote:
> > The default SD/MMC host controller uses SD spec v2.00. 64-bit system bus
> capability
> > was added in v2.
> >
> > In this change, we arrive at 0x157834b4 by computing (0x057834b4 | (1ul
> << 28))
> > where 28 represents the BUS64BIT SDHC_CAPAB field.
> >
> > Signed-off-by: Joanne Koong 
> > ---
> >  hw/sd/sdhci-internal.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Thanks, series applied to sdmmc-next tree.
>

[PATCH] hw/sd: sdhci: Enable 64-bit system bus capability in the default SD/MMC host controller

[Joanne Koong]

The default SD/MMC host controller uses SD spec v2.00. 64-bit system bus 
capability
was added in v2.

In this change, we arrive at 0x157834b4 by computing (0x057834b4 | (1ul << 28))
where 28 represents the BUS64BIT SDHC_CAPAB field.

Signed-off-by: Joanne Koong 
---
 hw/sd/sdhci-internal.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h
index e8c753d6d1..a76fc704e5 100644
--- a/hw/sd/sdhci-internal.h
+++ b/hw/sd/sdhci-internal.h
@@ -316,16 +316,16 @@ extern const VMStateDescription sdhci_vmstate;
  * - 3.3v and 1.8v voltages
  * - SDMA/ADMA1/ADMA2
  * - high-speed
+ * - 64-bit system bus
  * max host controller R/W buffers size: 512B
  * max clock frequency for SDclock: 52 MHz
  * timeout clock frequency: 52 MHz
  *
  * does not support:
  * - 3.0v voltage
- * - 64-bit system bus
  * - suspend/resume
  */
-#define SDHC_CAPAB_REG_DEFAULT 0x057834b4
+#define SDHC_CAPAB_REG_DEFAULT 0x157834b4
 
 #define DEFINE_SDHCI_COMMON_PROPERTIES(_state) \
 DEFINE_PROP_UINT8("sd-spec-version", _state, sd_spec_version, 2), \
-- 
2.20.1

Re: SD/MMC host controller + 64-bit system bus

[Joanne Koong]

Great!! I'm happy to do so. Thanks for the reply!

On Tue, Jun 22, 2021 at 1:51 PM Philippe Mathieu-Daudé 
wrote:

> Hi Joanne,
>
> On 6/22/21 8:07 PM, Joanne Koong wrote:
> > Hello! I noticed that the default SD/MMC host controller only supports a
> > 32-bit system bus. Is there a reason 64-bit system buses aren't
> > supported by default?
>
> We aim to support the spec v2.00, so this is a bug in the model, 64-bit
> system bus should be supported. Do you mind sending a patch?
>
> Thanks,
>
> Phil.
>

SD/MMC host controller + 64-bit system bus

[Joanne Koong]

Hello! I noticed that the default SD/MMC host controller only supports a
32-bit system bus. Is there a reason 64-bit system buses aren't supported
by default?

Thanks!