RE: [PATCH v4 12/19] target/hexagon: Clean up includes

[Taylor Simpson]

> -Original Message-
> From: Markus Armbruster 
> Sent: Thursday, January 19, 2023 1:00 AM
> To: qemu-de...@nongnu.org
> Cc: richard.hender...@linaro.org; pbonz...@redhat.com;
> kw...@redhat.com; hre...@redhat.com; i...@bsdimp.com;
> kev...@freebsd.org; berra...@redhat.com; gr...@kaod.org;
> qemu_...@crudebyte.com; m...@redhat.com; phi...@linaro.org;
> peter.mayd...@linaro.org; alist...@alistair23.me; jasow...@redhat.com;
> jonathan.came...@huawei.com; kbast...@mail.uni-paderborn.de;
> quint...@redhat.com; dgilb...@redhat.com; michael.r...@amd.com;
> kkost...@redhat.com; Taylor Simpson ;
> pal...@dabbelt.com; bin.m...@windriver.com; qemu-block@nongnu.org;
> qemu-...@nongnu.org; qemu-ri...@nongnu.org
> Subject: [PATCH v4 12/19] target/hexagon: Clean up includes
> 
> Clean up includes so that osdep.h is included first and headers which it
> implies are not included manually.
> 
> This commit was created with scripts/clean-includes.
> 
> Changes to standalone programs dropped, because I can't tell whether them
> not using qemu/osdep.h is intentional:
> 
> target/hexagon/gen_dectree_import.c
> target/hexagon/gen_semantics.c
> target/hexagon/idef-parser/idef-parser.h
> target/hexagon/idef-parser/parser-helpers.c
> target/hexagon/idef-parser/parser-helpers.h

Correct.  These are standalone programs not built with the full QEMU context.

> 
> Signed-off-by: Markus Armbruster 
> ---
>  target/hexagon/hex_arch_types.h | 1 -
>  target/hexagon/mmvec/macros.h   | 1 -
>  2 files changed, 2 deletions(-)

Reviewed-by: Taylor Simpson 

RE: [PATCH-for-6.2? v2 2/3] misc: Spell QEMU all caps

[Taylor Simpson]

> -Original Message-
> From: Philippe Mathieu-Daudé 
> Sent: Friday, November 19, 2021 3:17 AM
> To: qemu-de...@nongnu.org
> Cc: Cleber Rosa ; John Snow ; Eric
> Blake ; Markus Armbruster ;
> Hanna Reitz ; Michael Roth ;
> qemu-block@nongnu.org; Marcelo Tosatti ; Vladimir
> Sementsov-Ogievskiy ; Eduardo Habkost
> ; Taylor Simpson ;
> k...@vger.kernel.org; Paolo Bonzini ; Kevin Wolf
> ; Philippe Mathieu-Daudé 
> Subject: [PATCH-for-6.2? v2 2/3] misc: Spell QEMU all caps
> 
> QEMU should be written all caps.
> 
> Normally checkpatch.pl warns when it is not (see commit
> 9964d8f9422: "checkpatch: Add QEMU specific rule").
> 
> Replace Qemu -> QEMU.
> 
> Signed-off-by: Philippe Mathieu-Daudé 


> --git a/target/hexagon/README b/target/hexagon/README index
> 372e24747c9..b02dbbd1701 100644
> --- a/target/hexagon/README
> +++ b/target/hexagon/README
> @@ -48,7 +48,7 @@ header files in /target/hexagon
>  gen_tcg_func_table.py   -> tcg_func_table_generated.c.inc
>  gen_helper_funcs.py -> helper_funcs_generated.c.inc
> 
> -Qemu helper functions have 3 parts
> +QEMU helper functions have 3 parts
>  DEF_HELPER declaration indicates the signature of the helper
>  gen_helper_ will generate a TCG call to the helper function
>  The helper implementation
> diff --git a/tests/guest-debug/run-test.py b/tests/guest-debug/run-test.py

Reviewed-by: Taylor Simpson