Re: [PATCH 0/2] Let 'qemu-img convert --bitmaps' skip inconsistent bitmaps

2021-07-09 Thread Vladimir Sementsov-Ogievskiy 

08.07.2021 04:29, Eric Blake wrote:

This is mostly a convenience factor as one could already use 'qemu-img
info' to learn which bitmaps are broken and then 'qemu-img bitmap
--remove' to nuke them before calling 'qemu-img convert --bitmaps',
but it does have the advantage that the copied file is usable without
extra efforts and the broken bitmap is not deleted from the source
file.

Eric Blake (2):
   iotests: Improve and rename test 291 to qemu-img-bitmap
   qemu-img: Add --skip-broken for 'convert --bitmaps'

  docs/tools/qemu-img.rst   |  8 +++-
  block/dirty-bitmap.c  |  2 +-
  qemu-img.c| 20 +++-
  .../{291 => tests/qemu-img-bitmaps}   | 17 ++-
  .../{291.out => tests/qemu-img-bitmaps.out}   | 46 ++-
  5 files changed, 87 insertions(+), 6 deletions(-)
  rename tests/qemu-iotests/{291 => tests/qemu-img-bitmaps} (88%)
  rename tests/qemu-iotests/{291.out => tests/qemu-img-bitmaps.out} (76%)



I've applied this onto your nbd branch. This doesn't apply on master.

--
Best regards,
Vladimir

[PATCH 0/2] Let 'qemu-img convert --bitmaps' skip inconsistent bitmaps

2021-07-07 Thread Eric Blake 
This is mostly a convenience factor as one could already use 'qemu-img
info' to learn which bitmaps are broken and then 'qemu-img bitmap
--remove' to nuke them before calling 'qemu-img convert --bitmaps',
but it does have the advantage that the copied file is usable without
extra efforts and the broken bitmap is not deleted from the source
file.

Eric Blake (2):
  iotests: Improve and rename test 291 to qemu-img-bitmap
  qemu-img: Add --skip-broken for 'convert --bitmaps'

 docs/tools/qemu-img.rst   |  8 +++-
 block/dirty-bitmap.c  |  2 +-
 qemu-img.c| 20 +++-
 .../{291 => tests/qemu-img-bitmaps}   | 17 ++-
 .../{291.out => tests/qemu-img-bitmaps.out}   | 46 ++-
 5 files changed, 87 insertions(+), 6 deletions(-)
 rename tests/qemu-iotests/{291 => tests/qemu-img-bitmaps} (88%)
 rename tests/qemu-iotests/{291.out => tests/qemu-img-bitmaps.out} (76%)

-- 
2.31.1