Re: [PATCH 07/10] tests/npcm7xx_adc: Clean up global variable shadowing

2023-10-12 Thread Thomas Huth

On 09/10/2023 12.02, Philippe Mathieu-Daudé wrote:

Rename the global 'adc' variable in order to avoid:

   tests/qtest/npcm7xx_adc-test.c:98:58: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
   static uint32_t adc_read_con(QTestState *qts, const ADC *adc)
^
   tests/qtest/npcm7xx_adc-test.c:103:55: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
   static void adc_write_con(QTestState *qts, const ADC *adc, uint32_t value)
 ^
   tests/qtest/npcm7xx_adc-test.c:108:59: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
   static uint32_t adc_read_data(QTestState *qts, const ADC *adc)
 ^
   tests/qtest/npcm7xx_adc-test.c:119:53: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
   static void adc_qom_set(QTestState *qts, const ADC *adc,
   ^
   tests/qtest/npcm7xx_adc-test.c:135:57: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
   static void adc_write_input(QTestState *qts, const ADC *adc,
   ^
   tests/qtest/npcm7xx_adc-test.c:144:56: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
   static void adc_write_vref(QTestState *qts, const ADC *adc, uint32_t value)
  ^
   tests/qtest/npcm7xx_adc-test.c:162:59: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
   static uint32_t adc_prescaler(QTestState *qts, const ADC *adc)
 ^
   tests/qtest/npcm7xx_adc-test.c:175:64: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
   static void adc_wait_conv_finished(QTestState *qts, const ADC *adc,
  ^
   tests/qtest/npcm7xx_adc-test.c:196:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
 const ADC *adc = adc_p;
^
   tests/qtest/npcm7xx_adc-test.c:207:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
 const ADC *adc = adc_p;
^
   tests/qtest/npcm7xx_adc-test.c:235:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
 const ADC *adc = adc_p;
^
   tests/qtest/npcm7xx_adc-test.c:267:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
 const ADC *adc = adc_p;
^
   tests/qtest/npcm7xx_adc-test.c:293:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
 const ADC *adc = adc_p;
^
   tests/qtest/npcm7xx_adc-test.c:311:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
 const ADC *adc = adc_p;
^
   tests/qtest/npcm7xx_adc-test.c:93:5: note: previous declaration is here
   ADC adc = {
   ^

Signed-off-by: Philippe Mathieu-Daudé 
---
  tests/qtest/npcm7xx_adc-test.c | 14 +++---
  1 file changed, 7 insertions(+), 7 deletions(-)


Reviewed-by: Thomas Huth 




[PATCH 07/10] tests/npcm7xx_adc: Clean up global variable shadowing

2023-10-09 Thread Philippe Mathieu-Daudé
Rename the global 'adc' variable in order to avoid:

  tests/qtest/npcm7xx_adc-test.c:98:58: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
  static uint32_t adc_read_con(QTestState *qts, const ADC *adc)
   ^
  tests/qtest/npcm7xx_adc-test.c:103:55: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
  static void adc_write_con(QTestState *qts, const ADC *adc, uint32_t value)
^
  tests/qtest/npcm7xx_adc-test.c:108:59: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
  static uint32_t adc_read_data(QTestState *qts, const ADC *adc)
^
  tests/qtest/npcm7xx_adc-test.c:119:53: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
  static void adc_qom_set(QTestState *qts, const ADC *adc,
  ^
  tests/qtest/npcm7xx_adc-test.c:135:57: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
  static void adc_write_input(QTestState *qts, const ADC *adc,
  ^
  tests/qtest/npcm7xx_adc-test.c:144:56: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
  static void adc_write_vref(QTestState *qts, const ADC *adc, uint32_t value)
 ^
  tests/qtest/npcm7xx_adc-test.c:162:59: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
  static uint32_t adc_prescaler(QTestState *qts, const ADC *adc)
^
  tests/qtest/npcm7xx_adc-test.c:175:64: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
  static void adc_wait_conv_finished(QTestState *qts, const ADC *adc,
 ^
  tests/qtest/npcm7xx_adc-test.c:196:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
const ADC *adc = adc_p;
   ^
  tests/qtest/npcm7xx_adc-test.c:207:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
const ADC *adc = adc_p;
   ^
  tests/qtest/npcm7xx_adc-test.c:235:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
const ADC *adc = adc_p;
   ^
  tests/qtest/npcm7xx_adc-test.c:267:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
const ADC *adc = adc_p;
   ^
  tests/qtest/npcm7xx_adc-test.c:293:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
const ADC *adc = adc_p;
   ^
  tests/qtest/npcm7xx_adc-test.c:311:16: error: declaration shadows a variable 
in the global scope [-Werror,-Wshadow]
const ADC *adc = adc_p;
   ^
  tests/qtest/npcm7xx_adc-test.c:93:5: note: previous declaration is here
  ADC adc = {
  ^

Signed-off-by: Philippe Mathieu-Daudé 
---
 tests/qtest/npcm7xx_adc-test.c | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/tests/qtest/npcm7xx_adc-test.c b/tests/qtest/npcm7xx_adc-test.c
index 8048044d28..e751a72e36 100644
--- a/tests/qtest/npcm7xx_adc-test.c
+++ b/tests/qtest/npcm7xx_adc-test.c
@@ -90,7 +90,7 @@ typedef struct ADC {
 uint64_t base_addr;
 } ADC;
 
-ADC adc = {
+ADC adc_defs = {
 .irq= 0,
 .base_addr  = 0xf000c000
 };
@@ -367,12 +367,12 @@ int main(int argc, char **argv)
 {
 g_test_init(&argc, &argv, NULL);
 
-add_test(init, &adc);
-add_test(convert_internal, &adc);
-add_test(convert_external, &adc);
-add_test(interrupt, &adc);
-add_test(reset, &adc);
-add_test(calibrate, &adc);
+add_test(init, &adc_defs);
+add_test(convert_internal, &adc_defs);
+add_test(convert_external, &adc_defs);
+add_test(interrupt, &adc_defs);
+add_test(reset, &adc_defs);
+add_test(calibrate, &adc_defs);
 
 return g_test_run();
 }
-- 
2.41.0