Re: [PATCH 1/3] hw/virtio: Pass virtio_feature_get_config_size() a const argument

[Jason Wang]

在 2021/5/11 下午6:41, Philippe Mathieu-Daudé 写道:

The VirtIOFeature structure isn't modified, mark it const.

Signed-off-by: Philippe Mathieu-Daudé 



Acked-by: Jason Wang 



---
  include/hw/virtio/virtio.h | 2 +-
  hw/virtio/virtio.c | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index b7ece7a6a89..8bab9cfb750 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -43,7 +43,7 @@ typedef struct VirtIOFeature {
  size_t end;
  } VirtIOFeature;
  
-size_t virtio_feature_get_config_size(VirtIOFeature *features,

+size_t virtio_feature_get_config_size(const VirtIOFeature *features,
uint64_t host_features);
  
  typedef struct VirtQueue VirtQueue;

diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 9e13cb9e3ad..e02544b2df7 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -2981,7 +2981,7 @@ int virtio_set_features(VirtIODevice *vdev, uint64_t val)
  return ret;
  }
  
-size_t virtio_feature_get_config_size(VirtIOFeature *feature_sizes,

+size_t virtio_feature_get_config_size(const VirtIOFeature *feature_sizes,
uint64_t host_features)
  {
  size_t config_size = 0;

[PATCH 1/3] hw/virtio: Pass virtio_feature_get_config_size() a const argument

[Philippe Mathieu-Daudé]

The VirtIOFeature structure isn't modified, mark it const.

Signed-off-by: Philippe Mathieu-Daudé 
---
 include/hw/virtio/virtio.h | 2 +-
 hw/virtio/virtio.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index b7ece7a6a89..8bab9cfb750 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -43,7 +43,7 @@ typedef struct VirtIOFeature {
 size_t end;
 } VirtIOFeature;
 
-size_t virtio_feature_get_config_size(VirtIOFeature *features,
+size_t virtio_feature_get_config_size(const VirtIOFeature *features,
   uint64_t host_features);
 
 typedef struct VirtQueue VirtQueue;
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 9e13cb9e3ad..e02544b2df7 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -2981,7 +2981,7 @@ int virtio_set_features(VirtIODevice *vdev, uint64_t val)
 return ret;
 }
 
-size_t virtio_feature_get_config_size(VirtIOFeature *feature_sizes,
+size_t virtio_feature_get_config_size(const VirtIOFeature *feature_sizes,
   uint64_t host_features)
 {
 size_t config_size = 0;
-- 
2.26.3