Re: [PATCH v3 00/15] hw/nvme: SR-IOV with Virtualization Enhancements

[Klaus Jensen]

On Dec 21 15:32, Lukasz Maniak wrote:
> This is the version of the patch series that we consider ready for
> staging. We do not intend to work on the v4 unless there are major
> issues.
> 
> Changes since v2:
> - The documentation mentions that SR-IOV support is still an
>   experimental feature.
> - The default value activates properly when sriov_max_v{i,q}_per_vf == 0.
> - Secondary Controller List (CNS 15h) handles the CDW10.CNTID field.
> - Virtual Function Number ("VFN") in Secondary Controller Entry is not
>   cleared to zero as the controller goes offline.
> - Removed no longer used helper pcie_sriov_vf_number_total.
> - Reset other than Controller Reset is necessary to activate (or
>   deactivate) flexible resources.
> - The v{i,q}rfap fields in Primary Controller Capabilities store the
>   currently active number of bound resources, not the number active
>   after reset.
> - Secondary controller cannot be set online unless the corresponding VF
>   is enabled (sriov_numvfs set to at least the secondary controller's VF
>   number)
> 
> The list of opens and known gaps remains the same as for v2:
> https://lists.gnu.org/archive/html/qemu-block/2021-11/msg00423.html
> 

hw/nvme parts look fine.

I expect some changes in response to Michaels comments before we
coordinate merging this?


signature.asc
Description: PGP signature

[PATCH v3 00/15] hw/nvme: SR-IOV with Virtualization Enhancements

[Lukasz Maniak]

This is the version of the patch series that we consider ready for
staging. We do not intend to work on the v4 unless there are major
issues.

Changes since v2:
- The documentation mentions that SR-IOV support is still an
  experimental feature.
- The default value activates properly when sriov_max_v{i,q}_per_vf == 0.
- Secondary Controller List (CNS 15h) handles the CDW10.CNTID field.
- Virtual Function Number ("VFN") in Secondary Controller Entry is not
  cleared to zero as the controller goes offline.
- Removed no longer used helper pcie_sriov_vf_number_total.
- Reset other than Controller Reset is necessary to activate (or
  deactivate) flexible resources.
- The v{i,q}rfap fields in Primary Controller Capabilities store the
  currently active number of bound resources, not the number active
  after reset.
- Secondary controller cannot be set online unless the corresponding VF
  is enabled (sriov_numvfs set to at least the secondary controller's VF
  number)

The list of opens and known gaps remains the same as for v2:
https://lists.gnu.org/archive/html/qemu-block/2021-11/msg00423.html

Knut Omang (2):
  pcie: Add support for Single Root I/O Virtualization (SR/IOV)
  pcie: Add some SR/IOV API documentation in docs/pcie_sriov.txt

Lukasz Maniak (4):
  hw/nvme: Add support for SR-IOV
  hw/nvme: Add support for Primary Controller Capabilities
  hw/nvme: Add support for Secondary Controller List
  docs: Add documentation for SR-IOV and Virtualization Enhancements

Łukasz Gieryk (9):
  pcie: Add a helper to the SR/IOV API
  pcie: Add 1.2 version token for the Power Management Capability
  hw/nvme: Implement the Function Level Reset
  hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime
  hw/nvme: Remove reg_size variable and update BAR0 size calculation
  hw/nvme: Calculate BAR attributes in a function
  hw/nvme: Initialize capability structures for primary/secondary
controllers
  hw/nvme: Add support for the Virtualization Management command
  hw/nvme: Update the initalization place for the AER queue

 docs/pcie_sriov.txt  | 115 ++
 docs/system/devices/nvme.rst |  36 ++
 hw/nvme/ctrl.c   | 665 ---
 hw/nvme/ns.c |   2 +-
 hw/nvme/nvme.h   |  55 ++-
 hw/nvme/subsys.c |  75 +++-
 hw/nvme/trace-events |   6 +
 hw/pci/meson.build   |   1 +
 hw/pci/pci.c |  97 +++--
 hw/pci/pcie.c|   5 +
 hw/pci/pcie_sriov.c  | 295 
 hw/pci/trace-events  |   5 +
 include/block/nvme.h |  65 
 include/hw/pci/pci.h |  12 +-
 include/hw/pci/pci_ids.h |   1 +
 include/hw/pci/pci_regs.h|   1 +
 include/hw/pci/pcie.h|   6 +
 include/hw/pci/pcie_sriov.h  |  72 
 include/qemu/typedefs.h  |   2 +
 19 files changed, 1435 insertions(+), 81 deletions(-)
 create mode 100644 docs/pcie_sriov.txt
 create mode 100644 hw/pci/pcie_sriov.c
 create mode 100644 include/hw/pci/pcie_sriov.h

-- 
2.25.1