Andrey Shinkevich via writes:
> The function name monitor_qmp_bh_dispatcher() has been changed to
> monitor_qmp_dispatcher_co() since the commit 9ce44e2c. Let's amend the
> comments.
>
> Signed-off-by: Andrey Shinkevich
> ---
> monitor/qmp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/monitor/qmp.c b/monitor/qmp.c
> index b42f8c6..7169366 100644
> --- a/monitor/qmp.c
> +++ b/monitor/qmp.c
> @@ -80,7 +80,7 @@ static void monitor_qmp_cleanup_queue_and_resume(MonitorQMP
> *mon)
> qemu_mutex_lock(&mon->qmp_queue_lock);
>
> /*
> - * Same condition as in monitor_qmp_bh_dispatcher(), but before
> + * Same condition as in monitor_qmp_dispatcher_co(), but before
> * removing an element from the queue (hence no `- 1`).
> * Also, the queue should not be empty either, otherwise the
> * monitor hasn't been suspended yet (or was already resumed).
> @@ -343,7 +343,7 @@ static void handle_qmp_command(void *opaque, QObject
> *req, Error *err)
>
> /*
> * Suspend the monitor when we can't queue more requests after
> - * this one. Dequeuing in monitor_qmp_bh_dispatcher() or
> + * this one. Dequeuing in monitor_qmp_dispatcher_co() or
> * monitor_qmp_cleanup_queue_and_resume() will resume it.
> * Note that when OOB is disabled, we queue at most one command,
> * for backward compatibility.
The same change has since made it to master as commit 395a95080a "qmp:
Fix up comments after commit 9ce44e2ce2". I should have picked your
patch instead, but I wasn't aware of it then, because I had put your
series in my review queue without looking closely.
It's been stuck in my queue for way too long. Reviewing non-trivial
monitor patches is slow and exhausting work for me, and other,
non-monitor patches have kept crowding out your work. My apologies!
