Re: [PULL 0/9] Ide patches
On Thu, 1 Oct 2020 at 18:46, John Snow wrote: > > The following changes since commit 37a712a0f969ca2df7f01182409a6c4825cebfb5: > > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' > into staging (2020-10-01 12:23:19 +0100) > > are available in the Git repository at: > > https://gitlab.com/jsnow/qemu.git tags/ide-pull-request > > for you to fetch changes up to 55adb3c45620c31f29978f209e2a44a08d34e2da: > > ide: cancel pending callbacks on SRST (2020-10-01 13:04:16 -0400) > > > Pull request > > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2 for any user-visible changes. -- PMM
[PULL 0/9] Ide patches
The following changes since commit 37a712a0f969ca2df7f01182409a6c4825cebfb5: Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2020-10-01 12:23:19 +0100) are available in the Git repository at: https://gitlab.com/jsnow/qemu.git tags/ide-pull-request for you to fetch changes up to 55adb3c45620c31f29978f209e2a44a08d34e2da: ide: cancel pending callbacks on SRST (2020-10-01 13:04:16 -0400) Pull request John Snow (8): MAINTAINERS: Update my git address ide: rename cmd_write to ctrl_write ide: don't tamper with the device register ide: model HOB correctly ide: reorder set/get sector functions ide: remove magic constants from the device register ide: clear interrupt on command write ide: cancel pending callbacks on SRST Philippe Mathieu-Daudé (1): hw/ide/ahci: Do not dma_memory_unmap(NULL) include/hw/ide/internal.h | 21 +-- hw/ide/ahci.c | 2 +- hw/ide/core.c | 124 +++--- hw/ide/ioport.c | 2 +- hw/ide/macio.c| 2 +- hw/ide/mmio.c | 8 +-- hw/ide/pci.c | 12 ++-- MAINTAINERS | 6 +- hw/ide/trace-events | 2 +- 9 files changed, 110 insertions(+), 69 deletions(-) -- 2.26.2
Re: [PULL 0/9] Ide patches
On 10/31/19 11:02 AM, Peter Maydell wrote: > On Thu, 31 Oct 2019 at 10:59, John Snow wrote: >> >> The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: >> >> Merge remote-tracking branch >> 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 >> 14:10:32 +) >> >> are available in the Git repository at: >> >> https://github.com/jnsnow/qemu.git tags/ide-pull-request >> >> for you to fetch changes up to c35564caf20e8d3431786dddf0fa513daa7d7f3c: >> >> hd-geo-test: Add tests for lchs override (2019-10-31 06:11:34 -0400) >> >> >> Pull request >> > > Hi -- this passed the merge tests but it looks like you forgot > to add your signed-off by line as the submaintainer to Sam's > patches. Could you fix that up and resend, please? > > thanks > -- PMM > Haha. I re-applied them to grab Phil's SOBs and that dropped mine. OK, re-spinning. (Note to self: add a check to git-publish --pull that looks for my SOB.)
Re: [PULL 0/9] Ide patches
On Thu, 31 Oct 2019 at 10:59, John Snow wrote: > > The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 > 14:10:32 +) > > are available in the Git repository at: > > https://github.com/jnsnow/qemu.git tags/ide-pull-request > > for you to fetch changes up to c35564caf20e8d3431786dddf0fa513daa7d7f3c: > > hd-geo-test: Add tests for lchs override (2019-10-31 06:11:34 -0400) > > > Pull request > Hi -- this passed the merge tests but it looks like you forgot to add your signed-off by line as the submaintainer to Sam's patches. Could you fix that up and resend, please? thanks -- PMM
Re: [libvirt] [PULL 0/9] Ide patches
Patchew URL: https://patchew.org/QEMU/20191031105904.12194-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [libvirt] [PULL 0/9] Ide patches Type: series Message-id: 20191031105904.12194-1-js...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' d278ccf hd-geo-test: Add tests for lchs override 28807d7 bootdevice: FW_CFG interface for LCHS values 11f27f1 bootdevice: Refactor get_boot_devices_list e032fef bootdevice: Gather LCHS from all relevant devices 74eb334 scsi: Propagate unrealize() callback to scsi-hd e211495 bootdevice: Add interface to gather LCHS a683977 block: Support providing LCHS from user 071ac63 block: Refactor macros - fix tabbing 90e6789 IDE: deprecate ide-drive === OUTPUT BEGIN === 1/9 Checking commit 90e67898e3b9 (IDE: deprecate ide-drive) 2/9 Checking commit 071ac63ed092 (block: Refactor macros - fix tabbing) ERROR: Macros with complex values should be enclosed in parenthesis #58: FILE: include/hw/block/block.h:65: +#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \ +DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \ +DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0),\ DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0) total: 1 errors, 0 warnings, 37 lines checked Patch 2/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/9 Checking commit a68397755180 (block: Support providing LCHS from user) 4/9 Checking commit e21149531919 (bootdevice: Add interface to gather LCHS) 5/9 Checking commit 74eb33489f71 (scsi: Propagate unrealize() callback to scsi-hd) 6/9 Checking commit e032fefe3098 (bootdevice: Gather LCHS from all relevant devices) 7/9 Checking commit 11f27f1f9e10 (bootdevice: Refactor get_boot_devices_list) 8/9 Checking commit 28807d78bb01 (bootdevice: FW_CFG interface for LCHS values) 9/9 Checking commit d278ccfd1965 (hd-geo-test: Add tests for lchs override) WARNING: Block comments use a leading /* on a separate line #607: FILE: tests/hd-geo-test.c:965: + "skipping hd-geo/override/* tests"); total: 0 errors, 1 warnings, 578 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20191031105904.12194-1-js...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
[PULL 0/9] Ide patches
The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: Merge remote-tracking branch 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 14:10:32 +) are available in the Git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you to fetch changes up to c35564caf20e8d3431786dddf0fa513daa7d7f3c: hd-geo-test: Add tests for lchs override (2019-10-31 06:11:34 -0400) Pull request John Snow (1): IDE: deprecate ide-drive Sam Eiderman (8): block: Refactor macros - fix tabbing block: Support providing LCHS from user bootdevice: Add interface to gather LCHS scsi: Propagate unrealize() callback to scsi-hd bootdevice: Gather LCHS from all relevant devices bootdevice: Refactor get_boot_devices_list bootdevice: FW_CFG interface for LCHS values hd-geo-test: Add tests for lchs override qemu-deprecated.texi | 5 + include/hw/block/block.h | 22 +- include/hw/scsi/scsi.h| 1 + include/sysemu/sysemu.h | 4 + bootdevice.c | 147 +++-- hw/block/virtio-blk.c | 6 + hw/ide/qdev.c | 10 +- hw/nvram/fw_cfg.c | 14 +- hw/scsi/scsi-bus.c| 16 + hw/scsi/scsi-disk.c | 12 + tests/hd-geo-test.c | 551 ++ tests/Makefile.include| 2 +- tests/qemu-iotests/051.pc.out | 6 +- 13 files changed, 753 insertions(+), 43 deletions(-) -- 2.21.0