Re: [PULL 00/12] Block patches
Am 16.07.2020 um 14:40 hat Peter Maydell geschrieben: > On Thu, 9 Jul 2020 at 16:02, Kevin Wolf wrote: > > > > We can "fix" it for probably all realistic cases by lowering the speed > > of the block job significantly. It's still not fully fixed for all > > theoretical cases, but the pattern of starting a block job that is > > throttled to a low speed so it will keep running for the next part of > > the test is very common. > > > > Kevin > > > > diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030 > > index 256b2bfbc6..31c028306b 100755 > > --- a/tests/qemu-iotests/030 > > +++ b/tests/qemu-iotests/030 > > @@ -243,7 +243,7 @@ class TestParallelOps(iotests.QMPTestCase): > > node_name = 'node%d' % i > > job_id = 'stream-%s' % node_name > > pending_jobs.append(job_id) > > -result = self.vm.qmp('block-stream', device=node_name, > > job_id=job_id, base=self.imgs[i-2], speed=512*1024) > > +result = self.vm.qmp('block-stream', device=node_name, > > job_id=job_id, base=self.imgs[i-2], speed=1024) > > self.assert_qmp(result, 'return', {}) > > > > for job in pending_jobs: > > Any chance we could get this fix into the tree? I've just > had an unrelated mergebuild test run hit this iotest 030 > failure again... Sure. I sent a proper patch so I can include it in my next pull request (probably tomorrow). Kevin
Re: [PULL 00/12] Block patches
On Thu, 9 Jul 2020 at 16:02, Kevin Wolf wrote: > > We can "fix" it for probably all realistic cases by lowering the speed > of the block job significantly. It's still not fully fixed for all > theoretical cases, but the pattern of starting a block job that is > throttled to a low speed so it will keep running for the next part of > the test is very common. > > Kevin > > diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030 > index 256b2bfbc6..31c028306b 100755 > --- a/tests/qemu-iotests/030 > +++ b/tests/qemu-iotests/030 > @@ -243,7 +243,7 @@ class TestParallelOps(iotests.QMPTestCase): > node_name = 'node%d' % i > job_id = 'stream-%s' % node_name > pending_jobs.append(job_id) > -result = self.vm.qmp('block-stream', device=node_name, > job_id=job_id, base=self.imgs[i-2], speed=512*1024) > +result = self.vm.qmp('block-stream', device=node_name, > job_id=job_id, base=self.imgs[i-2], speed=1024) > self.assert_qmp(result, 'return', {}) > > for job in pending_jobs: Any chance we could get this fix into the tree? I've just had an unrelated mergebuild test run hit this iotest 030 failure again... -- PMM
Re: [PULL 00/12] Block patches
Am 09.07.2020 um 20:41 hat Eduardo Habkost geschrieben: > On Thu, Jul 09, 2020 at 05:02:06PM +0200, Kevin Wolf wrote: > > Am 08.07.2020 um 00:05 hat Eduardo Habkost geschrieben: > > > On Tue, Jul 07, 2020 at 05:28:21PM +0200, Philippe Mathieu-Daudé wrote: > > > > On 6/26/20 12:25 PM, Stefan Hajnoczi wrote: > > > > > On Thu, Jun 25, 2020 at 02:31:14PM +0100, Peter Maydell wrote: > > > > >> On Wed, 24 Jun 2020 at 11:02, Stefan Hajnoczi > > > > >> wrote: > > > > >>> > > > > >>> The following changes since commit > > > > >>> 171199f56f5f9bdf1e5d670d09ef1351d8f01bae: > > > > >>> > > > > >>> Merge remote-tracking branch > > > > >>> 'remotes/alistair/tags/pull-riscv-to-apply-20200619-3' into staging > > > > >>> (2020-06-22 14:45:25 +0100) > > > > >>> > > > > >>> are available in the Git repository at: > > > > >>> > > > > >>> https://github.com/stefanha/qemu.git tags/block-pull-request > > > > >>> > > > > >>> for you to fetch changes up to > > > > >>> 7838c67f22a81fcf669785cd6c0876438422071a: > > > > >>> > > > > >>> block/nvme: support nested aio_poll() (2020-06-23 15:46:08 +0100) > > > > >>> > > > > >>> > > > > >>> Pull request > > > > >>> > > > > >>> > > > > >> > > > > >> Failure on iotest 030, x86-64 Linux: > > > > >> > > > > >> TESTiotest-qcow2: 030 [fail] > > > > >> QEMU -- > > > > >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" > > > > >> -nodefaults -display none -accel qtest > > > > >> QEMU_IMG -- > > > > >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-img" > > > > >> QEMU_IO -- > > > > >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-io" > > > > >> --cache writeback --aio threads -f qcow2 > > > > >> QEMU_NBD -- > > > > >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-nbd" > > > > >> IMGFMT-- qcow2 (compat=1.1) > > > > >> IMGPROTO -- file > > > > >> PLATFORM -- Linux/x86_64 e104462 4.15.0-76-generic > > > > >> TEST_DIR -- > > > > >> /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/scratch > > > > >> SOCK_DIR -- /tmp/tmp.8tgdDjoZcO > > > > >> SOCKET_SCM_HELPER -- > > > > >> /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotest/socket_scm_helper > > > > >> > > > > >> --- /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/030.out > > > > >> 2019-07-15 17:18:35.251364738 +0100 > > > > >> +++ > > > > >> /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/030.out.bad > > > > >> 2020-06-25 14:04:28.500534007 +0100 > > > > >> @@ -1,5 +1,17 @@ > > > > >> -... > > > > >> +.F. > > > > >> +== > > > > >> +FAIL: test_stream_parallel (__main__.TestParallelOps) > > > > >> +-- > > > > >> +Traceback (most recent call last): > > > > >> + File "030", line 246, in test_stream_parallel > > > > >> +self.assert_qmp(result, 'return', {}) > > > > >> + File > > > > >> "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", > > > > >> line 848, in assert_qmp > > > > >> +result = self.dictpath(d, path) > > > > >> + File > > > > >> "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", > > > > >> line 822, in dictpath > > > > >> +self.fail(f'failed path traversal for "{path}" in "{d}"') > > > > >> +AssertionError: failed path traversal for "return" in "{'error': > > > > >> {'class': 'DeviceNotActive', 'desc': "Block job 'stream-node8' not > > > > >> found"}}" > > > > >> + > > > > >> > > > > >> -- > > > > >> Ran 27 tests > > > > >> > > > > >> -OK > > > > >> +FAILED (failures=1) > > > > > > > > > > Strange, I can't reproduce this failure on my pull request branch or > > > > > on > > > > > qemu.git/master. > > > > > > > > > > Is this failure deterministic? Are you sure it is introduced by this > > > > > pull request? > > > > > > > > Probably not introduced by this pullreq, but I also hit it on FreeBSD: > > > > https://cirrus-ci.com/task/4620718312783872?command=main#L5803 > > > > > > > > TESTiotest-qcow2: 030 [fail] > > > > QEMU -- > > > > "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64" > > > > -nodefaults -display none -machine virt -accel qtest > > > > QEMU_IMG -- > > > > "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-img" > > > > QEMU_IO -- > > > > "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-io" --cache > > > > writeback --aio threads -f qcow2 > > > > QEMU_NBD -- > > > > "/tmp/cirrus-ci-build/build/tes
Re: [PULL 00/12] Block patches
On Thu, Jul 09, 2020 at 05:02:06PM +0200, Kevin Wolf wrote: > Am 08.07.2020 um 00:05 hat Eduardo Habkost geschrieben: > > On Tue, Jul 07, 2020 at 05:28:21PM +0200, Philippe Mathieu-Daudé wrote: > > > On 6/26/20 12:25 PM, Stefan Hajnoczi wrote: > > > > On Thu, Jun 25, 2020 at 02:31:14PM +0100, Peter Maydell wrote: > > > >> On Wed, 24 Jun 2020 at 11:02, Stefan Hajnoczi > > > >> wrote: > > > >>> > > > >>> The following changes since commit > > > >>> 171199f56f5f9bdf1e5d670d09ef1351d8f01bae: > > > >>> > > > >>> Merge remote-tracking branch > > > >>> 'remotes/alistair/tags/pull-riscv-to-apply-20200619-3' into staging > > > >>> (2020-06-22 14:45:25 +0100) > > > >>> > > > >>> are available in the Git repository at: > > > >>> > > > >>> https://github.com/stefanha/qemu.git tags/block-pull-request > > > >>> > > > >>> for you to fetch changes up to > > > >>> 7838c67f22a81fcf669785cd6c0876438422071a: > > > >>> > > > >>> block/nvme: support nested aio_poll() (2020-06-23 15:46:08 +0100) > > > >>> > > > >>> > > > >>> Pull request > > > >>> > > > >>> > > > >> > > > >> Failure on iotest 030, x86-64 Linux: > > > >> > > > >> TESTiotest-qcow2: 030 [fail] > > > >> QEMU -- > > > >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" > > > >> -nodefaults -display none -accel qtest > > > >> QEMU_IMG -- > > > >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-img" > > > >> QEMU_IO -- > > > >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-io" > > > >> --cache writeback --aio threads -f qcow2 > > > >> QEMU_NBD -- > > > >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-nbd" > > > >> IMGFMT-- qcow2 (compat=1.1) > > > >> IMGPROTO -- file > > > >> PLATFORM -- Linux/x86_64 e104462 4.15.0-76-generic > > > >> TEST_DIR -- > > > >> /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/scratch > > > >> SOCK_DIR -- /tmp/tmp.8tgdDjoZcO > > > >> SOCKET_SCM_HELPER -- > > > >> /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotest/socket_scm_helper > > > >> > > > >> --- /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/030.out > > > >> 2019-07-15 17:18:35.251364738 +0100 > > > >> +++ > > > >> /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/030.out.bad > > > >> 2020-06-25 14:04:28.500534007 +0100 > > > >> @@ -1,5 +1,17 @@ > > > >> -... > > > >> +.F. > > > >> +== > > > >> +FAIL: test_stream_parallel (__main__.TestParallelOps) > > > >> +-- > > > >> +Traceback (most recent call last): > > > >> + File "030", line 246, in test_stream_parallel > > > >> +self.assert_qmp(result, 'return', {}) > > > >> + File > > > >> "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", > > > >> line 848, in assert_qmp > > > >> +result = self.dictpath(d, path) > > > >> + File > > > >> "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", > > > >> line 822, in dictpath > > > >> +self.fail(f'failed path traversal for "{path}" in "{d}"') > > > >> +AssertionError: failed path traversal for "return" in "{'error': > > > >> {'class': 'DeviceNotActive', 'desc': "Block job 'stream-node8' not > > > >> found"}}" > > > >> + > > > >> -- > > > >> Ran 27 tests > > > >> > > > >> -OK > > > >> +FAILED (failures=1) > > > > > > > > Strange, I can't reproduce this failure on my pull request branch or on > > > > qemu.git/master. > > > > > > > > Is this failure deterministic? Are you sure it is introduced by this > > > > pull request? > > > > > > Probably not introduced by this pullreq, but I also hit it on FreeBSD: > > > https://cirrus-ci.com/task/4620718312783872?command=main#L5803 > > > > > > TESTiotest-qcow2: 030 [fail] > > > QEMU -- > > > "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64" > > > -nodefaults -display none -machine virt -accel qtest > > > QEMU_IMG -- > > > "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-img" > > > QEMU_IO -- > > > "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-io" --cache > > > writeback --aio threads -f qcow2 > > > QEMU_NBD -- > > > "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-nbd" > > > IMGFMT-- qcow2 (compat=1.1) > > > IMGPROTO -- file > > > PLATFORM -- FreeBSD/amd64 cirrus-task-4620718312783872 12.1-RELEASE > > > TEST_DIR -- /tmp/cirrus-ci-build/build/tests/qemu-iotests/scratch > > > SOCK_DIR -- /tmp
Re: [PULL 00/12] Block patches
Am 08.07.2020 um 00:05 hat Eduardo Habkost geschrieben: > On Tue, Jul 07, 2020 at 05:28:21PM +0200, Philippe Mathieu-Daudé wrote: > > On 6/26/20 12:25 PM, Stefan Hajnoczi wrote: > > > On Thu, Jun 25, 2020 at 02:31:14PM +0100, Peter Maydell wrote: > > >> On Wed, 24 Jun 2020 at 11:02, Stefan Hajnoczi > > >> wrote: > > >>> > > >>> The following changes since commit > > >>> 171199f56f5f9bdf1e5d670d09ef1351d8f01bae: > > >>> > > >>> Merge remote-tracking branch > > >>> 'remotes/alistair/tags/pull-riscv-to-apply-20200619-3' into staging > > >>> (2020-06-22 14:45:25 +0100) > > >>> > > >>> are available in the Git repository at: > > >>> > > >>> https://github.com/stefanha/qemu.git tags/block-pull-request > > >>> > > >>> for you to fetch changes up to 7838c67f22a81fcf669785cd6c0876438422071a: > > >>> > > >>> block/nvme: support nested aio_poll() (2020-06-23 15:46:08 +0100) > > >>> > > >>> > > >>> Pull request > > >>> > > >>> > > >> > > >> Failure on iotest 030, x86-64 Linux: > > >> > > >> TESTiotest-qcow2: 030 [fail] > > >> QEMU -- > > >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" > > >> -nodefaults -display none -accel qtest > > >> QEMU_IMG -- > > >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-img" > > >> QEMU_IO -- > > >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-io" > > >> --cache writeback --aio threads -f qcow2 > > >> QEMU_NBD -- > > >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-nbd" > > >> IMGFMT-- qcow2 (compat=1.1) > > >> IMGPROTO -- file > > >> PLATFORM -- Linux/x86_64 e104462 4.15.0-76-generic > > >> TEST_DIR -- > > >> /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/scratch > > >> SOCK_DIR -- /tmp/tmp.8tgdDjoZcO > > >> SOCKET_SCM_HELPER -- > > >> /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotest/socket_scm_helper > > >> > > >> --- /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/030.out > > >> 2019-07-15 17:18:35.251364738 +0100 > > >> +++ > > >> /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/030.out.bad > > >> 2020-06-25 14:04:28.500534007 +0100 > > >> @@ -1,5 +1,17 @@ > > >> -... > > >> +.F. > > >> +== > > >> +FAIL: test_stream_parallel (__main__.TestParallelOps) > > >> +-- > > >> +Traceback (most recent call last): > > >> + File "030", line 246, in test_stream_parallel > > >> +self.assert_qmp(result, 'return', {}) > > >> + File > > >> "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", > > >> line 848, in assert_qmp > > >> +result = self.dictpath(d, path) > > >> + File > > >> "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", > > >> line 822, in dictpath > > >> +self.fail(f'failed path traversal for "{path}" in "{d}"') > > >> +AssertionError: failed path traversal for "return" in "{'error': > > >> {'class': 'DeviceNotActive', 'desc': "Block job 'stream-node8' not > > >> found"}}" > > >> + > > >> -- > > >> Ran 27 tests > > >> > > >> -OK > > >> +FAILED (failures=1) > > > > > > Strange, I can't reproduce this failure on my pull request branch or on > > > qemu.git/master. > > > > > > Is this failure deterministic? Are you sure it is introduced by this > > > pull request? > > > > Probably not introduced by this pullreq, but I also hit it on FreeBSD: > > https://cirrus-ci.com/task/4620718312783872?command=main#L5803 > > > > TESTiotest-qcow2: 030 [fail] > > QEMU -- > > "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64" > > -nodefaults -display none -machine virt -accel qtest > > QEMU_IMG -- > > "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-img" > > QEMU_IO -- > > "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-io" --cache > > writeback --aio threads -f qcow2 > > QEMU_NBD -- > > "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-nbd" > > IMGFMT-- qcow2 (compat=1.1) > > IMGPROTO -- file > > PLATFORM -- FreeBSD/amd64 cirrus-task-4620718312783872 12.1-RELEASE > > TEST_DIR -- /tmp/cirrus-ci-build/build/tests/qemu-iotests/scratch > > SOCK_DIR -- /tmp/tmp.aZ5pxFLF > > SOCKET_SCM_HELPER -- > > --- /tmp/cirrus-ci-build/tests/qemu-iotests/030.out 2020-07-07 > > 14:48:48.123804000 + > > +++ /tmp/cirrus-ci-build/build/tests/qemu-iotests/030.out.bad > > 2020-07-07 > > 15:05:07.863685000 + > > @@ -1,5 +1,17 @@ > > -.
Re: [PULL 00/12] Block patches
On Tue, Jul 07, 2020 at 05:28:21PM +0200, Philippe Mathieu-Daudé wrote: > On 6/26/20 12:25 PM, Stefan Hajnoczi wrote: > > On Thu, Jun 25, 2020 at 02:31:14PM +0100, Peter Maydell wrote: > >> On Wed, 24 Jun 2020 at 11:02, Stefan Hajnoczi wrote: > >>> > >>> The following changes since commit > >>> 171199f56f5f9bdf1e5d670d09ef1351d8f01bae: > >>> > >>> Merge remote-tracking branch > >>> 'remotes/alistair/tags/pull-riscv-to-apply-20200619-3' into staging > >>> (2020-06-22 14:45:25 +0100) > >>> > >>> are available in the Git repository at: > >>> > >>> https://github.com/stefanha/qemu.git tags/block-pull-request > >>> > >>> for you to fetch changes up to 7838c67f22a81fcf669785cd6c0876438422071a: > >>> > >>> block/nvme: support nested aio_poll() (2020-06-23 15:46:08 +0100) > >>> > >>> > >>> Pull request > >>> > >>> > >> > >> Failure on iotest 030, x86-64 Linux: > >> > >> TESTiotest-qcow2: 030 [fail] > >> QEMU -- > >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" > >> -nodefaults -display none -accel qtest > >> QEMU_IMG -- > >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-img" > >> QEMU_IO -- > >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-io" > >> --cache writeback --aio threads -f qcow2 > >> QEMU_NBD -- > >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-nbd" > >> IMGFMT-- qcow2 (compat=1.1) > >> IMGPROTO -- file > >> PLATFORM -- Linux/x86_64 e104462 4.15.0-76-generic > >> TEST_DIR -- > >> /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/scratch > >> SOCK_DIR -- /tmp/tmp.8tgdDjoZcO > >> SOCKET_SCM_HELPER -- > >> /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotest/socket_scm_helper > >> > >> --- /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/030.out > >> 2019-07-15 17:18:35.251364738 +0100 > >> +++ > >> /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/030.out.bad > >> 2020-06-25 14:04:28.500534007 +0100 > >> @@ -1,5 +1,17 @@ > >> -... > >> +.F. > >> +== > >> +FAIL: test_stream_parallel (__main__.TestParallelOps) > >> +-- > >> +Traceback (most recent call last): > >> + File "030", line 246, in test_stream_parallel > >> +self.assert_qmp(result, 'return', {}) > >> + File > >> "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", > >> line 848, in assert_qmp > >> +result = self.dictpath(d, path) > >> + File > >> "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", > >> line 822, in dictpath > >> +self.fail(f'failed path traversal for "{path}" in "{d}"') > >> +AssertionError: failed path traversal for "return" in "{'error': > >> {'class': 'DeviceNotActive', 'desc': "Block job 'stream-node8' not > >> found"}}" > >> + > >> -- > >> Ran 27 tests > >> > >> -OK > >> +FAILED (failures=1) > > > > Strange, I can't reproduce this failure on my pull request branch or on > > qemu.git/master. > > > > Is this failure deterministic? Are you sure it is introduced by this > > pull request? > > Probably not introduced by this pullreq, but I also hit it on FreeBSD: > https://cirrus-ci.com/task/4620718312783872?command=main#L5803 > > TESTiotest-qcow2: 030 [fail] > QEMU -- > "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64" > -nodefaults -display none -machine virt -accel qtest > QEMU_IMG -- > "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-img" > QEMU_IO -- > "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-io" --cache > writeback --aio threads -f qcow2 > QEMU_NBD -- > "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-nbd" > IMGFMT-- qcow2 (compat=1.1) > IMGPROTO -- file > PLATFORM -- FreeBSD/amd64 cirrus-task-4620718312783872 12.1-RELEASE > TEST_DIR -- /tmp/cirrus-ci-build/build/tests/qemu-iotests/scratch > SOCK_DIR -- /tmp/tmp.aZ5pxFLF > SOCKET_SCM_HELPER -- > --- /tmp/cirrus-ci-build/tests/qemu-iotests/030.out 2020-07-07 > 14:48:48.123804000 + > +++ /tmp/cirrus-ci-build/build/tests/qemu-iotests/030.out.bad 2020-07-07 > 15:05:07.863685000 + > @@ -1,5 +1,17 @@ > -... > +.F. > +== > +FAIL: test_stream_parallel (__main__.TestParallelOps) > -- > +Traceback (most recent call last)
Re: [PULL 00/12] Block patches
On 6/26/20 12:25 PM, Stefan Hajnoczi wrote: > On Thu, Jun 25, 2020 at 02:31:14PM +0100, Peter Maydell wrote: >> On Wed, 24 Jun 2020 at 11:02, Stefan Hajnoczi wrote: >>> >>> The following changes since commit 171199f56f5f9bdf1e5d670d09ef1351d8f01bae: >>> >>> Merge remote-tracking branch >>> 'remotes/alistair/tags/pull-riscv-to-apply-20200619-3' into staging >>> (2020-06-22 14:45:25 +0100) >>> >>> are available in the Git repository at: >>> >>> https://github.com/stefanha/qemu.git tags/block-pull-request >>> >>> for you to fetch changes up to 7838c67f22a81fcf669785cd6c0876438422071a: >>> >>> block/nvme: support nested aio_poll() (2020-06-23 15:46:08 +0100) >>> >>> >>> Pull request >>> >>> >> >> Failure on iotest 030, x86-64 Linux: >> >> TESTiotest-qcow2: 030 [fail] >> QEMU -- >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" >> -nodefaults -display none -accel qtest >> QEMU_IMG -- >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-img" >> QEMU_IO -- >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-io" >> --cache writeback --aio threads -f qcow2 >> QEMU_NBD -- >> "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-nbd" >> IMGFMT-- qcow2 (compat=1.1) >> IMGPROTO -- file >> PLATFORM -- Linux/x86_64 e104462 4.15.0-76-generic >> TEST_DIR -- >> /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/scratch >> SOCK_DIR -- /tmp/tmp.8tgdDjoZcO >> SOCKET_SCM_HELPER -- >> /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotest/socket_scm_helper >> >> --- /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/030.out >> 2019-07-15 17:18:35.251364738 +0100 >> +++ >> /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/030.out.bad >> 2020-06-25 14:04:28.500534007 +0100 >> @@ -1,5 +1,17 @@ >> -... >> +.F. >> +== >> +FAIL: test_stream_parallel (__main__.TestParallelOps) >> +-- >> +Traceback (most recent call last): >> + File "030", line 246, in test_stream_parallel >> +self.assert_qmp(result, 'return', {}) >> + File >> "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", >> line 848, in assert_qmp >> +result = self.dictpath(d, path) >> + File >> "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", >> line 822, in dictpath >> +self.fail(f'failed path traversal for "{path}" in "{d}"') >> +AssertionError: failed path traversal for "return" in "{'error': >> {'class': 'DeviceNotActive', 'desc': "Block job 'stream-node8' not >> found"}}" >> + >> -- >> Ran 27 tests >> >> -OK >> +FAILED (failures=1) > > Strange, I can't reproduce this failure on my pull request branch or on > qemu.git/master. > > Is this failure deterministic? Are you sure it is introduced by this > pull request? Probably not introduced by this pullreq, but I also hit it on FreeBSD: https://cirrus-ci.com/task/4620718312783872?command=main#L5803 TESTiotest-qcow2: 030 [fail] QEMU -- "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64" -nodefaults -display none -machine virt -accel qtest QEMU_IMG -- "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-img" QEMU_IO -- "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-io" --cache writeback --aio threads -f qcow2 QEMU_NBD -- "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-nbd" IMGFMT-- qcow2 (compat=1.1) IMGPROTO -- file PLATFORM -- FreeBSD/amd64 cirrus-task-4620718312783872 12.1-RELEASE TEST_DIR -- /tmp/cirrus-ci-build/build/tests/qemu-iotests/scratch SOCK_DIR -- /tmp/tmp.aZ5pxFLF SOCKET_SCM_HELPER -- --- /tmp/cirrus-ci-build/tests/qemu-iotests/030.out 2020-07-07 14:48:48.123804000 + +++ /tmp/cirrus-ci-build/build/tests/qemu-iotests/030.out.bad 2020-07-07 15:05:07.863685000 + @@ -1,5 +1,17 @@ -... +.F. +== +FAIL: test_stream_parallel (__main__.TestParallelOps) -- +Traceback (most recent call last): + File "030", line 246, in test_stream_parallel +self.assert_qmp(result, 'return', {}) + File "/tmp/cirrus-ci-build/tests/qemu-iotests/iotests.py", line 848, in assert_qmp +result = self.dictpath(d, path) + File "/tmp/cirrus-ci-build/tests/qemu-iotests/iotests.py", line 822, in dictpath +
Re: [PULL 00/12] Block patches
On Fri, 26 Jun 2020 at 14:01, Stefan Hajnoczi wrote: > > On Fri, Jun 26, 2020 at 11:49 AM Peter Maydell > wrote: > > > > On Fri, 26 Jun 2020 at 11:25, Stefan Hajnoczi wrote: > > > > > > On Thu, Jun 25, 2020 at 02:31:14PM +0100, Peter Maydell wrote: > > > > On Wed, 24 Jun 2020 at 11:02, Stefan Hajnoczi > > > > wrote: > > > > > > > > > > The following changes since commit > > > > > 171199f56f5f9bdf1e5d670d09ef1351d8f01bae: > > > > > > > > > > Merge remote-tracking branch > > > > > 'remotes/alistair/tags/pull-riscv-to-apply-20200619-3' into staging > > > > > (2020-06-22 14:45:25 +0100) > > > > > > > > > > are available in the Git repository at: > > > > > > > > > > https://github.com/stefanha/qemu.git tags/block-pull-request > > > > > > > > > > for you to fetch changes up to > > > > > 7838c67f22a81fcf669785cd6c0876438422071a: > > > > > > > > > > block/nvme: support nested aio_poll() (2020-06-23 15:46:08 +0100) > > > > > > > > > > > > > > > Pull request > > > > > > > > > > > > > > > > > > Failure on iotest 030, x86-64 Linux: > > > > > > > > TESTiotest-qcow2: 030 [fail] > > > > QEMU -- > > > > "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" > > > > -nodefaults -display none -accel qtest > > > > QEMU_IMG -- > > > > "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-img" > > > > QEMU_IO -- > > > > "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-io" > > > > --cache writeback --aio threads -f qcow2 > > > > QEMU_NBD -- > > > > "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-nbd" > > > > IMGFMT-- qcow2 (compat=1.1) > > > > IMGPROTO -- file > > > > PLATFORM -- Linux/x86_64 e104462 4.15.0-76-generic > > > > TEST_DIR -- > > > > /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/scratch > > > > SOCK_DIR -- /tmp/tmp.8tgdDjoZcO > > > > SOCKET_SCM_HELPER -- > > > > /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotest/socket_scm_helper > > > > > > > > --- /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/030.out > > > > 2019-07-15 17:18:35.251364738 +0100 > > > > +++ > > > > /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/030.out.bad > > > > 2020-06-25 14:04:28.500534007 +0100 > > > > @@ -1,5 +1,17 @@ > > > > -... > > > > +.F. > > > > +== > > > > +FAIL: test_stream_parallel (__main__.TestParallelOps) > > > > +-- > > > > +Traceback (most recent call last): > > > > + File "030", line 246, in test_stream_parallel > > > > +self.assert_qmp(result, 'return', {}) > > > > + File > > > > "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", > > > > line 848, in assert_qmp > > > > +result = self.dictpath(d, path) > > > > + File > > > > "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", > > > > line 822, in dictpath > > > > +self.fail(f'failed path traversal for "{path}" in "{d}"') > > > > +AssertionError: failed path traversal for "return" in "{'error': > > > > {'class': 'DeviceNotActive', 'desc': "Block job 'stream-node8' not > > > > found"}}" > > > > + > > > > -- > > > > Ran 27 tests > > > > > > > > -OK > > > > +FAILED (failures=1) > > > > > > Strange, I can't reproduce this failure on my pull request branch or on > > > qemu.git/master. > > > > > > Is this failure deterministic? Are you sure it is introduced by this > > > pull request? > > > > It might be a random one that you got hit by; I just bounced > > the request because it's a block pullreq rather than anything > > obviously unrelated (and because I hadn't seen it before). I > > can have another go at merging this if you don't think it looks > > like it would be something caused by any of the patches in > > this series. > > Yes, please try the test again. None of the patches should affect > qemu-iotests 030 Seemed to work this time. Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1 for any user-visible changes. -- PMM
Re: [PULL 00/12] Block patches
On Fri, Jun 26, 2020 at 11:49 AM Peter Maydell wrote: > > On Fri, 26 Jun 2020 at 11:25, Stefan Hajnoczi wrote: > > > > On Thu, Jun 25, 2020 at 02:31:14PM +0100, Peter Maydell wrote: > > > On Wed, 24 Jun 2020 at 11:02, Stefan Hajnoczi wrote: > > > > > > > > The following changes since commit > > > > 171199f56f5f9bdf1e5d670d09ef1351d8f01bae: > > > > > > > > Merge remote-tracking branch > > > > 'remotes/alistair/tags/pull-riscv-to-apply-20200619-3' into staging > > > > (2020-06-22 14:45:25 +0100) > > > > > > > > are available in the Git repository at: > > > > > > > > https://github.com/stefanha/qemu.git tags/block-pull-request > > > > > > > > for you to fetch changes up to 7838c67f22a81fcf669785cd6c0876438422071a: > > > > > > > > block/nvme: support nested aio_poll() (2020-06-23 15:46:08 +0100) > > > > > > > > > > > > Pull request > > > > > > > > > > > > > > Failure on iotest 030, x86-64 Linux: > > > > > > TESTiotest-qcow2: 030 [fail] > > > QEMU -- > > > "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" > > > -nodefaults -display none -accel qtest > > > QEMU_IMG -- > > > "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-img" > > > QEMU_IO -- > > > "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-io" > > > --cache writeback --aio threads -f qcow2 > > > QEMU_NBD -- > > > "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-nbd" > > > IMGFMT-- qcow2 (compat=1.1) > > > IMGPROTO -- file > > > PLATFORM -- Linux/x86_64 e104462 4.15.0-76-generic > > > TEST_DIR -- > > > /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/scratch > > > SOCK_DIR -- /tmp/tmp.8tgdDjoZcO > > > SOCKET_SCM_HELPER -- > > > /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotest/socket_scm_helper > > > > > > --- /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/030.out > > > 2019-07-15 17:18:35.251364738 +0100 > > > +++ > > > /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/030.out.bad > > > 2020-06-25 14:04:28.500534007 +0100 > > > @@ -1,5 +1,17 @@ > > > -... > > > +.F. > > > +== > > > +FAIL: test_stream_parallel (__main__.TestParallelOps) > > > +-- > > > +Traceback (most recent call last): > > > + File "030", line 246, in test_stream_parallel > > > +self.assert_qmp(result, 'return', {}) > > > + File > > > "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", > > > line 848, in assert_qmp > > > +result = self.dictpath(d, path) > > > + File > > > "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", > > > line 822, in dictpath > > > +self.fail(f'failed path traversal for "{path}" in "{d}"') > > > +AssertionError: failed path traversal for "return" in "{'error': > > > {'class': 'DeviceNotActive', 'desc': "Block job 'stream-node8' not > > > found"}}" > > > + > > > -- > > > Ran 27 tests > > > > > > -OK > > > +FAILED (failures=1) > > > > Strange, I can't reproduce this failure on my pull request branch or on > > qemu.git/master. > > > > Is this failure deterministic? Are you sure it is introduced by this > > pull request? > > It might be a random one that you got hit by; I just bounced > the request because it's a block pullreq rather than anything > obviously unrelated (and because I hadn't seen it before). I > can have another go at merging this if you don't think it looks > like it would be something caused by any of the patches in > this series. Yes, please try the test again. None of the patches should affect qemu-iotests 030. Stefan
Re: [PULL 00/12] Block patches
On Fri, 26 Jun 2020 at 11:25, Stefan Hajnoczi wrote: > > On Thu, Jun 25, 2020 at 02:31:14PM +0100, Peter Maydell wrote: > > On Wed, 24 Jun 2020 at 11:02, Stefan Hajnoczi wrote: > > > > > > The following changes since commit > > > 171199f56f5f9bdf1e5d670d09ef1351d8f01bae: > > > > > > Merge remote-tracking branch > > > 'remotes/alistair/tags/pull-riscv-to-apply-20200619-3' into staging > > > (2020-06-22 14:45:25 +0100) > > > > > > are available in the Git repository at: > > > > > > https://github.com/stefanha/qemu.git tags/block-pull-request > > > > > > for you to fetch changes up to 7838c67f22a81fcf669785cd6c0876438422071a: > > > > > > block/nvme: support nested aio_poll() (2020-06-23 15:46:08 +0100) > > > > > > > > > Pull request > > > > > > > > > > Failure on iotest 030, x86-64 Linux: > > > > TESTiotest-qcow2: 030 [fail] > > QEMU -- > > "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" > > -nodefaults -display none -accel qtest > > QEMU_IMG -- > > "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-img" > > QEMU_IO -- > > "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-io" > > --cache writeback --aio threads -f qcow2 > > QEMU_NBD -- > > "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-nbd" > > IMGFMT-- qcow2 (compat=1.1) > > IMGPROTO -- file > > PLATFORM -- Linux/x86_64 e104462 4.15.0-76-generic > > TEST_DIR -- > > /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/scratch > > SOCK_DIR -- /tmp/tmp.8tgdDjoZcO > > SOCKET_SCM_HELPER -- > > /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotest/socket_scm_helper > > > > --- /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/030.out > > 2019-07-15 17:18:35.251364738 +0100 > > +++ > > /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/030.out.bad > > 2020-06-25 14:04:28.500534007 +0100 > > @@ -1,5 +1,17 @@ > > -... > > +.F. > > +== > > +FAIL: test_stream_parallel (__main__.TestParallelOps) > > +-- > > +Traceback (most recent call last): > > + File "030", line 246, in test_stream_parallel > > +self.assert_qmp(result, 'return', {}) > > + File > > "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", > > line 848, in assert_qmp > > +result = self.dictpath(d, path) > > + File > > "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", > > line 822, in dictpath > > +self.fail(f'failed path traversal for "{path}" in "{d}"') > > +AssertionError: failed path traversal for "return" in "{'error': > > {'class': 'DeviceNotActive', 'desc': "Block job 'stream-node8' not > > found"}}" > > + > > -- > > Ran 27 tests > > > > -OK > > +FAILED (failures=1) > > Strange, I can't reproduce this failure on my pull request branch or on > qemu.git/master. > > Is this failure deterministic? Are you sure it is introduced by this > pull request? It might be a random one that you got hit by; I just bounced the request because it's a block pullreq rather than anything obviously unrelated (and because I hadn't seen it before). I can have another go at merging this if you don't think it looks like it would be something caused by any of the patches in this series. thanks -- PMM
Re: [PULL 00/12] Block patches
On Thu, Jun 25, 2020 at 02:31:14PM +0100, Peter Maydell wrote: > On Wed, 24 Jun 2020 at 11:02, Stefan Hajnoczi wrote: > > > > The following changes since commit 171199f56f5f9bdf1e5d670d09ef1351d8f01bae: > > > > Merge remote-tracking branch > > 'remotes/alistair/tags/pull-riscv-to-apply-20200619-3' into staging > > (2020-06-22 14:45:25 +0100) > > > > are available in the Git repository at: > > > > https://github.com/stefanha/qemu.git tags/block-pull-request > > > > for you to fetch changes up to 7838c67f22a81fcf669785cd6c0876438422071a: > > > > block/nvme: support nested aio_poll() (2020-06-23 15:46:08 +0100) > > > > > > Pull request > > > > > > Failure on iotest 030, x86-64 Linux: > > TESTiotest-qcow2: 030 [fail] > QEMU -- > "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" > -nodefaults -display none -accel qtest > QEMU_IMG -- > "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-img" > QEMU_IO -- > "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-io" > --cache writeback --aio threads -f qcow2 > QEMU_NBD -- > "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-nbd" > IMGFMT-- qcow2 (compat=1.1) > IMGPROTO -- file > PLATFORM -- Linux/x86_64 e104462 4.15.0-76-generic > TEST_DIR -- > /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/scratch > SOCK_DIR -- /tmp/tmp.8tgdDjoZcO > SOCKET_SCM_HELPER -- > /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotest/socket_scm_helper > > --- /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/030.out > 2019-07-15 17:18:35.251364738 +0100 > +++ > /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/030.out.bad > 2020-06-25 14:04:28.500534007 +0100 > @@ -1,5 +1,17 @@ > -... > +.F. > +== > +FAIL: test_stream_parallel (__main__.TestParallelOps) > +-- > +Traceback (most recent call last): > + File "030", line 246, in test_stream_parallel > +self.assert_qmp(result, 'return', {}) > + File "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", > line 848, in assert_qmp > +result = self.dictpath(d, path) > + File "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", > line 822, in dictpath > +self.fail(f'failed path traversal for "{path}" in "{d}"') > +AssertionError: failed path traversal for "return" in "{'error': > {'class': 'DeviceNotActive', 'desc': "Block job 'stream-node8' not > found"}}" > + > -- > Ran 27 tests > > -OK > +FAILED (failures=1) Strange, I can't reproduce this failure on my pull request branch or on qemu.git/master. Is this failure deterministic? Are you sure it is introduced by this pull request? Stefan signature.asc Description: PGP signature
Re: [PULL 00/12] Block patches
On Wed, 24 Jun 2020 at 11:02, Stefan Hajnoczi wrote: > > The following changes since commit 171199f56f5f9bdf1e5d670d09ef1351d8f01bae: > > Merge remote-tracking branch > 'remotes/alistair/tags/pull-riscv-to-apply-20200619-3' into staging > (2020-06-22 14:45:25 +0100) > > are available in the Git repository at: > > https://github.com/stefanha/qemu.git tags/block-pull-request > > for you to fetch changes up to 7838c67f22a81fcf669785cd6c0876438422071a: > > block/nvme: support nested aio_poll() (2020-06-23 15:46:08 +0100) > > > Pull request > > Failure on iotest 030, x86-64 Linux: TESTiotest-qcow2: 030 [fail] QEMU -- "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" -nodefaults -display none -accel qtest QEMU_IMG -- "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-img" QEMU_IO -- "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-io" --cache writeback --aio threads -f qcow2 QEMU_NBD -- "/home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/../../qemu-nbd" IMGFMT-- qcow2 (compat=1.1) IMGPROTO -- file PLATFORM -- Linux/x86_64 e104462 4.15.0-76-generic TEST_DIR -- /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/scratch SOCK_DIR -- /tmp/tmp.8tgdDjoZcO SOCKET_SCM_HELPER -- /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotest/socket_scm_helper --- /home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/030.out 2019-07-15 17:18:35.251364738 +0100 +++ /home/petmay01/linaro/qemu-for-merges/build/alldbg/tests/qemu-iotests/030.out.bad 2020-06-25 14:04:28.500534007 +0100 @@ -1,5 +1,17 @@ -... +.F. +== +FAIL: test_stream_parallel (__main__.TestParallelOps) +-- +Traceback (most recent call last): + File "030", line 246, in test_stream_parallel +self.assert_qmp(result, 'return', {}) + File "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", line 848, in assert_qmp +result = self.dictpath(d, path) + File "/home/petmay01/linaro/qemu-for-merges/tests/qemu-iotests/iotests.py", line 822, in dictpath +self.fail(f'failed path traversal for "{path}" in "{d}"') +AssertionError: failed path traversal for "return" in "{'error': {'class': 'DeviceNotActive', 'desc': "Block job 'stream-node8' not found"}}" + -- Ran 27 tests -OK +FAILED (failures=1) thanks -- PMM
[PULL 00/12] Block patches
The following changes since commit 171199f56f5f9bdf1e5d670d09ef1351d8f01bae: Merge remote-tracking branch 'remotes/alistair/tags/pull-riscv-to-apply-20200619-3' into staging (2020-06-22 14:45:25 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to 7838c67f22a81fcf669785cd6c0876438422071a: block/nvme: support nested aio_poll() (2020-06-23 15:46:08 +0100) Pull request Daniele Buono (4): coroutine: support SafeStack in ucontext backend coroutine: add check for SafeStack in sigaltstack configure: add flags to support SafeStack check-block: enable iotests with SafeStack Stefan Hajnoczi (8): minikconf: explicitly set encoding to UTF-8 block/nvme: poll queues without q->lock block/nvme: drop tautologous assertion block/nvme: don't access CQE after moving cq.head block/nvme: switch to a NVMeRequest freelist block/nvme: clarify that free_req_queue is protected by q->lock block/nvme: keep BDRVNVMeState pointer in NVMeQueuePair block/nvme: support nested aio_poll() configure| 73 include/qemu/coroutine_int.h | 5 + block/nvme.c | 220 +-- util/coroutine-sigaltstack.c | 4 + util/coroutine-ucontext.c| 28 + block/trace-events | 2 +- scripts/minikconf.py | 6 +- tests/check-block.sh | 12 +- 8 files changed, 284 insertions(+), 66 deletions(-) -- 2.26.2
Re: [Qemu-block] [PULL 00/12] Block patches
On Tue, 27 Aug 2019 at 21:16, Stefan Hajnoczi wrote: > > The following changes since commit dac03af5d5482ec7ee9c23db467bb7230b33c0d9: > > Merge remote-tracking branch 'remotes/rth/tags/pull-axp-20190825' into > staging (2019-08-27 10:00:51 +0100) > > are available in the Git repository at: > > https://github.com/stefanha/qemu.git tags/block-pull-request > > for you to fetch changes up to 5396234b96a2ac743f48644529771498e036e698: > > block/qcow2: implement .bdrv_co_pwritev(_compressed)_part (2019-08-27 > 14:58:42 +0100) > > > Pull request Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2 for any user-visible changes. -- PMM
[Qemu-block] [PULL 00/12] Block patches
The following changes since commit dac03af5d5482ec7ee9c23db467bb7230b33c0d9: Merge remote-tracking branch 'remotes/rth/tags/pull-axp-20190825' into staging (2019-08-27 10:00:51 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to 5396234b96a2ac743f48644529771498e036e698: block/qcow2: implement .bdrv_co_pwritev(_compressed)_part (2019-08-27 14:58:42 +0100) Pull request Vladimir Sementsov-Ogievskiy (12): util/iov: introduce qemu_iovec_init_extended util/iov: improve qemu_iovec_is_zero block/io: refactor padding block: define .*_part io handlers in BlockDriver block/io: bdrv_co_do_copy_on_readv: use and support qiov_offset block/io: bdrv_co_do_copy_on_readv: lazy allocation block/io: bdrv_aligned_preadv: use and support qiov_offset block/io: bdrv_aligned_pwritev: use and support qiov_offset block/io: introduce bdrv_co_p{read, write}v_part block/qcow2: refactor qcow2_co_preadv to use buffer-based io block/qcow2: implement .bdrv_co_preadv_part block/qcow2: implement .bdrv_co_pwritev(_compressed)_part block/qcow2.h | 1 + include/block/block_int.h | 21 ++ include/qemu/iov.h| 10 +- block/backup.c| 2 +- block/io.c| 541 +++--- block/qcow2-cluster.c | 14 +- block/qcow2.c | 131 + qemu-img.c| 4 +- util/iov.c| 153 +-- 9 files changed, 568 insertions(+), 309 deletions(-) -- 2.21.0
Re: [Qemu-block] [PULL 00/12] Block patches
On Fri, May 26, 2017 at 03:23:52PM -0400, Jeff Cody wrote: > The following changes since commit 9964e96dccf7f7c936ee854a795415d19b60: > > Merge remote-tracking branch 'jasowang/tags/net-pull-request' into staging > (2017-05-23 15:01:31 +0100) > > are available in the git repository at: > > git://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request > > for you to fetch changes up to 223a23c198787328ae75bc65d84edf5fde33c0b6: > > block/gluster: glfs_lseek() workaround (2017-05-24 16:44:46 -0400) > > > Block patches > > > Jeff Cody (1): > block/gluster: glfs_lseek() workaround > > Paolo Bonzini (11): > blockjob: remove unnecessary check > blockjob: remove iostatus_reset callback > blockjob: introduce block_job_early_fail > blockjob: introduce block_job_pause/resume_all > blockjob: separate monitor and blockjob APIs > blockjob: move iostatus reset inside block_job_user_resume > blockjob: introduce block_job_cancel_async, check iostatus invariants > blockjob: group BlockJob transaction functions together > blockjob: strengthen a bit test-blockjob-txn > blockjob: reorganize block_job_completed_txn_abort > blockjob: use deferred_to_main_loop to indicate the coroutine has > ended > > block/backup.c | 2 +- > block/commit.c | 2 +- > block/gluster.c | 18 +- > block/io.c | 19 +- > block/mirror.c | 2 +- > blockdev.c | 1 - > blockjob.c | 750 > --- > include/block/blockjob.h | 16 - > include/block/blockjob_int.h | 27 +- > tests/test-blockjob-txn.c| 7 +- > tests/test-blockjob.c| 10 +- > 11 files changed, 463 insertions(+), 391 deletions(-) > > -- > 2.9.3 > > Thanks, applied to my staging tree: https://github.com/stefanha/qemu/commits/staging Stefan signature.asc Description: PGP signature
[Qemu-block] [PULL 00/12] Block patches
The following changes since commit 9964e96dccf7f7c936ee854a795415d19b60: Merge remote-tracking branch 'jasowang/tags/net-pull-request' into staging (2017-05-23 15:01:31 +0100) are available in the git repository at: git://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request for you to fetch changes up to 223a23c198787328ae75bc65d84edf5fde33c0b6: block/gluster: glfs_lseek() workaround (2017-05-24 16:44:46 -0400) Block patches Jeff Cody (1): block/gluster: glfs_lseek() workaround Paolo Bonzini (11): blockjob: remove unnecessary check blockjob: remove iostatus_reset callback blockjob: introduce block_job_early_fail blockjob: introduce block_job_pause/resume_all blockjob: separate monitor and blockjob APIs blockjob: move iostatus reset inside block_job_user_resume blockjob: introduce block_job_cancel_async, check iostatus invariants blockjob: group BlockJob transaction functions together blockjob: strengthen a bit test-blockjob-txn blockjob: reorganize block_job_completed_txn_abort blockjob: use deferred_to_main_loop to indicate the coroutine has ended block/backup.c | 2 +- block/commit.c | 2 +- block/gluster.c | 18 +- block/io.c | 19 +- block/mirror.c | 2 +- blockdev.c | 1 - blockjob.c | 750 --- include/block/blockjob.h | 16 - include/block/blockjob_int.h | 27 +- tests/test-blockjob-txn.c| 7 +- tests/test-blockjob.c| 10 +- 11 files changed, 463 insertions(+), 391 deletions(-) -- 2.9.3
Re: [Qemu-block] [PULL 00/12] Block patches
On 21 April 2017 at 14:46, Jeff Cody wrote: > The following changes since commit bfec359afba088aaacc7d316f43302f28c6e642a: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qdev-2017-04-21' > into staging (2017-04-21 11:42:03 +0100) > > are available in the git repository at: > > git://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request > > for you to fetch changes up to 1507631e438930bc07f776f303af127a9cdb4d41: > > qemu-iotests: _cleanup_qemu must be called on exit (2017-04-21 08:32:44 > -0400) > > > > Block patches for 2.10 > Hi, I'm afraid this runs into format string compile issues: In file included from block/trace.c:4: /Users/pm215/src/qemu-for-merges/build/all/block/trace.h:1465:42: error: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat] , guid, iodir, size, off, acb, ret, err); ^~~~ /Users/pm215/src/qemu-for-merges/include/qemu/log.h:94:30: note: expanded from macro 'qemu_log_mask' qemu_log(FMT, ## __VA_ARGS__); \ ^ In file included from block/trace.c:4: /Users/pm215/src/qemu-for-merges/build/all/block/trace.h:1465:48: error: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat] , guid, iodir, size, off, acb, ret, err); ^~~ /Users/pm215/src/qemu-for-merges/include/qemu/log.h:94:30: note: expanded from macro 'qemu_log_mask' qemu_log(FMT, ## __VA_ARGS__); \ ^ In file included from block/trace.c:4: /Users/pm215/src/qemu-for-merges/build/all/block/trace.h:1493:41: error: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat] , vdisk_guid, vdisk_size); ^~ /Users/pm215/src/qemu-for-merges/include/qemu/log.h:94:30: note: expanded from macro 'qemu_log_mask' qemu_log(FMT, ## __VA_ARGS__); \ ^ In file included from block/trace.c:4: /Users/pm215/src/qemu-for-merges/build/all/block/trace.h:1507:34: error: format specifies type 'long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat] , acb, ret); ^~~ /Users/pm215/src/qemu-for-merges/include/qemu/log.h:94:30: note: expanded from macro 'qemu_log_mask' qemu_log(FMT, ## __VA_ARGS__); \ ^ 4 errors generated. Those are the OSX errors, but the compile also fails for 32-bit hosts (including w32). thanks -- PMM
[Qemu-block] [PULL 00/12] Block patches
The following changes since commit bfec359afba088aaacc7d316f43302f28c6e642a: Merge remote-tracking branch 'remotes/armbru/tags/pull-qdev-2017-04-21' into staging (2017-04-21 11:42:03 +0100) are available in the git repository at: git://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull-request for you to fetch changes up to 1507631e438930bc07f776f303af127a9cdb4d41: qemu-iotests: _cleanup_qemu must be called on exit (2017-04-21 08:32:44 -0400) Block patches for 2.10 Ashish Mittal (2): block/vxhs.c: Add support for a new block device type called "vxhs" block/vxhs.c: Add qemu-iotests for new block device type "vxhs" Jeff Cody (10): qemu-iotests: exclude vxhs from image creation via protocol block: add bdrv_set_read_only() helper function block: do not set BDS read_only if copy_on_read enabled block: honor BDRV_O_ALLOW_RDWR when clearing bs->read_only block: code movement block: introduce bdrv_can_set_read_only() block: use bdrv_can_set_read_only() during reopen block/rbd - update variable names to more apt names block/rbd: Add support for reopen() qemu-iotests: _cleanup_qemu must be called on exit block.c | 56 +++- block/Makefile.objs | 2 + block/bochs.c| 5 +- block/cloop.c| 5 +- block/dmg.c | 6 +- block/rbd.c | 65 +++-- block/trace-events | 17 ++ block/vvfat.c| 19 +- block/vxhs.c | 575 +++ configure| 39 +++ include/block/block.h| 2 + qapi/block-core.json | 23 +- tests/qemu-iotests/017 | 1 + tests/qemu-iotests/020 | 1 + tests/qemu-iotests/028 | 1 + tests/qemu-iotests/029 | 1 + tests/qemu-iotests/073 | 1 + tests/qemu-iotests/094 | 11 +- tests/qemu-iotests/102 | 5 +- tests/qemu-iotests/109 | 1 + tests/qemu-iotests/114 | 1 + tests/qemu-iotests/117 | 1 + tests/qemu-iotests/130 | 2 + tests/qemu-iotests/134 | 1 + tests/qemu-iotests/140 | 1 + tests/qemu-iotests/141 | 1 + tests/qemu-iotests/143 | 1 + tests/qemu-iotests/156 | 2 + tests/qemu-iotests/158 | 1 + tests/qemu-iotests/common| 6 + tests/qemu-iotests/common.config | 13 + tests/qemu-iotests/common.filter | 1 + tests/qemu-iotests/common.rc | 19 ++ 33 files changed, 844 insertions(+), 42 deletions(-) create mode 100644 block/vxhs.c -- 2.9.3
Re: [Qemu-block] [PULL 00/12] Block patches
On 29 February 2016 at 20:08, Jeff Cody wrote: > The following changes since commit 071608b519adf62bc29c914343a21c5407ab1ac9: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20160229-1' into > staging (2016-02-29 12:24:26 +) > > are available in the git repository at: > > > g...@github.com:codyprime/qemu-kvm-jtc.git tags/block-pull-request > > for you to fetch changes up to cc199b16cf4cb9279aca73f5f5dce2cc337b9079: > > iotests/124: Add cluster_size mismatch test (2016-02-29 14:55:14 -0500) > > > Block patches > > Applied, thanks. -- PMM
[Qemu-block] [PULL 00/12] Block patches
The following changes since commit 071608b519adf62bc29c914343a21c5407ab1ac9: Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20160229-1' into staging (2016-02-29 12:24:26 +) are available in the git repository at: g...@github.com:codyprime/qemu-kvm-jtc.git tags/block-pull-request for you to fetch changes up to cc199b16cf4cb9279aca73f5f5dce2cc337b9079: iotests/124: Add cluster_size mismatch test (2016-02-29 14:55:14 -0500) Block patches Daniel P. Berrange (3): rbd: add support for getting password from QCryptoSecret object curl: add support for HTTP authentication parameters iscsi: add support for getting CHAP password via QCryptoSecret API Fam Zheng (2): mirror: Rewrite mirror_iteration mirror: Add mirror_wait_for_io John Snow (3): block/backup: make backup cluster size configurable block/backup: avoid copying less than full target clusters iotests/124: Add cluster_size mismatch test Max Reitz (2): vhdx: DIV_ROUND_UP() in vhdx_calc_bat_entries() vhdx: Simplify vhdx_set_shift_bits() Peter Lieven (1): block/nfs: add support for setting debug level Vasiliy Tolstov (1): sheepdog: allow to delete snapshot block/backup.c | 87 +++ block/curl.c | 66 + block/iscsi.c | 24 ++- block/mirror.c | 353 +++-- block/nfs.c| 12 ++ block/rbd.c| 47 ++ block/sheepdog.c | 125 +++- block/vhdx.c | 18 +-- tests/qemu-iotests/109.out | 80 +- tests/qemu-iotests/124 | 58 +++- tests/qemu-iotests/124.out | 4 +- trace-events | 1 - 12 files changed, 641 insertions(+), 234 deletions(-) -- 1.9.3