Re: [Qemu-block] [PATCH v1 1/1] iotests: fix the actual-size in 191.out

2017-10-16 Thread QingFeng Hao 



在 2017/10/16 20:31, Eric Blake 写道:

On 10/16/2017 03:30 AM, Kevin Wolf wrote:

Am 16.10.2017 um 07:23 hat QingFeng Hao geschrieben:

The actual-size set in 191.out is wrong, which causes the test case failed
and shall be 331776.
The actual-size indicates the image's (e.g. t.qcow2.base) actual size
defined by ImageInfo.actual_size.

Signed-off-by: QingFeng Hao 

This is wrong. It may make the test work on your machine, but it breaks
it on mine.

The correct approach to fix this is Max' "[PATCH 2/2] iotests: Filter
actual image size in 184 and 191".

That, and ALL patches should be sent to qemu-de...@nongnu.org, in
addition to whatever other lists are appropriate (you are correct that
this patch should cc qemu-block, but you forgot qemu-devel).

Thanks for your reminder. I'll pay attention next time.




--
Regards
QingFeng Hao

Re: [Qemu-block] [PATCH v1 1/1] iotests: fix the actual-size in 191.out

2017-10-16 Thread QingFeng Hao 



在 2017/10/16 16:30, Kevin Wolf 写道:

Am 16.10.2017 um 07:23 hat QingFeng Hao geschrieben:

The actual-size set in 191.out is wrong, which causes the test case failed
and shall be 331776.
The actual-size indicates the image's (e.g. t.qcow2.base) actual size
defined by ImageInfo.actual_size.

Signed-off-by: QingFeng Hao 

This is wrong. It may make the test work on your machine, but it breaks
it on mine.

The correct approach to fix this is Max' "[PATCH 2/2] iotests: Filter
actual image size in 184 and 191".
Thanks, I'll look into why it behaves differently in host file systems. 
Maybe it's
related with block size etc. If that's true, Max's patch to filter it 
makes sense.


Kevin



--
Regards
QingFeng Hao

Re: [Qemu-block] [PATCH v1 1/1] iotests: fix the actual-size in 191.out

2017-10-16 Thread Eric Blake 
On 10/16/2017 03:30 AM, Kevin Wolf wrote:
> Am 16.10.2017 um 07:23 hat QingFeng Hao geschrieben:
>> The actual-size set in 191.out is wrong, which causes the test case failed
>> and shall be 331776.
>> The actual-size indicates the image's (e.g. t.qcow2.base) actual size
>> defined by ImageInfo.actual_size.
>>
>> Signed-off-by: QingFeng Hao 
> 
> This is wrong. It may make the test work on your machine, but it breaks
> it on mine.
> 
> The correct approach to fix this is Max' "[PATCH 2/2] iotests: Filter
> actual image size in 184 and 191".

That, and ALL patches should be sent to qemu-de...@nongnu.org, in
addition to whatever other lists are appropriate (you are correct that
this patch should cc qemu-block, but you forgot qemu-devel).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



signature.asc
Description: OpenPGP digital signature

Re: [Qemu-block] [PATCH v1 1/1] iotests: fix the actual-size in 191.out

2017-10-16 Thread Kevin Wolf 
Am 16.10.2017 um 07:23 hat QingFeng Hao geschrieben:
> The actual-size set in 191.out is wrong, which causes the test case failed
> and shall be 331776.
> The actual-size indicates the image's (e.g. t.qcow2.base) actual size
> defined by ImageInfo.actual_size.
> 
> Signed-off-by: QingFeng Hao 

This is wrong. It may make the test work on your machine, but it breaks
it on mine.

The correct approach to fix this is Max' "[PATCH 2/2] iotests: Filter
actual image size in 184 and 191".

Kevin

[Qemu-block] [PATCH v1 1/1] iotests: fix the actual-size in 191.out

2017-10-15 Thread QingFeng Hao 
The actual-size set in 191.out is wrong, which causes the test case failed
and shall be 331776.
The actual-size indicates the image's (e.g. t.qcow2.base) actual size
defined by ImageInfo.actual_size.

Signed-off-by: QingFeng Hao 
---
 tests/qemu-iotests/191.out | 24 
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/tests/qemu-iotests/191.out b/tests/qemu-iotests/191.out
index 7bfcd2d..d9a9e54 100644
--- a/tests/qemu-iotests/191.out
+++ b/tests/qemu-iotests/191.out
@@ -47,7 +47,7 @@ wrote 65536/65536 bytes at offset 1048576
 "filename": "TEST_DIR/t.qcow2.base",
 "cluster-size": 65536,
 "format": "qcow2",
-"actual-size": 397312,
+"actual-size": 331776,
 "format-specific": {
 "type": "qcow2",
 "data": {
@@ -136,7 +136,7 @@ wrote 65536/65536 bytes at offset 1048576
 "filename": "TEST_DIR/t.qcow2.base",
 "cluster-size": 65536,
 "format": "qcow2",
-"actual-size": 397312,
+"actual-size": 331776,
 "format-specific": {
 "type": "qcow2",
 "data": {
@@ -225,7 +225,7 @@ wrote 65536/65536 bytes at offset 1048576
 "filename": "TEST_DIR/t.qcow2.base",
 "cluster-size": 65536,
 "format": "qcow2",
-"actual-size": 397312,
+"actual-size": 331776,
 "format-specific": {
 "type": "qcow2",
 "data": {
@@ -242,7 +242,7 @@ wrote 65536/65536 bytes at offset 1048576
 "filename": "TEST_DIR/t.qcow2.mid",
 "cluster-size": 65536,
 "format": "qcow2",
-"actual-size": 397312,
+"actual-size": 331776,
 "format-specific": {
 "type": "qcow2",
 "data": {
@@ -283,7 +283,7 @@ wrote 65536/65536 bytes at offset 1048576
 "virtual-size": 393216,
 "filename": "TEST_DIR/t.qcow2.mid",
 "format": "file",
-"actual-size": 397312,
+"actual-size": 331776,
 "dirty-flag": false
 },
 "iops_wr": 0,
@@ -313,7 +313,7 @@ wrote 65536/65536 bytes at offset 1048576
 "filename": "TEST_DIR/t.qcow2.base",
 "cluster-size": 65536,
 "format": "qcow2",
-"actual-size": 397312,
+"actual-size": 331776,
 "format-specific": {
 "type": "qcow2",
 "data": {
@@ -351,7 +351,7 @@ wrote 65536/65536 bytes at offset 1048576
 "virtual-size": 393216,
 "filename": "TEST_DIR/t.qcow2.base",
 "format": "file",
-"actual-size": 397312,
+"actual-size": 331776,
 "dirty-flag": false
 },
 "iops_wr": 0,
@@ -450,7 +450,7 @@ wrote 65536/65536 bytes at offset 1048576
 "filename": "TEST_DIR/t.qcow2.base",
 "cluster-size": 65536,
 "format": "qcow2",
-"actual-size": 397312,
+"actual-size": 331776,
 "format-specific": {
 "type": "qcow2",
 "data": {
@@ -540,7 +540,7 @@ wrote 65536/65536 bytes at offset 1048576
 "filename": "TEST_DIR/t.qcow2.base",
 "cluster-size": 65536,
 "format": "qcow2",
-"actual-size": 397312,
+"actual-size": 331776,
 "format-specific": {
 "type": "qcow2",
 "data": {
@@ -647,7 +647,7 @@ wrote 65536/65536 bytes at offset 1048576
 "filename": "TEST_DIR/t.qcow2.base",
 "cluster-size": 65536,
 "format": "qcow2",
-"actual-size": 397312,
+"actual-size": 331776,
 "format-specific": {
 "type": "qcow2",
 "data": {
@@ -685,7 +685,7 @@ wrote 65536/65536 bytes at offset 1048576
 "virtual-size": 393216,
 "filename": "TEST_DIR/t.qcow2.base",
 "format": "file",
-"actual-size": 397312,
+"actual-size": 331776,
 "dirty-flag": false
 },
 "iops_wr": 0,
@@ -716,7 +716,7 @@ wrote 65536/65536 bytes at offset 1048576
 "filename": "TEST_DIR/t.qcow2.base",
 "cluster-size": 65536,