Re: [Qemu-block] [PATCH v2 0/3] vmdk: Move descriptor buffers to heap

[Kevin Wolf]

Am 08.03.2016 um 09:24 hat Fam Zheng geschrieben:
> All three functions are not in hot path (all run once for the BDS lifecycle),
> so it's okay to convert to g_malloc0.

Yeah, it's okay, but still kind of useless to memset the whole buffer
before you overwrite it anyway. There's also a useless ret = 0 somewhere.
I'd prefer not to do that in the next series.

Anyway, thanks, applied to the block branch.

Kevin

Re: [Qemu-block] [PATCH v2 0/3] vmdk: Move descriptor buffers to heap

[Paolo Bonzini]

On 08/03/2016 09:24, Fam Zheng wrote:
> All three functions are not in hot path (all run once for the BDS lifecycle),
> so it's okay to convert to g_malloc0.
> 
> Fam
> 
> 
> Fam Zheng (3):
>   vmdk: Switch to heap arrays for vmdk_write_cid
>   vmdk: Switch to heap arrays for vmdk_read_cid
>   vmdk: Switch to heap arrays for vmdk_parent_open
> 
>  block/vmdk.c | 47 +--
>  1 file changed, 29 insertions(+), 18 deletions(-)
> 

Reviewed-by: Paolo Bonzini 

[Qemu-block] [PATCH v2 0/3] vmdk: Move descriptor buffers to heap

[Fam Zheng]

All three functions are not in hot path (all run once for the BDS lifecycle),
so it's okay to convert to g_malloc0.

Fam


Fam Zheng (3):
  vmdk: Switch to heap arrays for vmdk_write_cid
  vmdk: Switch to heap arrays for vmdk_read_cid
  vmdk: Switch to heap arrays for vmdk_parent_open

 block/vmdk.c | 47 +--
 1 file changed, 29 insertions(+), 18 deletions(-)

-- 
2.4.3