Re: [Qemu-block] [PATCH v3 05/38] block: Add blk_is_available()

2015-06-04 Thread Alberto Garcia
On Wed 03 Jun 2015 09:43:46 PM CEST, Max Reitz wrote:
 blk_is_available() returns true iff the BDS is inserted (which means
 blk_bs() is not NULL and bdrv_is_inserted() returns true) and if the
 tray of the guest device is closed.

 blk_is_inserted() is changed to return true only if blk_bs() is not
 NULL.

 Signed-off-by: Max Reitz mre...@redhat.com
 Reviewed-by: Eric Blake ebl...@redhat.com
Reviewed-by: Alberto Garcia be...@igalia.com

Berto



[Qemu-block] [PATCH v3 05/38] block: Add blk_is_available()

2015-06-03 Thread Max Reitz
blk_is_available() returns true iff the BDS is inserted (which means
blk_bs() is not NULL and bdrv_is_inserted() returns true) and if the
tray of the guest device is closed.

blk_is_inserted() is changed to return true only if blk_bs() is not
NULL.

Signed-off-by: Max Reitz mre...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
---
 block/block-backend.c  | 7 ++-
 include/sysemu/block-backend.h | 1 +
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/block/block-backend.c b/block/block-backend.c
index 29baab2..d034c78 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -749,7 +749,12 @@ void blk_invalidate_cache(BlockBackend *blk, Error **errp)
 
 bool blk_is_inserted(BlockBackend *blk)
 {
-return bdrv_is_inserted(blk-bs);
+return blk-bs  bdrv_is_inserted(blk-bs);
+}
+
+bool blk_is_available(BlockBackend *blk)
+{
+return blk_is_inserted(blk)  !blk_dev_is_tray_open(blk);
 }
 
 void blk_lock_medium(BlockBackend *blk, bool locked)
diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h
index 189e72b..525b323 100644
--- a/include/sysemu/block-backend.h
+++ b/include/sysemu/block-backend.h
@@ -130,6 +130,7 @@ int blk_enable_write_cache(BlockBackend *blk);
 void blk_set_enable_write_cache(BlockBackend *blk, bool wce);
 void blk_invalidate_cache(BlockBackend *blk, Error **errp);
 bool blk_is_inserted(BlockBackend *blk);
+bool blk_is_available(BlockBackend *blk);
 void blk_lock_medium(BlockBackend *blk, bool locked);
 void blk_eject(BlockBackend *blk, bool eject_flag);
 int blk_get_flags(BlockBackend *blk);
-- 
2.4.1