Re: [Qemu-block] [Qemu-devel] [PATCH 3/9] IDE: add tracing for data ports
On 08/08/2017 04:30 PM, Eric Blake wrote: > On 08/08/2017 01:33 PM, John Snow wrote: >> To be used sparingly, but still interesting in the case of small >> firmwares designed to reproduce bugs in QEMU IDE. > > Is that because the trace would fire so frequently in normal usage that > it will drown the user in noise? > Yeah, and it's of little use for a real guest due to the volume and relative unimportance of what that data actually is >> >> Signed-off-by: John Snow >> --- >> hw/ide/core.c | 12 +++- >> 1 file changed, 11 insertions(+), 1 deletion(-) >> > > Reviewed-by: Eric Blake >
Re: [Qemu-block] [Qemu-devel] [PATCH 3/9] IDE: add tracing for data ports
On 08/08/2017 03:30 PM, Eric Blake wrote: > On 08/08/2017 01:33 PM, John Snow wrote: >> To be used sparingly, but still interesting in the case of small >> firmwares designed to reproduce bugs in QEMU IDE. > > Is that because the trace would fire so frequently in normal usage that > it will drown the user in noise? > >> >> Signed-off-by: John Snow >> --- >> hw/ide/core.c | 12 +++- >> 1 file changed, 11 insertions(+), 1 deletion(-) >> > > Reviewed-by: Eric Blake Argh. I had two compose windows open at once. R-b is only valid if you fix the time-traveling trace-events changes :) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature
Re: [Qemu-block] [Qemu-devel] [PATCH 3/9] IDE: add tracing for data ports
On 08/08/2017 01:33 PM, John Snow wrote: > To be used sparingly, but still interesting in the case of small > firmwares designed to reproduce bugs in QEMU IDE. Is that because the trace would fire so frequently in normal usage that it will drown the user in noise? > > Signed-off-by: John Snow > --- > hw/ide/core.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature
Re: [Qemu-block] [Qemu-devel] [PATCH 3/9] IDE: add tracing for data ports
On 08/08/2017 04:10 PM, Eric Blake wrote: > On 08/08/2017 01:33 PM, John Snow wrote: >> To be used sparingly, but still interesting in the case of small >> firmwares designed to reproduce bugs in QEMU IDE. >> >> Signed-off-by: John Snow >> --- >> hw/ide/core.c | 12 +++- >> 1 file changed, 11 insertions(+), 1 deletion(-) >> >> diff --git a/hw/ide/core.c b/hw/ide/core.c >> index 6235bdf..29848ff 100644 >> --- a/hw/ide/core.c >> +++ b/hw/ide/core.c >> @@ -2251,6 +2251,8 @@ void ide_data_writew(void *opaque, uint32_t addr, >> uint32_t val) >> IDEState *s = idebus_active_if(bus); >> uint8_t *p; >> >> +trace_ide_data_writew(addr, val, bus, s); > > Umm, where's the trace-events addition for this? > Accidentally traveled forward through time to patch 04.
Re: [Qemu-block] [Qemu-devel] [PATCH 3/9] IDE: add tracing for data ports
On 08/08/2017 01:33 PM, John Snow wrote: > To be used sparingly, but still interesting in the case of small > firmwares designed to reproduce bugs in QEMU IDE. > > Signed-off-by: John Snow > --- > hw/ide/core.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/hw/ide/core.c b/hw/ide/core.c > index 6235bdf..29848ff 100644 > --- a/hw/ide/core.c > +++ b/hw/ide/core.c > @@ -2251,6 +2251,8 @@ void ide_data_writew(void *opaque, uint32_t addr, > uint32_t val) > IDEState *s = idebus_active_if(bus); > uint8_t *p; > > +trace_ide_data_writew(addr, val, bus, s); Umm, where's the trace-events addition for this? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature
