Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode
Patchew URL: https://patchew.org/QEMU/20190703215542.16123-1-js...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode
Type: series
Message-id: 20190703215542.16123-1-js...@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
29d2e89 block/backup: loosen restriction on readonly bitmaps
3dac5e8 iotests: add test 257 for bitmap-mode backups
9b334f2 iotests: Add virtio-scsi device helper
76de918 iotests: teach FilePath to produce multiple paths
25e47cf iotests: teach run_job to cancel pending jobs
246979a iotests: add testing shim for script-style python tests
da9f5b2 block/backup: add 'always' bitmap sync policy
a0da4a4 block/backup: upgrade copy_bitmap to BdrvDirtyBitmap
c38beb0 block/dirty-bitmap: add bdrv_dirty_bitmap_get
e1f9101 block/dirty-bitmap: add bdrv_dirty_bitmap_merge_internal
8dcbb6e hbitmap: enable merging across granularities
f0a01f5 hbitmap: Fix merge when b is empty, and result is not an alias of a
cfddaac block/backup: add 'never' policy to bitmap sync mode
3d87c7e block/backup: Add mirror sync mode 'bitmap'
4bfeaea qapi: add BitmapSyncMode enum
aa153cb blockdev-backup: utilize do_backup_common
9b2ea6d drive-backup: create do_backup_common
f1dfe57 qapi/block-core: Introduce BackupCommon
=== OUTPUT BEGIN ===
1/18 Checking commit f1dfe5731cdd (qapi/block-core: Introduce BackupCommon)
2/18 Checking commit 9b2ea6d12ad1 (drive-backup: create do_backup_common)
3/18 Checking commit aa153cbc1d7b (blockdev-backup: utilize do_backup_common)
4/18 Checking commit 4bfeaeaea5c0 (qapi: add BitmapSyncMode enum)
5/18 Checking commit 3d87c7e95994 (block/backup: Add mirror sync mode 'bitmap')
6/18 Checking commit cfddaacb73e3 (block/backup: add 'never' policy to bitmap
sync mode)
WARNING: Block comments use a leading /* on a separate line
#26: FILE: block/backup.c:269:
+/* Failure, or we don't want to synchronize the bitmap.
WARNING: Block comments use a trailing */ on a separate line
#27: FILE: block/backup.c:270:
+ * Merge the successor back into the parent, delete nothing. */
total: 0 errors, 2 warnings, 25 lines checked
Patch 6/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/18 Checking commit f0a01f558ce5 (hbitmap: Fix merge when b is empty, and
result is not an alias of a)
8/18 Checking commit 8dcbb6e9f205 (hbitmap: enable merging across granularities)
9/18 Checking commit e1f9101828dc (block/dirty-bitmap: add
bdrv_dirty_bitmap_merge_internal)
10/18 Checking commit c38beb034ad8 (block/dirty-bitmap: add
bdrv_dirty_bitmap_get)
ERROR: open brace '{' following function declarations go on the next line
#36: FILE: block/dirty-bitmap.c:517:
+bool bdrv_dirty_bitmap_get(BdrvDirtyBitmap *bitmap, int64_t offset) {
total: 1 errors, 0 warnings, 72 lines checked
Patch 10/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/18 Checking commit a0da4a40d744 (block/backup: upgrade copy_bitmap to
BdrvDirtyBitmap)
WARNING: line over 80 characters
#60: FILE: block/backup.c:174:
+bdrv_reset_dirty_bitmap(job->copy_bitmap, start, job->cluster_size *
nr_clusters);
WARNING: line over 80 characters
#66: FILE: block/backup.c:179:
+bdrv_set_dirty_bitmap(job->copy_bitmap, start, job->cluster_size *
nr_clusters);
total: 0 errors, 2 warnings, 192 lines checked
Patch 11/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/18 Checking commit da9f5b248832 (block/backup: add 'always' bitmap sync
policy)
WARNING: Block comments use a leading /* on a separate line
#41: FILE: block/backup.c:273:
+/* We succeeded, or we always intended to sync the bitmap.
WARNING: Block comments use a trailing */ on a separate line
#42: FILE: block/backup.c:274:
+ * Delete this bitmap and install the child. */
WARNING: Block comments use a leading /* on a separate line
#46: FILE: block/backup.c:277:
+/* We failed, or we never intended to sync the bitmap anyway.
WARNING: Block comments use a trailing */ on a separate line
#47: FILE: block/backup.c:278:
+ * Merge the successor back into the parent, keeping all data. */
total: 0 errors, 4 warnings, 47 lines checked
Patch 12/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/18 Checking commit 246979a623e7 (iotests: add testing shim for script-style
python tests)
Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode
Patchew URL: https://patchew.org/QEMU/20190703215542.16123-1-js...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode
Type: series
Message-id: 20190703215542.16123-1-js...@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
- [tag update] patchew/20190703215542.16123-1-js...@redhat.com ->
patchew/20190703215542.16123-1-js...@redhat.com
Switched to a new branch 'test'
26e6479 block/backup: loosen restriction on readonly bitmaps
755e1b1 iotests: add test 257 for bitmap-mode backups
d48c9ee iotests: Add virtio-scsi device helper
b6e4226 iotests: teach FilePath to produce multiple paths
9b7ddb3 iotests: teach run_job to cancel pending jobs
78ed529 iotests: add testing shim for script-style python tests
78a4fa3 block/backup: add 'always' bitmap sync policy
edcb2f9 block/backup: upgrade copy_bitmap to BdrvDirtyBitmap
5691b3e block/dirty-bitmap: add bdrv_dirty_bitmap_get
3decdf3 block/dirty-bitmap: add bdrv_dirty_bitmap_merge_internal
1ee3ffe hbitmap: enable merging across granularities
0d187e6 hbitmap: Fix merge when b is empty, and result is not an alias of a
9fb7b80 block/backup: add 'never' policy to bitmap sync mode
3025abb block/backup: Add mirror sync mode 'bitmap'
78173da qapi: add BitmapSyncMode enum
8d6effc blockdev-backup: utilize do_backup_common
189a557 drive-backup: create do_backup_common
1aa2202 qapi/block-core: Introduce BackupCommon
=== OUTPUT BEGIN ===
1/18 Checking commit 1aa2202a91cb (qapi/block-core: Introduce BackupCommon)
2/18 Checking commit 189a557d32e9 (drive-backup: create do_backup_common)
3/18 Checking commit 8d6effca544a (blockdev-backup: utilize do_backup_common)
4/18 Checking commit 78173daac67b (qapi: add BitmapSyncMode enum)
5/18 Checking commit 3025abb79847 (block/backup: Add mirror sync mode 'bitmap')
6/18 Checking commit 9fb7b804caa8 (block/backup: add 'never' policy to bitmap
sync mode)
WARNING: Block comments use a leading /* on a separate line
#26: FILE: block/backup.c:269:
+/* Failure, or we don't want to synchronize the bitmap.
WARNING: Block comments use a trailing */ on a separate line
#27: FILE: block/backup.c:270:
+ * Merge the successor back into the parent, delete nothing. */
total: 0 errors, 2 warnings, 25 lines checked
Patch 6/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/18 Checking commit 0d187e69012e (hbitmap: Fix merge when b is empty, and
result is not an alias of a)
8/18 Checking commit 1ee3ffe706d4 (hbitmap: enable merging across granularities)
9/18 Checking commit 3decdf358bb7 (block/dirty-bitmap: add
bdrv_dirty_bitmap_merge_internal)
10/18 Checking commit 5691b3e06e73 (block/dirty-bitmap: add
bdrv_dirty_bitmap_get)
ERROR: open brace '{' following function declarations go on the next line
#36: FILE: block/dirty-bitmap.c:517:
+bool bdrv_dirty_bitmap_get(BdrvDirtyBitmap *bitmap, int64_t offset) {
total: 1 errors, 0 warnings, 72 lines checked
Patch 10/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/18 Checking commit edcb2f9d526e (block/backup: upgrade copy_bitmap to
BdrvDirtyBitmap)
WARNING: line over 80 characters
#60: FILE: block/backup.c:174:
+bdrv_reset_dirty_bitmap(job->copy_bitmap, start, job->cluster_size *
nr_clusters);
WARNING: line over 80 characters
#66: FILE: block/backup.c:179:
+bdrv_set_dirty_bitmap(job->copy_bitmap, start, job->cluster_size *
nr_clusters);
total: 0 errors, 2 warnings, 192 lines checked
Patch 11/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/18 Checking commit 78a4fa304c33 (block/backup: add 'always' bitmap sync
policy)
WARNING: Block comments use a leading /* on a separate line
#41: FILE: block/backup.c:273:
+/* We succeeded, or we always intended to sync the bitmap.
WARNING: Block comments use a trailing */ on a separate line
#42: FILE: block/backup.c:274:
+ * Delete this bitmap and install the child. */
WARNING: Block comments use a leading /* on a separate line
#46: FILE: block/backup.c:277:
+/* We failed, or we never intended to sync the bitmap anyway.
WARNING: Block comments use a trailing */ on a separate line
#47: FILE: block/backup.c:278:
+ * Merge the successor back into the parent, keeping all data. */
total: 0 errors, 4 warnings, 47 lines checked
Patch 12/18 has style problems, please review. If any of these errors
are false
Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode
I have clearly been lax in checking my coding style...
I'll fix these, but not until review.
On 7/3/19 9:50 PM, no-re...@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20190703215542.16123-1-js...@redhat.com/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Type: series
> Subject: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode
> Message-id: 20190703215542.16123-1-js...@redhat.com
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
>
> Switched to a new branch 'test'
> 18acfee block/backup: loosen restriction on readonly bitmaps
> 4852213 iotests: add test 257 for bitmap-mode backups
> 0d47743 iotests: Add virtio-scsi device helper
> 9805af4 iotests: teach FilePath to produce multiple paths
> b491804 iotests: teach run_job to cancel pending jobs
> 2925d97 iotests: add testing shim for script-style python tests
> c7870c0 block/backup: add 'always' bitmap sync policy
> 1a5bc8c block/backup: upgrade copy_bitmap to BdrvDirtyBitmap
> a7fd32c block/dirty-bitmap: add bdrv_dirty_bitmap_get
> 6ec8d60 block/dirty-bitmap: add bdrv_dirty_bitmap_merge_internal
> 8760b33 hbitmap: enable merging across granularities
> 919477d hbitmap: Fix merge when b is empty, and result is not an alias of a
> dd0775a block/backup: add 'never' policy to bitmap sync mode
> 998d008 block/backup: Add mirror sync mode 'bitmap'
> 5e678f1 qapi: add BitmapSyncMode enum
> 7e58e56 blockdev-backup: utilize do_backup_common
> e372afa drive-backup: create do_backup_common
> 677b04c qapi/block-core: Introduce BackupCommon
>
> === OUTPUT BEGIN ===
> 1/18 Checking commit 677b04c0b13d (qapi/block-core: Introduce BackupCommon)
> 2/18 Checking commit e372afac0fdc (drive-backup: create do_backup_common)
> 3/18 Checking commit 7e58e56768db (blockdev-backup: utilize do_backup_common)
> 4/18 Checking commit 5e678f15e446 (qapi: add BitmapSyncMode enum)
> 5/18 Checking commit 998d0084971b (block/backup: Add mirror sync mode
> 'bitmap')
> 6/18 Checking commit dd0775a4cf92 (block/backup: add 'never' policy to bitmap
> sync mode)
> WARNING: Block comments use a leading /* on a separate line
> #26: FILE: block/backup.c:269:
> +/* Failure, or we don't want to synchronize the bitmap.
>
> WARNING: Block comments use a trailing */ on a separate line
> #27: FILE: block/backup.c:270:
> + * Merge the successor back into the parent, delete nothing. */
>
> total: 0 errors, 2 warnings, 25 lines checked
>
> Patch 6/18 has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 7/18 Checking commit 919477d56466 (hbitmap: Fix merge when b is empty, and
> result is not an alias of a)
> 8/18 Checking commit 8760b336946d (hbitmap: enable merging across
> granularities)
> 9/18 Checking commit 6ec8d60f0329 (block/dirty-bitmap: add
> bdrv_dirty_bitmap_merge_internal)
> 10/18 Checking commit a7fd32c4817d (block/dirty-bitmap: add
> bdrv_dirty_bitmap_get)
> ERROR: open brace '{' following function declarations go on the next line
> #36: FILE: block/dirty-bitmap.c:517:
> +bool bdrv_dirty_bitmap_get(BdrvDirtyBitmap *bitmap, int64_t offset) {
>
> total: 1 errors, 0 warnings, 72 lines checked
>
> Patch 10/18 has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> 11/18 Checking commit 1a5bc8c73750 (block/backup: upgrade copy_bitmap to
> BdrvDirtyBitmap)
> WARNING: line over 80 characters
> #60: FILE: block/backup.c:174:
> +bdrv_reset_dirty_bitmap(job->copy_bitmap, start, job->cluster_size *
> nr_clusters);
>
> WARNING: line over 80 characters
> #66: FILE: block/backup.c:179:
> +bdrv_set_dirty_bitmap(job->copy_bitmap, start, job->cluster_size *
> nr_clusters);
>
> total: 0 errors, 2 warnings, 192 lines checked
>
> Patch 11/18 has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 12/18 Checking commit c7870c05906a (block/backup: add 'always' bitmap sync
> policy)
> WARNING: Block comments use a leading /* on a separate line
> #41: FILE: block/backup.c:273:
> +/* We succeeded, or we always intended to sync the bitmap.
>
> WARNING: Block comments use a trailing */ on a separate line
> #42: FILE: block/backup.c:274:
> + * Delete this bitmap and install the child. */
>
> WARNING: Block comments use a leading /* on a separate line
> #46: FILE: block/backup.c:277:
> +/* We failed, or we never intended to sync the bitmap anyway.
>
> WARNING: Block comments use a trailing */ on a separate line
> #47: FILE: block/backup.c:278:
Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode
Patchew URL: https://patchew.org/QEMU/20190703215542.16123-1-js...@redhat.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===
PASS 32 test-opts-visitor /visitor/opts/range/beyond
PASS 33 test-opts-visitor /visitor/opts/dict/unvisited
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-coroutine -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-coroutine"
==10176==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-coroutine /basic/no-dangling-access
PASS 2 test-coroutine /basic/lifecycle
PASS 3 test-coroutine /basic/yield
==10176==WARNING: ASan is ignoring requested __asan_handle_no_return: stack
top: 0x7ffd760c6000; bottom 0x7f81455f8000; size: 0x007c30ace000 (533392580608)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 4 test-coroutine /basic/nesting
---
PASS 1 fdc-test /x86_64/fdc/cmos
PASS 2 fdc-test /x86_64/fdc/no_media_on_start
PASS 3 fdc-test /x86_64/fdc/read_without_media
==10185==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 fdc-test /x86_64/fdc/media_change
PASS 5 fdc-test /x86_64/fdc/sense_interrupt
PASS 6 fdc-test /x86_64/fdc/relative_seek
---
PASS 11 test-aio /aio/event/wait
PASS 12 test-aio /aio/event/flush
PASS 13 test-aio /aio/event/wait/no-flush-cb
==10200==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 14 test-aio /aio/timer/schedule
PASS 15 test-aio /aio/coroutine/queue-chaining
PASS 16 test-aio /aio-gsource/flush
---
PASS 28 test-aio /aio-gsource/timer/schedule
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-aio-multithread -m=quick -k --tap < /dev/null |
./scripts/tap-driver.pl --test-name="test-aio-multithread"
PASS 1 test-aio-multithread /aio/multi/lifecycle
==10206==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 2 test-aio-multithread /aio/multi/schedule
PASS 3 test-aio-multithread /aio/multi/mutex/contended
PASS 12 fdc-test /x86_64/fdc/read_no_dma_19
PASS 13 fdc-test /x86_64/fdc/fuzz-registers
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img
tests/ide-test -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="ide-test"
==10234==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 test-aio-multithread /aio/multi/mutex/handoff
PASS 1 ide-test /x86_64/ide/identify
==10245==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 5 test-aio-multithread /aio/multi/mutex/mcs
PASS 2 ide-test /x86_64/ide/flush
==10256==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 6 test-aio-multithread /aio/multi/mutex/pthread
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-throttle -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-throttle"
PASS 1 test-throttle /throttle/leak_bucket
---
PASS 13 test-throttle /throttle/config/ranges
PASS 14 test-throttle /throttle/config/max
PASS 15 test-throttle /throttle/config/iops_size
==10264==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 3 ide-test /x86_64/ide/bmdma/simple_rw
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-thread-pool -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-thread-pool"
==10273==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-thread-pool /thread-pool/submit
PASS 2 test-thread-pool /thread-pool/submit-aio
PASS 3 test-thread-pool /thread-pool/submit-co
PASS 4 test-thread-pool /thread-pool/submit-many
==10268==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 5 test-thread-pool /thread-pool/cancel
PASS 4 ide-test /x86_64/ide/bmdma/trim
==10343==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 6 test-thread-pool /thread-pool/cancel-async
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-hbitmap -m=quick -k --tap < /dev/null |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode
Patchew URL: https://patchew.org/QEMU/20190703215542.16123-1-js...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode
Message-id: 20190703215542.16123-1-js...@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
18acfee block/backup: loosen restriction on readonly bitmaps
4852213 iotests: add test 257 for bitmap-mode backups
0d47743 iotests: Add virtio-scsi device helper
9805af4 iotests: teach FilePath to produce multiple paths
b491804 iotests: teach run_job to cancel pending jobs
2925d97 iotests: add testing shim for script-style python tests
c7870c0 block/backup: add 'always' bitmap sync policy
1a5bc8c block/backup: upgrade copy_bitmap to BdrvDirtyBitmap
a7fd32c block/dirty-bitmap: add bdrv_dirty_bitmap_get
6ec8d60 block/dirty-bitmap: add bdrv_dirty_bitmap_merge_internal
8760b33 hbitmap: enable merging across granularities
919477d hbitmap: Fix merge when b is empty, and result is not an alias of a
dd0775a block/backup: add 'never' policy to bitmap sync mode
998d008 block/backup: Add mirror sync mode 'bitmap'
5e678f1 qapi: add BitmapSyncMode enum
7e58e56 blockdev-backup: utilize do_backup_common
e372afa drive-backup: create do_backup_common
677b04c qapi/block-core: Introduce BackupCommon
=== OUTPUT BEGIN ===
1/18 Checking commit 677b04c0b13d (qapi/block-core: Introduce BackupCommon)
2/18 Checking commit e372afac0fdc (drive-backup: create do_backup_common)
3/18 Checking commit 7e58e56768db (blockdev-backup: utilize do_backup_common)
4/18 Checking commit 5e678f15e446 (qapi: add BitmapSyncMode enum)
5/18 Checking commit 998d0084971b (block/backup: Add mirror sync mode 'bitmap')
6/18 Checking commit dd0775a4cf92 (block/backup: add 'never' policy to bitmap
sync mode)
WARNING: Block comments use a leading /* on a separate line
#26: FILE: block/backup.c:269:
+/* Failure, or we don't want to synchronize the bitmap.
WARNING: Block comments use a trailing */ on a separate line
#27: FILE: block/backup.c:270:
+ * Merge the successor back into the parent, delete nothing. */
total: 0 errors, 2 warnings, 25 lines checked
Patch 6/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/18 Checking commit 919477d56466 (hbitmap: Fix merge when b is empty, and
result is not an alias of a)
8/18 Checking commit 8760b336946d (hbitmap: enable merging across granularities)
9/18 Checking commit 6ec8d60f0329 (block/dirty-bitmap: add
bdrv_dirty_bitmap_merge_internal)
10/18 Checking commit a7fd32c4817d (block/dirty-bitmap: add
bdrv_dirty_bitmap_get)
ERROR: open brace '{' following function declarations go on the next line
#36: FILE: block/dirty-bitmap.c:517:
+bool bdrv_dirty_bitmap_get(BdrvDirtyBitmap *bitmap, int64_t offset) {
total: 1 errors, 0 warnings, 72 lines checked
Patch 10/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/18 Checking commit 1a5bc8c73750 (block/backup: upgrade copy_bitmap to
BdrvDirtyBitmap)
WARNING: line over 80 characters
#60: FILE: block/backup.c:174:
+bdrv_reset_dirty_bitmap(job->copy_bitmap, start, job->cluster_size *
nr_clusters);
WARNING: line over 80 characters
#66: FILE: block/backup.c:179:
+bdrv_set_dirty_bitmap(job->copy_bitmap, start, job->cluster_size *
nr_clusters);
total: 0 errors, 2 warnings, 192 lines checked
Patch 11/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/18 Checking commit c7870c05906a (block/backup: add 'always' bitmap sync
policy)
WARNING: Block comments use a leading /* on a separate line
#41: FILE: block/backup.c:273:
+/* We succeeded, or we always intended to sync the bitmap.
WARNING: Block comments use a trailing */ on a separate line
#42: FILE: block/backup.c:274:
+ * Delete this bitmap and install the child. */
WARNING: Block comments use a leading /* on a separate line
#46: FILE: block/backup.c:277:
+/* We failed, or we never intended to sync the bitmap anyway.
WARNING: Block comments use a trailing */ on a separate line
#47: FILE: block/backup.c:278:
+ * Merge the successor back into the parent, keeping all data. */
total: 0 errors, 4 warnings, 47 lines checked
Patch 12/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/18 Checking commit 2925d97a5717 (iotests: add testing shim for script-style
python tests)
