RE: [RFC PATCH 09/15] sd: emmc: Add support for emmc erase

[Sai Pavan Boddu]

Hi Alistair,
> -Original Message-
> From: Alistair Francis 
> Sent: Saturday, February 13, 2021 3:38 AM
> To: Sai Pavan Boddu 
> Cc: Markus Armbruster ; Kevin Wolf
> ; Max Reitz ; Vladimir Sementsov-
> Ogievskiy ; Eric Blake ;
> Joel Stanley ; Cédric Le Goater ; Vincent
> Palatin ; Dr. David Alan Gilbert
> ; Thomas Huth ; Stefan Hajnoczi
> ; Peter Maydell ; Alistair
> Francis ; Edgar Iglesias ; Luc
> Michel ; Paolo Bonzini ;
> Sai Pavan Boddu ; qemu-de...@nongnu.org Developers
> ; Qemu-block 
> Subject: Re: [RFC PATCH 09/15] sd: emmc: Add support for emmc erase
> 
> On Thu, Feb 11, 2021 at 12:19 AM Sai Pavan Boddu
>  wrote:
> >
> > Add CMD35 and CMD36 which sets the erase start and end.
> >
> > Signed-off-by: Sai Pavan Boddu 
> > Signed-off-by: Edgar E. Iglesias 
> > ---
> >  hw/sd/sd.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> > index 236f2b8..7aab647 100644
> > --- a/hw/sd/sd.c
> > +++ b/hw/sd/sd.c
> > @@ -1544,6 +1544,7 @@ static sd_rsp_type_t sd_normal_command(SDState
> > *sd, SDRequest req)
> >
> >  /* Erase commands (Class 5) */
> >  case 32:   /* CMD32:  ERASE_WR_BLK_START */
> > +case 35:
> 
> Can you comment the CMD here?
[Sai Pavan Boddu] Sure I will update this.

Regards,
Sai Pavan
> 
> >  switch (sd->state) {
> >  case sd_transfer_state:
> >  sd->erase_start = req.arg; @@ -1555,6 +1556,7 @@ static
> > sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)
> >  break;
> >
> >  case 33:   /* CMD33:  ERASE_WR_BLK_END */
> > +case 36:
> 
> and here?
> 
> Alistair
> 
> >  switch (sd->state) {
> >  case sd_transfer_state:
> >  sd->erase_end = req.arg;
> > --
> > 2.7.4
> >
> >

Re: [RFC PATCH 09/15] sd: emmc: Add support for emmc erase

[Alistair Francis]

On Thu, Feb 11, 2021 at 12:19 AM Sai Pavan Boddu
 wrote:
>
> Add CMD35 and CMD36 which sets the erase start and end.
>
> Signed-off-by: Sai Pavan Boddu 
> Signed-off-by: Edgar E. Iglesias 
> ---
>  hw/sd/sd.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 236f2b8..7aab647 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -1544,6 +1544,7 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, 
> SDRequest req)
>
>  /* Erase commands (Class 5) */
>  case 32:   /* CMD32:  ERASE_WR_BLK_START */
> +case 35:

Can you comment the CMD here?

>  switch (sd->state) {
>  case sd_transfer_state:
>  sd->erase_start = req.arg;
> @@ -1555,6 +1556,7 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, 
> SDRequest req)
>  break;
>
>  case 33:   /* CMD33:  ERASE_WR_BLK_END */
> +case 36:

and here?

Alistair

>  switch (sd->state) {
>  case sd_transfer_state:
>  sd->erase_end = req.arg;
> --
> 2.7.4
>
>

[RFC PATCH 09/15] sd: emmc: Add support for emmc erase

[Sai Pavan Boddu]

Add CMD35 and CMD36 which sets the erase start and end.

Signed-off-by: Sai Pavan Boddu 
Signed-off-by: Edgar E. Iglesias 
---
 hw/sd/sd.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 236f2b8..7aab647 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -1544,6 +1544,7 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, 
SDRequest req)
 
 /* Erase commands (Class 5) */
 case 32:   /* CMD32:  ERASE_WR_BLK_START */
+case 35:
 switch (sd->state) {
 case sd_transfer_state:
 sd->erase_start = req.arg;
@@ -1555,6 +1556,7 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, 
SDRequest req)
 break;
 
 case 33:   /* CMD33:  ERASE_WR_BLK_END */
+case 36:
 switch (sd->state) {
 case sd_transfer_state:
 sd->erase_end = req.arg;
-- 
2.7.4