Re: [PATCH 00/14] deprecations: remove many old deprecations
On Wed, Feb 24, 2021 at 04:21:13PM +0100, Philippe Mathieu-Daudé wrote:
> On 2/24/21 3:38 PM, Peter Maydell wrote:
> > On Wed, 24 Feb 2021 at 13:21, Daniel P. Berrangé
> > wrote:
> >>
> >> The following features have been deprecated for well over the 2
> >> release cycle we promise
> >>
> >> ``-usbdevice`` (since 2.10.0)
> >> ``-drive file=3Djson:{...{'driver':'file'}}`` (since 3.0)
> >> ``-vnc acl`` (since 4.0.0)
> >> ``-mon ...,control=3Dreadline,pretty=3Don|off`` (since 4.1)
> >
> > Are the literal '=3D' here intended ?
>
> No, this is a git-publish bug:
> https://github.com/stefanha/git-publish/issues/88
>
> Apparently the fix is not yet backported to Fedora.
Thanks for reminding me. I'll roll a new git-publish release and package
it in Fedora.
Stefan
signature.asc
Description: PGP signature
Re: [PATCH 00/14] deprecations: remove many old deprecations
Am 25.02.2021 um 18:32 hat Jim Fehlig geschrieben:
> Adding xen-devel and Ian to cc.
>
> On 2/24/21 6:11 AM, Daniel P. Berrangé wrote:
> > The following features have been deprecated for well over the 2
> > release cycle we promise
>
> This reminded me of a bug report we received late last year when updating to
> 5.2.0. 'virsh setvcpus' suddenly stopped working for Xen HVM guests. Turns
> out libxl uses cpu-add under the covers.
>
> >
> >``-usbdevice`` (since 2.10.0)
> >``-drive file=3Djson:{...{'driver':'file'}}`` (since 3.0)
> >``-vnc acl`` (since 4.0.0)
> >``-mon ...,control=3Dreadline,pretty=3Don|off`` (since 4.1)
> >``migrate_set_downtime`` and ``migrate_set_speed`` (since 2.8.0)
> >``query-named-block-nodes`` result ``encryption_key_missing`` (since
> > 2.10.0)
> >``query-block`` result ``inserted.encryption_key_missing`` (since 2.10.0)
> >``migrate-set-cache-size`` and ``query-migrate-cache-size`` (since
> > 2.11.0)
> >``query-named-block-nodes`` and ``query-block`` result
> > dirty-bitmaps[i].sta=
> > tus (ince 4.0)
> >``query-cpus`` (since 2.12.0)
> >``query-cpus-fast`` ``arch`` output member (since 3.0.0)
> >``query-events`` (since 4.0)
> >chardev client socket with ``wait`` option (since 4.0)
> >``acl_show``, ``acl_reset``, ``acl_policy``, ``acl_add``, ``acl_remove``
> > (s=
> > ince 4.0.0)
> >``ide-drive`` (since 4.2)
> >``scsi-disk`` (since 4.2)
> >
> > AFAICT, libvirt has ceased to use all of these too.
>
> A quick grep of the libxl code shows it uses -usbdevice, query-cpus, and
> scsi-disk.
>
> > There are many more similarly old deprecations not (yet) tackled.
>
> The Xen tools maintainers will need to be more vigilant of the deprecations.
> I don't follow Xen development close enough to know if this topic has
> already been discussed.
MAINTAINERS has a section for "Incompatible changes" that covers
docs/system/deprecated.rst. Maybe if the Xen maintainers are interested
in that, we could add another list or individual people there so they
would see patches that deprecate something?
But either way, it would probably be useful to check the full
deprecation list rather than just what we're going to remove right now.
Kevin
Re: [PATCH 00/14] deprecations: remove many old deprecations
Adding xen-devel and Ian to cc.
On 2/24/21 6:11 AM, Daniel P. Berrangé wrote:
The following features have been deprecated for well over the 2
release cycle we promise
This reminded me of a bug report we received late last year when updating to
5.2.0. 'virsh setvcpus' suddenly stopped working for Xen HVM guests. Turns out
libxl uses cpu-add under the covers.
``-usbdevice`` (since 2.10.0)
``-drive file=3Djson:{...{'driver':'file'}}`` (since 3.0)
``-vnc acl`` (since 4.0.0)
``-mon ...,control=3Dreadline,pretty=3Don|off`` (since 4.1)
``migrate_set_downtime`` and ``migrate_set_speed`` (since 2.8.0)
``query-named-block-nodes`` result ``encryption_key_missing`` (since 2.10.0)
``query-block`` result ``inserted.encryption_key_missing`` (since 2.10.0)
``migrate-set-cache-size`` and ``query-migrate-cache-size`` (since 2.11.0)
``query-named-block-nodes`` and ``query-block`` result dirty-bitmaps[i].sta=
tus (ince 4.0)
``query-cpus`` (since 2.12.0)
``query-cpus-fast`` ``arch`` output member (since 3.0.0)
``query-events`` (since 4.0)
chardev client socket with ``wait`` option (since 4.0)
``acl_show``, ``acl_reset``, ``acl_policy``, ``acl_add``, ``acl_remove`` (s=
ince 4.0.0)
``ide-drive`` (since 4.2)
``scsi-disk`` (since 4.2)
AFAICT, libvirt has ceased to use all of these too.
A quick grep of the libxl code shows it uses -usbdevice, query-cpus, and
scsi-disk.
There are many more similarly old deprecations not (yet) tackled.
The Xen tools maintainers will need to be more vigilant of the deprecations. I
don't follow Xen development close enough to know if this topic has already been
discussed.
Regards,
Jim
Re: [PATCH 00/14] deprecations: remove many old deprecations
On Wed, Feb 24, 2021 at 02:38:43PM +, Peter Maydell wrote:
> On Wed, 24 Feb 2021 at 13:21, Daniel P. Berrangé wrote:
> >
> > The following features have been deprecated for well over the 2
> > release cycle we promise
> >
> > ``-usbdevice`` (since 2.10.0)
> > ``-drive file=3Djson:{...{'driver':'file'}}`` (since 3.0)
> > ``-vnc acl`` (since 4.0.0)
> > ``-mon ...,control=3Dreadline,pretty=3Don|off`` (since 4.1)
>
> Are the literal '=3D' here intended ?
git-publish has done something wierd to the cover letter encoding that
I don't understand.
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
Re: [PATCH 00/14] deprecations: remove many old deprecations
On 2/24/21 3:38 PM, Peter Maydell wrote:
> On Wed, 24 Feb 2021 at 13:21, Daniel P. Berrangé wrote:
>>
>> The following features have been deprecated for well over the 2
>> release cycle we promise
>>
>> ``-usbdevice`` (since 2.10.0)
>> ``-drive file=3Djson:{...{'driver':'file'}}`` (since 3.0)
>> ``-vnc acl`` (since 4.0.0)
>> ``-mon ...,control=3Dreadline,pretty=3Don|off`` (since 4.1)
>
> Are the literal '=3D' here intended ?
No, this is a git-publish bug:
https://github.com/stefanha/git-publish/issues/88
Apparently the fix is not yet backported to Fedora.
Re: [PATCH 00/14] deprecations: remove many old deprecations
On Wed, 24 Feb 2021 at 13:21, Daniel P. Berrangé wrote:
>
> The following features have been deprecated for well over the 2
> release cycle we promise
>
> ``-usbdevice`` (since 2.10.0)
> ``-drive file=3Djson:{...{'driver':'file'}}`` (since 3.0)
> ``-vnc acl`` (since 4.0.0)
> ``-mon ...,control=3Dreadline,pretty=3Don|off`` (since 4.1)
Are the literal '=3D' here intended ?
thanks
-- PMM
Re: [PATCH 00/14] deprecations: remove many old deprecations
On 24/02/21 14:11, Daniel P. Berrangé wrote:
The following features have been deprecated for well over the 2
release cycle we promise
``-usbdevice`` (since 2.10.0)
``-drive file=3Djson:{...{'driver':'file'}}`` (since 3.0)
``-vnc acl`` (since 4.0.0)
``-mon ...,control=3Dreadline,pretty=3Don|off`` (since 4.1)
``migrate_set_downtime`` and ``migrate_set_speed`` (since 2.8.0)
``query-named-block-nodes`` result ``encryption_key_missing`` (since 2.10.0)
``query-block`` result ``inserted.encryption_key_missing`` (since 2.10.0)
``migrate-set-cache-size`` and ``query-migrate-cache-size`` (since 2.11.0)
``query-named-block-nodes`` and ``query-block`` result dirty-bitmaps[i].sta=
tus (ince 4.0)
``query-cpus`` (since 2.12.0)
``query-cpus-fast`` ``arch`` output member (since 3.0.0)
``query-events`` (since 4.0)
chardev client socket with ``wait`` option (since 4.0)
``acl_show``, ``acl_reset``, ``acl_policy``, ``acl_add``, ``acl_remove`` (s=
ince 4.0.0)
``ide-drive`` (since 4.2)
``scsi-disk`` (since 4.2)
AFAICT, libvirt has ceased to use all of these too.
No objections except possibly for -usbdevice.
Paolo
