Re: [PATCH 13/15] iotests: remove qemu_io_pipe_and_status()
On Tue, Mar 22, 2022 at 12:39 PM Hanna Reitz wrote: > > On 18.03.22 21:36, John Snow wrote: > > I know we just added it, sorry. This is done in favor of qemu_io() which > > *also* returns the console output and status, but with more robust error > > handling on failure. > > > > Signed-off-by: John Snow > > --- > > tests/qemu-iotests/iotests.py | 3 --- > > tests/qemu-iotests/tests/image-fleecing | 12 +++- > > 2 files changed, 3 insertions(+), 12 deletions(-) > > Reviewed-by: Hanna Reitz I goofed this patch -- some of the failures in this test are expected and this patch breaks the test. Dropping the R-Bs. v2 will explain what's up in the commit message. --js
Re: [PATCH 13/15] iotests: remove qemu_io_pipe_and_status()
On 18.03.22 21:36, John Snow wrote: I know we just added it, sorry. This is done in favor of qemu_io() which *also* returns the console output and status, but with more robust error handling on failure. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 3 --- tests/qemu-iotests/tests/image-fleecing | 12 +++- 2 files changed, 3 insertions(+), 12 deletions(-) Reviewed-by: Hanna Reitz
Re: [PATCH 13/15] iotests: remove qemu_io_pipe_and_status()
On Fri, Mar 18, 2022 at 04:36:53PM -0400, John Snow wrote: > I know we just added it, sorry. This is done in favor of qemu_io() which > *also* returns the console output and status, but with more robust error > handling on failure. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/iotests.py | 3 --- > tests/qemu-iotests/tests/image-fleecing | 12 +++- > 2 files changed, 3 insertions(+), 12 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
