Re: [PATCH 3/4] migrate-bitmaps-test: Fix pylint warnings

[Vladimir Sementsov-Ogievskiy]

29.03.2021 16:26, Max Reitz wrote:

There are a couple of things pylint takes issue with:
- The "time" import is unused
- The import order (iotests should come last)
- get_bitmap_hash() doesn't use @self and so should be a function
- Semicolons at the end of some lines


Wow that's funny :) My old good code :)


- Parentheses after "if"
- Some lines are too long (80 characters instead of 79)
- inject_test_case()'s @name parameter shadows a top-level @name
   variable
- "lambda self: mc(self)" is equivalent to just "mc"
- Always put two empty lines after a function
- f'exec: cat > /dev/null' does not need to be an f-string

Fix them.

Signed-off-by: Max Reitz 


Thanks a lot!

Reviewed-by: Vladimir Sementsov-Ogievskiy 

--
Best regards,
Vladimir

Re: [PATCH 3/4] migrate-bitmaps-test: Fix pylint warnings

[Willian Rampazzo]

On Mon, Mar 29, 2021 at 10:28 AM Max Reitz  wrote:
>
> There are a couple of things pylint takes issue with:
> - The "time" import is unused
> - The import order (iotests should come last)
> - get_bitmap_hash() doesn't use @self and so should be a function
> - Semicolons at the end of some lines
> - Parentheses after "if"
> - Some lines are too long (80 characters instead of 79)
> - inject_test_case()'s @name parameter shadows a top-level @name
>   variable
> - "lambda self: mc(self)" is equivalent to just "mc"
> - Always put two empty lines after a function
> - f'exec: cat > /dev/null' does not need to be an f-string
>
> Fix them.
>
> Signed-off-by: Max Reitz 
> ---
>  tests/qemu-iotests/tests/migrate-bitmaps-test | 38 ++-
>  1 file changed, 20 insertions(+), 18 deletions(-)
>

Reviewed-by: Willian Rampazzo