Re: [PATCH v2 24/25] python: re-enable pylint duplicate-code warnings

2021-12-16 Thread Beraldo Leal
On Wed, Dec 15, 2021 at 02:39:38PM -0500, John Snow wrote:
> With the old library gone, there's nothing duplicated in the tree, so
> the warning suppression can be removed.
> 
> Signed-off-by: John Snow 
> ---
>  python/setup.cfg | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/python/setup.cfg b/python/setup.cfg
> index 5140a5b322..c341e922c2 100644
> --- a/python/setup.cfg
> +++ b/python/setup.cfg
> @@ -114,7 +114,6 @@ ignore_missing_imports = True
>  disable=consider-using-f-string,
>  too-many-function-args,  # mypy handles this with less false 
> positives.
>  no-member,  # mypy also handles this better.
> -duplicate-code,  # To be removed by the end of this patch series.
>  
>  [pylint.basic]
>  # Good variable names which should always be accepted, separated by a comma.

Reviewed-by: Beraldo Leal 

--
Beraldo




Re: [PATCH v2 24/25] python: re-enable pylint duplicate-code warnings

2021-12-16 Thread Vladimir Sementsov-Ogievskiy

15.12.2021 22:39, John Snow wrote:

With the old library gone, there's nothing duplicated in the tree, so
the warning suppression can be removed.

Signed-off-by: John Snow


Reviewed-by: Vladimir Sementsov-Ogievskiy 

--
Best regards,
Vladimir