On 15/5/24 10:43, Gerd Hoffmann wrote:
Move the pflash_blk_write_start() call.  We need the offset of the
first data write, not the offset for the setup (number-of-bytes)
write.  Without this fix u-boot can do block writes to the first
flash block only.

Wow, that is a fast fix :) Thanks!

While being at it drop a leftover FIXME.

Resolves: #2343
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2343

I suppose we also need:
Cc: qemu-sta...@nongnu.org

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>

Fixes: fcc79f2e0955 ("hw/pflash: implement update buffer for block writes")
Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
---
  hw/block/pflash_cfi01.c | 8 +++-----
  1 file changed, 3 insertions(+), 5 deletions(-)


Reply via email to