Re: [PATCH v4 3/6] iotests: Test 183 does not work on macOS and OpenBSD
On 02.12.19 11:10, Thomas Huth wrote: > In the long term, we might want to add test 183 to the "auto" group > (but it still fails occasionally, so we cannot do that yet). However, > when running 183 in Cirrus-CI on macOS, or with our vm-build-openbsd > target, it currently always fails with an "Timeout waiting for return > on handle 0" error. > > Let's mark it as supported only on systems where the test is working > fine (i.e. Linux, FreeBSD and NetBSD). > > Signed-off-by: Thomas Huth > --- > tests/qemu-iotests/183 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qemu-iotests/183 b/tests/qemu-iotests/183 > index bced83fae0..0bbae13647 100755 > --- a/tests/qemu-iotests/183 > +++ b/tests/qemu-iotests/183 > @@ -42,6 +42,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > . ./common.filter > . ./common.qemu > > +_supported_os Linux FreeBSD NetBSD I don’t suppose you have data on OpenBSD? (And maybe it would be best to let _unsupported_os just check whether $HOSTOS contains any of these strings (ideally in a case-insensitive way) instead of checking for equality, but that’s for another series to decide.) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature
Re: [PATCH v4 3/6] iotests: Test 183 does not work on macOS and OpenBSD
On 20/01/2020 15.36, Max Reitz wrote: > On 02.12.19 11:10, Thomas Huth wrote: >> In the long term, we might want to add test 183 to the "auto" group >> (but it still fails occasionally, so we cannot do that yet). However, >> when running 183 in Cirrus-CI on macOS, or with our vm-build-openbsd >> target, it currently always fails with an "Timeout waiting for return >> on handle 0" error. >> >> Let's mark it as supported only on systems where the test is working >> fine (i.e. Linux, FreeBSD and NetBSD). >> >> Signed-off-by: Thomas Huth >> --- >> tests/qemu-iotests/183 | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tests/qemu-iotests/183 b/tests/qemu-iotests/183 >> index bced83fae0..0bbae13647 100755 >> --- a/tests/qemu-iotests/183 >> +++ b/tests/qemu-iotests/183 >> @@ -42,6 +42,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 >> . ./common.filter >> . ./common.qemu >> >> +_supported_os Linux FreeBSD NetBSD > > I don’t suppose you have data on OpenBSD? I've checked it with our "make vm-build-openbsd" target (see patch description) and it was failing there in the same way as on macOS. > Reviewed-by: Max Reitz Thanks! Thomas
