Re: [PATCH v7 21/21] scripts/simplebench: add bench_prealloc.py

2020-11-13 Thread Max Reitz

On 13.11.20 19:00, Vladimir Sementsov-Ogievskiy wrote:

13.11.2020 19:24, Max Reitz wrote:

On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote:

Benchmark for new preallocate filter.

Example usage:
 ./bench_prealloc.py ../../build/qemu-img \
 ssd-ext4:/path/to/mount/point \
 ssd-xfs:/path2 hdd-ext4:/path3 hdd-xfs:/path4

The benchmark shows performance improvement (or degradation) when use
new preallocate filter with qcow2 image.

Signed-off-by: Vladimir Sementsov-Ogievskiy 
---
  scripts/simplebench/bench_prealloc.py | 132 ++
  1 file changed, 132 insertions(+)
  create mode 100755 scripts/simplebench/bench_prealloc.py


Reviewed-by: Max Reitz 




Thanks for reviewing! Could you take this all through you tree?


Sure, if you can live with the fact that I’ll be on PTO for the next two 
weeks :)


(Shouldn’t matter for block-next, as 5.2 won’t be released until December.)

Max




Re: [PATCH v7 21/21] scripts/simplebench: add bench_prealloc.py

2020-11-13 Thread Vladimir Sementsov-Ogievskiy

13.11.2020 19:24, Max Reitz wrote:

On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote:

Benchmark for new preallocate filter.

Example usage:
 ./bench_prealloc.py ../../build/qemu-img \
 ssd-ext4:/path/to/mount/point \
 ssd-xfs:/path2 hdd-ext4:/path3 hdd-xfs:/path4

The benchmark shows performance improvement (or degradation) when use
new preallocate filter with qcow2 image.

Signed-off-by: Vladimir Sementsov-Ogievskiy 
---
  scripts/simplebench/bench_prealloc.py | 132 ++
  1 file changed, 132 insertions(+)
  create mode 100755 scripts/simplebench/bench_prealloc.py


Reviewed-by: Max Reitz 




Thanks for reviewing! Could you take this all through you tree?

--
Best regards,
Vladimir



Re: [PATCH v7 21/21] scripts/simplebench: add bench_prealloc.py

2020-11-13 Thread Max Reitz

On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote:

Benchmark for new preallocate filter.

Example usage:
 ./bench_prealloc.py ../../build/qemu-img \
 ssd-ext4:/path/to/mount/point \
 ssd-xfs:/path2 hdd-ext4:/path3 hdd-xfs:/path4

The benchmark shows performance improvement (or degradation) when use
new preallocate filter with qcow2 image.

Signed-off-by: Vladimir Sementsov-Ogievskiy 
---
  scripts/simplebench/bench_prealloc.py | 132 ++
  1 file changed, 132 insertions(+)
  create mode 100755 scripts/simplebench/bench_prealloc.py


Reviewed-by: Max Reitz