Re: [PATCH v7 3/4] qapi: add filter-node-name to block-stream

[Andrey Shinkevich]

On 25.08.2020 09:37, Markus Armbruster wrote:

Andrey Shinkevich  writes:


Provide the possibility to pass the 'filter-node-name' parameter to the
block-stream job as it is done for the commit block job.

Signed-off-by: Andrey Shinkevich 
Reviewed-by: Vladimir Sementsov-Ogievskiy 

[...]

diff --git a/qapi/block-core.json b/qapi/block-core.json
index 0b8ccd3..1db6ce1 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2524,6 +2524,11 @@
  #'stop' and 'enospc' can only be used if the block device
  #supports io-status (see BlockInfo).  Since 1.3.
  #
+# @filter-node-name: the node name that should be assigned to the
+#filter driver that the stream job inserts into the graph
+#above @device. If this option is not given, a node name is
+#autogenerated. (Since: 5.1)

It's (Since: 5.2) now.



Well noted, Markus, thank you.

Andrey





+#
  # @auto-finalize: When false, this job will wait in a PENDING state after it 
has
  # finished its work, waiting for @block-job-finalize before
  # making any block graph changes.
@@ -2554,6 +2559,7 @@
'data': { '*job-id': 'str', 'device': 'str', '*base': 'str',
  '*base-node': 'str', '*backing-file': 'str', '*speed': 'int',
  '*on-error': 'BlockdevOnError',
+'*filter-node-name': 'str',
  '*auto-finalize': 'bool', '*auto-dismiss': 'bool' } }
  
  ##

Re: [PATCH v7 3/4] qapi: add filter-node-name to block-stream

[Markus Armbruster]

Andrey Shinkevich  writes:

> Provide the possibility to pass the 'filter-node-name' parameter to the
> block-stream job as it is done for the commit block job.
>
> Signed-off-by: Andrey Shinkevich 
> Reviewed-by: Vladimir Sementsov-Ogievskiy 
[...]
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 0b8ccd3..1db6ce1 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2524,6 +2524,11 @@
>  #'stop' and 'enospc' can only be used if the block device
>  #supports io-status (see BlockInfo).  Since 1.3.
>  #
> +# @filter-node-name: the node name that should be assigned to the
> +#filter driver that the stream job inserts into the graph
> +#above @device. If this option is not given, a node name 
> is
> +#autogenerated. (Since: 5.1)

It's (Since: 5.2) now.

> +#
>  # @auto-finalize: When false, this job will wait in a PENDING state after it 
> has
>  # finished its work, waiting for @block-job-finalize before
>  # making any block graph changes.
> @@ -2554,6 +2559,7 @@
>'data': { '*job-id': 'str', 'device': 'str', '*base': 'str',
>  '*base-node': 'str', '*backing-file': 'str', '*speed': 'int',
>  '*on-error': 'BlockdevOnError',
> +'*filter-node-name': 'str',
>  '*auto-finalize': 'bool', '*auto-dismiss': 'bool' } }
>  
>  ##