Re: [Qemu-block] [Qemu-devel] [PATCH for-2.12] qemu-pr-helper: Actually allow users to specify pidfile
On 24/03/2018 12:46, Eric Blake wrote: > On 03/24/2018 12:14 AM, Michal Privoznik wrote: >> Due to wrong specification of arguments to getopt_long() any >> attempt to set pidfile resulted in: >> >> 1) the default to be leaked >> 2) the @pidfile variable to be set to NULL (because optarg is >> NULL without this patch). > > Broken since the introduction in commit b855f8d, in 2.11 (documentation > has always mentioned the argument, code has never supported it). Queued, thanks. Paolo >> >> Signed-off-by: Michal Privoznik > > CC: qemu-sta...@nongnu.org > Reviewed-by: Eric Blake >
Re: [Qemu-block] [Qemu-devel] [PATCH for-2.12] qemu-pr-helper: Actually allow users to specify pidfile
On 03/24/2018 12:14 AM, Michal Privoznik wrote: Due to wrong specification of arguments to getopt_long() any attempt to set pidfile resulted in: 1) the default to be leaked 2) the @pidfile variable to be set to NULL (because optarg is NULL without this patch). Broken since the introduction in commit b855f8d, in 2.11 (documentation has always mentioned the argument, code has never supported it). Signed-off-by: Michal Privoznik CC: qemu-sta...@nongnu.org Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
