[Qemu-devel] [PATCH] qemu-dm monitor doesn't support the quit command.
Hi All, It is natural that there is quit command in original QEMU. However, I don't think that the HVM domain on Xen is necessary. Because there is a possibility of shutting down GuestOS due to the mistake. I think that I should prohibit the quit command of qemu-dm. Thanks -- Takanori Kasai qemu-monitor-quit.patch Description: Binary data ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
[Qemu-devel] Re: [PATCH] qemu-dm monitor doesn't support the quit command.
Hi All, Sorry, I made a mistake in the address of mail. Please annul it. Thanks -- Takanori Kasai - Original Message - From: Kasai Takanori [EMAIL PROTECTED] To: qemu-devel qemu-devel@nongnu.org Sent: Friday, December 22, 2006 9:59 PM Subject: [PATCH] qemu-dm monitor doesn't support the quit command. Hi All, It is natural that there is quit command in original QEMU. However, I don't think that the HVM domain on Xen is necessary. Because there is a possibility of shutting down GuestOS due to the mistake. I think that I should prohibit the quit command of qemu-dm. Thanks -- Takanori Kasai ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
[Qemu-devel] qemu block.c monitor.c qemu-img.c vl.h
CVSROOT:/sources/qemu Module name:qemu Changes by: Thiemo Seufer ths 06/12/22 14:11:32 Modified files: . : block.c monitor.c qemu-img.c vl.h Log message: Escape filname printout properly, by Anthony Liguori and Julian Seward. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/block.c?cvsroot=qemur1=1.37r2=1.38 http://cvs.savannah.gnu.org/viewcvs/qemu/monitor.c?cvsroot=qemur1=1.57r2=1.58 http://cvs.savannah.gnu.org/viewcvs/qemu/qemu-img.c?cvsroot=qemur1=1.13r2=1.14 http://cvs.savannah.gnu.org/viewcvs/qemu/vl.h?cvsroot=qemur1=1.157r2=1.158 ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
[Qemu-devel] qemu block-raw.c
CVSROOT:/sources/qemu Module name:qemu Changes by: Thiemo Seufer ths 06/12/22 14:19:53 Modified files: . : block-raw.c Log message: Build fix for AIO (-dummy) on Windows, by Stefan Weil. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/block-raw.c?cvsroot=qemur1=1.11r2=1.12 ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
[Qemu-devel] qemu qemu-doc.texi vl.c vl.h hw/pc.c
CVSROOT:/sources/qemu Module name:qemu Changes by: Thiemo Seufer ths 06/12/22 16:34:12 Modified files: . : qemu-doc.texi vl.c vl.h hw : pc.c Log message: SCSI emulation improvements, by Chuck Brazie. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/qemu-doc.texi?cvsroot=qemur1=1.116r2=1.117 http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemur1=1.222r2=1.223 http://cvs.savannah.gnu.org/viewcvs/qemu/vl.h?cvsroot=qemur1=1.158r2=1.159 http://cvs.savannah.gnu.org/viewcvs/qemu/hw/pc.c?cvsroot=qemur1=1.63r2=1.64 ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
[Qemu-devel] qemu vl.c
CVSROOT:/sources/qemu Module name:qemu Changes by: Thiemo Seufer ths 06/12/22 17:29:05 Modified files: . : vl.c Log message: Fix -cdrom breakage. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemur1=1.223r2=1.224 ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
Re: [Qemu-devel] Question/problems with Qemu and 64Bit Opensuse 10.2
Werner Dittmann wrote: Just forgot to give the info about my system: Qemu was built and runs on a Suse 10.1 64 bit system (AMD CPU). Also, while compiling Qemu I got quite some warning about casting pointers to integer of different size (64bit vs 32 bit). Is this ok? I'm using Fedora Core 5 x86_64 with qemu 0.8.2 and I have noticed these warnings as well. However, they do not seem to be a problem, at least for what I'm currently doing, developing a new system on top of qemu. They seem to be casts from void * to int, which is OK on x86 but generate a warning on x86_64 since sizeof(void *) != sizeof(int) on that platform. I other words, I doubt that these warnings are the source of the problem. Regards, Jonathan Regards, Werner Werner Dittmann wrote: All, currently I'm trying to install an Opensuse 10.2 64Bit version in Qemu. Using a plain 0.82 didn't work out, after the Install screen Qemu goes in a loop. I've tried several parameters (witout net, ACPI, kqemu, etc). I could not even stop Qemu but had to use kill -9 . Because of some mail in the list that reported similar errors I downloaded the latest CVS version and built it using a gcc 3.3. That didn't solve the problem: It seems to be in a loop but I can close the qemu window and the window also grabs the mouse cursor (that was not the case with the 0.8.2 version). After loading the kernel I get the following message on the console (only in VESA mode): Decompressing Linux ... done. Booting the kernel. and at the bottom of the console screen the message (without the qutes): kernel direct mapping tables up to 1 @ 8000-d000 I tried to switch on some -d but I don't know which one is relevant here. I tried -d int but this produced about 90MB log data in just some seconds. Which info do you need to get down to the problem? What can I try to tackle the problem? Regards, Werner PS: Because I'm somewhat experienced with security software I would ask if there is any interest to have a TPM module (Software based TPM) for Qemu that looks like a real HW TPM according the the TPM specs? If yes I would start to look how to do it for Qemu. There is a software based TPM avaliable with a GPL licence. The only thing to do would be to wrap it with the HW interface functions (it's a memory mapped interface) so that standard drivers would see it as standard TPM module. Werner ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
[Qemu-devel] Out of the office.
I will be out of the office starting 12/22/2006 and will not return until 01/01/2007. Wish you Happy Holidays and Happy new Year. Marco ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
[Qemu-devel] qemu vl.c
CVSROOT:/sources/qemu Module name:qemu Changes by: Thiemo Seufer ths 06/12/22 19:25:31 Modified files: . : vl.c Log message: Support for unidirectional pipes, by Ed Swierk. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemur1=1.224r2=1.225 ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
[Qemu-devel] patch for supporting SMB on Solaris host
Seeing as there is some working going on in the Solaris QEMU port again, here's a real short patch to support Samba working on a Solaris Host. --- qemu-ORIG/vl.c 2006-12-22 12:29:05.0 -0500 +++ qemu/vl.c 2006-12-22 14:22:17.338815000 -0500 @@ -3069,8 +3069,13 @@ fclose(f); atexit(smb_exit); +#ifdef __sun__ +snprintf(smb_cmdline, sizeof(smb_cmdline), /bin/env LC_ALL=C /usr/sfw/sbin/smbd -s %s, + smb_conf); +#else snprintf(smb_cmdline, sizeof(smb_cmdline), /usr/sbin/smbd -s %s, smb_conf); +#endif slirp_add_exec(0, smb_cmdline, 4, 139); } ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
Re: [Qemu-devel][PATCH] qemu vl.c
Windows needs a patch for vl.c to compile (conditional compilation).
It does not know struct sockaddr_un.
The patch given below also fixes a debug message text and declares
some local functions to be static. This part is optional of course.
Regards and happy Christmas
Stefan Weil
Index: vl.c
===
RCS file: /sources/qemu/qemu/vl.c,v
retrieving revision 1.225
diff -u -b -B -u -r1.225 vl.c
--- vl.c22 Dec 2006 19:25:31 -1.225
+++ vl.c22 Dec 2006 20:14:41 -
@@ -281,7 +281,7 @@
for(i = start; i start + length; i += size) {
ioport_write_table[bsize][i] = func;
if (ioport_opaque[i] != NULL ioport_opaque[i] != opaque)
-hw_error(register_ioport_read: invalid opaque);
+hw_error(register_ioport_write: invalid opaque);
ioport_opaque[i] = opaque;
}
return 0;
@@ -1096,7 +1096,7 @@
{
}
-CharDriverState *qemu_chr_open_null(void)
+static CharDriverState *qemu_chr_open_null(void)
{
CharDriverState *chr;
@@ -1264,7 +1264,7 @@
}
/* open a character device to a unix fd */
-CharDriverState *qemu_chr_open_fd(int fd_in, int fd_out)
+static CharDriverState *qemu_chr_open_fd(int fd_in, int fd_out)
{
CharDriverState *chr;
FDCharDriver *s;
@@ -1285,7 +1285,7 @@
return chr;
}
-CharDriverState *qemu_chr_open_file_out(const char *file_out)
+static CharDriverState *qemu_chr_open_file_out(const char *file_out)
{
int fd_out;
@@ -1295,7 +1295,7 @@
return qemu_chr_open_fd(-1, fd_out);
}
-CharDriverState *qemu_chr_open_pipe(const char *filename)
+static CharDriverState *qemu_chr_open_pipe(const char *filename)
{
int fd_in, fd_out;
char filename_in[256], filename_out[256];
@@ -1520,7 +1520,7 @@
fcntl(0, F_SETFL, O_NONBLOCK);
}
-CharDriverState *qemu_chr_open_stdio(void)
+static CharDriverState *qemu_chr_open_stdio(void)
{
CharDriverState *chr;
@@ -1546,7 +1546,7 @@
}
#if defined(__linux__)
-CharDriverState *qemu_chr_open_pty(void)
+static CharDriverState *qemu_chr_open_pty(void)
{
struct termios tty;
char slave_name[1024];
@@ -1685,7 +1685,7 @@
return 0;
}
-CharDriverState *qemu_chr_open_tty(const char *filename)
+static CharDriverState *qemu_chr_open_tty(const char *filename)
{
CharDriverState *chr;
int fd;
@@ -1739,7 +1739,7 @@
return 0;
}
-CharDriverState *qemu_chr_open_pp(const char *filename)
+static CharDriverState *qemu_chr_open_pp(const char *filename)
{
CharDriverState *chr;
int fd;
@@ -1766,7 +1766,7 @@
}
#else
-CharDriverState *qemu_chr_open_pty(void)
+static CharDriverState *qemu_chr_open_pty(void)
{
return NULL;
}
@@ -1984,7 +1984,7 @@
s-win_opaque = opaque;
}
-CharDriverState *qemu_chr_open_win(const char *filename)
+static CharDriverState *qemu_chr_open_win(const char *filename)
{
CharDriverState *chr;
WinCharState *s;
@@ -2087,7 +2087,7 @@
}
-CharDriverState *qemu_chr_open_win_pipe(const char *filename)
+static CharDriverState *qemu_chr_open_win_pipe(const char *filename)
{
CharDriverState *chr;
WinCharState *s;
@@ -2113,7 +2113,7 @@
return chr;
}
-CharDriverState *qemu_chr_open_win_file(HANDLE fd_out)
+static CharDriverState *qemu_chr_open_win_file(HANDLE fd_out)
{
CharDriverState *chr;
WinCharState *s;
@@ -2133,7 +2133,7 @@
return chr;
}
-CharDriverState *qemu_chr_open_win_file_out(const char *file_out)
+static CharDriverState *qemu_chr_open_win_file_out(const char *file_out)
{
HANDLE fd_out;
@@ -2223,12 +2223,14 @@
}
int parse_host_port(struct sockaddr_in *saddr, const char *str);
-int parse_unix_path(struct sockaddr_un *uaddr, const char *str);
+#ifndef _WIN32
+static int parse_unix_path(struct sockaddr_un *uaddr, const char *str);
+#endif
int parse_host_src_port(struct sockaddr_in *haddr,
struct sockaddr_in *saddr,
const char *str);
-CharDriverState *qemu_chr_open_udp(const char *def)
+static CharDriverState *qemu_chr_open_udp(const char *def)
{
CharDriverState *chr = NULL;
NetCharDriver *s = NULL;
@@ -2818,7 +2820,8 @@
return 0;
}
-int parse_unix_path(struct sockaddr_un *uaddr, const char *str)
+#ifndef _WIN32
+static int parse_unix_path(struct sockaddr_un *uaddr, const char *str)
{
const char *p;
int len;
@@ -2835,6 +2838,7 @@
return 0;
}
+#endif
/* find or alloc a new VLAN */
VLANState *qemu_find_vlan(int id)
@@ -3691,7 +3695,7 @@
return 0;
}
-int net_client_init(const char *str)
+static int net_client_init(const char *str)
{
const char *p;
char *q;
@@ -5880,7 +5886,7 @@
*pre = re;
}
-void qemu_system_reset(void)
+static void qemu_system_reset(void)
{
QEMUResetEntry *re;
Thiemo Seufer schrieb:
CVSROOT: /sources/qemu
Module name: qemu
Changes by: Thiemo Seufer ths 06/12/22 19:25:31
Modified files:
. : vl.c
Log
[Qemu-devel] qemu vl.c
CVSROOT:/sources/qemu Module name:qemu Changes by: Thiemo Seufer ths 06/12/22 21:20:52 Modified files: . : vl.c Log message: Windows build fix, namespace cleanup, fix error message, by Stefan Weil. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemur1=1.225r2=1.226 ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
Re: [Qemu-devel][PATCH] qemu vl.c
Stefan Weil wrote: Windows needs a patch for vl.c to compile (conditional compilation). It does not know struct sockaddr_un. The patch given below also fixes a debug message text and declares some local functions to be static. This part is optional of course. Thanks, committed. Thiemo ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
Re: [Qemu-devel] patch for supporting SMB on Solaris host
On Friday 22 December 2006 20:07, Ben Taylor wrote: Seeing as there is some working going on in the Solaris QEMU port again, here's a real short patch to support Samba working on a Solaris Host. +#ifdef __sun__ +snprintf(smb_cmdline, sizeof(smb_cmdline), /bin/env LC_ALL=C /usr/sfw/sbin/smbd -s %s, + smb_conf); +#else Why does this have anything to do with solaris? Paul ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
Re: [Qemu-devel] patch for supporting SMB on Solaris host
On Friday 22 December 2006 21:29, Paul Brook wrote: On Friday 22 December 2006 20:07, Ben Taylor wrote: Seeing as there is some working going on in the Solaris QEMU port again, here's a real short patch to support Samba working on a Solaris Host. +#ifdef __sun__ +snprintf(smb_cmdline, sizeof(smb_cmdline), /bin/env LC_ALL=C /usr/sfw/sbin/smbd -s %s, + smb_conf); +#else Why does this have anything to do with solaris? Sorry, I was unclear. The /usr/swf bif is obviously a Solaris hack, and I think this is a bad way of implementing this. I don't see why the /bin/env LC_ALL bits have anything to do with Solaris. Paul ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
[Qemu-devel] [PATCH] make adb_pci.c buildable
Hi! pci_bridge_init() has 5 arguments, and pci_adb_init() is only providing 4, name is missing - patch attached Let's make it at least buildable. -- Kind Regards, Igor V. Kovalenko Index: hw/apb_pci.c === RCS file: /cvsroot/qemu/qemu/hw/apb_pci.c,v retrieving revision 1.3 diff -u -r1.3 apb_pci.c --- hw/apb_pci.c 24 Sep 2006 17:01:44 - 1.3 +++ hw/apb_pci.c 22 Dec 2006 22:02:29 - @@ -251,8 +251,8 @@ d-config[0x0E] = 0x00; // header_type /* APB secondary busses */ -secondary = pci_bridge_init(s-bus, 8, 0x108e5000, pci_apb_map_irq); -pci_bridge_init(s-bus, 9, 0x108e5000, pci_apb_map_irq); +secondary = pci_bridge_init(s-bus, 8, 0x108e5000, pci_apb_map_irq, Advanced PCI Bus secondary bridge 1); +pci_bridge_init(s-bus, 9, 0x108e5000, pci_apb_map_irq, Advanced PCI Bus secondary bridge 2); return secondary; } ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
[Qemu-devel] qemu/hw apb_pci.c
CVSROOT:/sources/qemu Module name:qemu Changes by: Paul Brook pbrook 06/12/22 22:35:25 Modified files: hw : apb_pci.c Log message: Sparc64 build fix (Igor Kovalenko). CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/hw/apb_pci.c?cvsroot=qemur1=1.3r2=1.4 ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
[Qemu-devel] qemu/slirp tcp.h
CVSROOT:/sources/qemu Module name:qemu Changes by: Thiemo Seufer ths 06/12/23 00:03:15 Modified files: slirp : tcp.h Log message: Fix build warning on Windows. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/slirp/tcp.h?cvsroot=qemur1=1.3r2=1.4 ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
Re: [Qemu-devel] patch for supporting SMB on Solaris host
Paul Brook [EMAIL PROTECTED] wrote: On Friday 22 December 2006 21:29, Paul Brook wrote: On Friday 22 December 2006 20:07, Ben Taylor wrote: Seeing as there is some working going on in the Solaris QEMU port again, here's a real short patch to support Samba working on a Solaris Host. +#ifdef __sun__ +snprintf(smb_cmdline, sizeof(smb_cmdline), /bin/env LC_ALL=C /usr/sfw/sbin/smbd -s %s, + smb_conf); +#else Why does this have anything to do with solaris? Sorry, I was unclear. The /usr/swf bif is obviously a Solaris hack, and I think this is a bad way of implementing this. Well, I suppose I can write a configure hack to replace to definte the smbd binary, which will take about 30 seconds, hoping you'll find that more digestable. I don't see why the /bin/env LC_ALL bits have anything to do with Solaris. Let me inject a little humor. I'm american and speak only one language. The guy who did the patch is in germany and did it for a reason, though he never explained to me. In meantime, I will resubmit the patch without the /bin/env LC_ALL bits, hopefully to your liking and if it breaks on Solaris for some other reason, I'll be able to argue with you why it needs to be there. ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
[Qemu-devel] qemu/hw mips_r4k.c
CVSROOT:/sources/qemu Module name:qemu Changes by: Thiemo Seufer ths 06/12/23 00:23:19 Modified files: hw : mips_r4k.c Log message: More serial ports for the mips machine. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/hw/mips_r4k.c?cvsroot=qemur1=1.26r2=1.27 ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
[Qemu-devel] qemu configure
CVSROOT:/sources/qemu Module name:qemu Changes by: Thiemo Seufer ths 06/12/23 00:33:27 Modified files: . : configure Log message: Fix spelling. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/configure?cvsroot=qemur1=1.113r2=1.114 ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
[Qemu-devel] qemu dyngen-exec.h target-mips/exec.h target-pp...
CVSROOT:/sources/qemu Module name:qemu Changes by: Thiemo Seufer ths 06/12/23 00:49:32 Modified files: . : dyngen-exec.h target-mips: exec.h target-ppc : exec.h Log message: Use memory barriers in FORCE_RET / RETURN. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/dyngen-exec.h?cvsroot=qemur1=1.29r2=1.30 http://cvs.savannah.gnu.org/viewcvs/qemu/target-mips/exec.h?cvsroot=qemur1=1.13r2=1.14 http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/exec.h?cvsroot=qemur1=1.13r2=1.14 ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
Re: [Qemu-devel] patch for supporting SMB on Solaris host
Paul Brook [EMAIL PROTECTED] wrote: On Friday 22 December 2006 21:29, Paul Brook wrote: On Friday 22 December 2006 20:07, Ben Taylor wrote: Seeing as there is some working going on in the Solaris QEMU port again, here's a real short patch to support Samba working on a Solaris Host. +#ifdef __sun__ +snprintf(smb_cmdline, sizeof(smb_cmdline), /bin/env LC_ALL=C /usr/sfw/sbin/smbd -s %s, + smb_conf); +#else Why does this have anything to do with solaris? Sorry, I was unclear. The /usr/swf bif is obviously a Solaris hack, and I think this is a bad way of implementing this. I don't see why the /bin/env LC_ALL bits have anything to do with Solaris. Hopefully, you find this patch to be more reasonable. Bendiff -ruN qemu-ORIG/configure qemu-smb/configure --- qemu-ORIG/configure 2006-12-18 22:31:34.0 -0500 +++ qemu-smb/configure 2006-12-22 19:15:05.710251000 -0500 @@ -30,6 +30,7 @@ install=install strip=strip cpu=`uname -m` +smbd=/usr/sbin/smbd target_list= case $cpu in i386|i486|i586|i686|i86pc|BePC) @@ -150,6 +151,7 @@ make=gmake install=ginstall solarisrev=`uname -r | cut -f2 -d.` +smbd=/usr/sfw/sbin/smbd fi # find source path @@ -579,6 +581,7 @@ echo Documentation $build_docs [ ! -z $uname_release ] \ echo uname -r $uname_release +echo smbd $smbd if test $sdl_too_old = yes; then echo - Your SDL version is too old - please upgrade to have SDL support @@ -613,6 +616,7 @@ echo CFLAGS=$CFLAGS $config_mak echo LDFLAGS=$LDFLAGS $config_mak echo EXESUF=$EXESUF $config_mak +echo #define SMBD_BINARY \$smbd\ $config_h if test $cpu = i386 ; then echo ARCH=i386 $config_mak echo #define HOST_I386 1 $config_h diff -ruN qemu-ORIG/vl.c qemu-smb/vl.c --- qemu-ORIG/vl.c 2006-12-22 12:29:05.0 -0500 +++ qemu-smb/vl.c 2006-12-22 19:11:08.010585000 -0500 @@ -3069,8 +3069,8 @@ fclose(f); atexit(smb_exit); -snprintf(smb_cmdline, sizeof(smb_cmdline), /usr/sbin/smbd -s %s, - smb_conf); +snprintf(smb_cmdline, sizeof(smb_cmdline), % -s %s, + SMBD_BINARY, smb_conf); slirp_add_exec(0, smb_cmdline, 4, 139); } ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
Re: [Qemu-devel] patch for supporting SMB on Solaris host
Paul Brook [EMAIL PROTECTED] wrote: On Friday 22 December 2006 21:29, Paul Brook wrote: On Friday 22 December 2006 20:07, Ben Taylor wrote: Seeing as there is some working going on in the Solaris QEMU port again, here's a real short patch to support Samba working on a Solaris Host. +#ifdef __sun__ +snprintf(smb_cmdline, sizeof(smb_cmdline), /bin/env LC_ALL=C /usr/sfw/sbin/smbd -s %s, + smb_conf); +#else Why does this have anything to do with solaris? Sorry, I was unclear. The /usr/swf bif is obviously a Solaris hack, and I think this is a bad way of implementing this. I don't see why the /bin/env LC_ALL bits have anything to do with Solaris. Hopefully, you find this patch to be more reasonable. Ben ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
Re: [Qemu-devel] patch for supporting SMB on Solaris host
On Fri, Dec 22, 2006 at 08:40:27PM -0500, Ben Taylor wrote: -snprintf(smb_cmdline, sizeof(smb_cmdline), /usr/sbin/smbd -s %s, - smb_conf); +snprintf(smb_cmdline, sizeof(smb_cmdline), % -s %s, + SMBD_BINARY, smb_conf); Doesn't look right to me? (s/%/%s/) ___ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
