[Qemu-devel] qemu translate-all.c tcg/tcg.c tcg/tcg.h
CVSROOT:/sources/qemu Module name:qemu Changes by: Paul Brook 08/02/10 02:41:15 Modified files: . : translate-all.c tcg: tcg.c tcg.h Log message: Fix TCG relocation bug (exposed by fault after brcond op). Add FIXME for annother potential bug. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/translate-all.c?cvsroot=qemu&r1=1.25&r2=1.26 http://cvs.savannah.gnu.org/viewcvs/qemu/tcg/tcg.c?cvsroot=qemu&r1=1.4&r2=1.5 http://cvs.savannah.gnu.org/viewcvs/qemu/tcg/tcg.h?cvsroot=qemu&r1=1.3&r2=1.4
Re: [Qemu-devel] Re: 2.6.24 says "serial8250: too much work for irq4" a lot.
Blue Swirl wrote: If you look at the patch, there are no timing dependencies; the only parameter is the depth of the virtual queue. The exhaustion is completely controlled by target OS access patterns. Thanks, this clarified the difference. But I'll rephrase my original comment: The patch looks OK, but the simulated FIFO exhaustion should benefit all devices, as discussed here: http://lists.gnu.org/archive/html/qemu-devel/2007-12/msg00283.html The difference is you *can't* do that in a general layer. -hpa
[Qemu-devel] USB support
Hi
I want to inform you that I successfully attached my Canon MP830
(printer, scanner, fax) to Qemu via USB.
It was not easy, I had to pass though two stoppages.
1. There is no support for multi port/config (do not know proper term
for that) USB devices in Qemu. Meaning that if single USB device
provides multiple functionalities (like printer, scanner, fax) it will
be rejected by Qemu.
Fortunately there is patch for that available on internet page
http://www.wina.at/uni/html/linux-qemu.html
(qemu-0.9.0-usb-multi-configs.patch).
2. When I applied the patch I hit another issue. When the USB device is
not ready it is automatically switched to HALT state (if I understood it
correctly) and additional ioctl USBDEVFS_CLEAR_HALT is required to give
device another chance. Thus, I have written patch for that issue. The
patch I am sending as attachment.
When I applied both patches, everything worked fine. I suggest to
include those two patches in Qemu.
Best regards
Marek Zelem
--
e-mail: [EMAIL PROTECTED]
web: http://marek.terminus.sk/
pgp key: http://marek.terminus.sk/gpg.txt
--- usb-linux.c.orig 2008-01-12 12:56:09.0 +0100
+++ usb-linux.c 2008-01-12 14:02:47.0 +0100
@@ -229,12 +229,14 @@
if (ret < 0) {
switch(errno) {
case ETIMEDOUT:
+ ret = ioctl(s->fd, USBDEVFS_CLEAR_HALT, &(bt.ep));
return USB_RET_NAK;
case EPIPE:
default:
#ifdef DEBUG
printf("handle_data: errno=%d\n", errno);
#endif
+ ret = ioctl(s->fd, USBDEVFS_CLEAR_HALT, &(bt.ep));
return USB_RET_STALL;
}
} else {
Re: Git/SVN/CVS? was Re: [Qemu-devel] What does code_copy_enabled do?
Hi, On Sat, 9 Feb 2008, Felipe Contreras wrote: > Right now I can't use qemu because a bug introduced in the last months > and with git-bisect I probably would be able to fix it myself. Just clone git://repo.or.cz/qemu.git, then. Hth, Dscho
Re: Git/SVN/CVS? was Re: [Qemu-devel] What does code_copy_enabled do?
On Feb 9, 2008 2:45 PM, Johannes Schindelin <[EMAIL PROTECTED]> wrote: > Hi, > > > On Sat, 9 Feb 2008, Blue Swirl wrote: > > > On 2/8/08, Rob Landley <[EMAIL PROTECTED]> wrote: > > > On Thursday 07 February 2008 21:52:33 Paul Brook wrote: > > > > On Friday 08 February 2008, Rob Landley wrote: > > > > > Grepping through the source code, I can find 3 places where this > > > > > global > > > > > variable is set (it's initialized to a default value of 1, there's > > > > > a "no-code-copy" command line option that sets it to zero, and then it > > > > > shows up in the test suite once). What I can't find is any code ever > > > > > actually checking or using the value put into this variable > > > > > > > > It got ripped out a while back. > > > > > > Any news on the possible cvs->svn migration? I'd submit a cleanup > > > patch to rip out the remaining traces of code_copy_enabled, but the > > > git mirror I follow (git://git.kernel.dk/data/git/qemu.git) hasn't > > > updated in several days so I'm not actually sure it's still there in > > > cvs. > > > > > > Just checked and http://savannah.nongnu.org/svn/?group=qemu isn't > > > there either... > > > > How about git? I'd like to use git bisect. Would there be problems if it > > were possible to commit via more than one interface? > > You mean using nongnu.org's git support? And the cvsserver > emulation, so that CVS people can still access it via CVS? That's an > option, but I do not know if nongnu.org has enabled cvsserver emulation. > > And I'm not a fan of _forcing_ people to switch to another SCM. You can > use git (and even cvsimport yourself, should the public git mirrors lag), > and even svn, as pbrook showed, even if the official upstream stays CVS. Anything but CVS please. SVN is a good option, then people can use their favorite dscm (git-svn, bzr-svn, etc). Right now I can't use qemu because a bug introduced in the last months and with git-bisect I probably would be able to fix it myself. Best regards. -- Felipe Contreras
Re: Git/SVN/CVS? was Re: [Qemu-devel] What does code_copy_enabled do?
Hi, On Sat, 9 Feb 2008, Blue Swirl wrote: > On 2/9/08, Johannes Schindelin <[EMAIL PROTECTED]> wrote: > > > And I'm not a fan of _forcing_ people to switch to another SCM. You > > can use git (and even cvsimport yourself, should the public git > > mirrors lag), and even svn, as pbrook showed, even if the official > > upstream stays CVS. > > I'm not suggesting a forced switch either, that's why I was asking if > it's possible to have R/W access enabled for several SCMs at once. That's tricky. You can mirror, of course, but that is prone to desynchronisation. But as I said, git has a cvs emulator. > I'm also still learning git, can I completely replace CVS access by > using cvsimport and cvsexportcommit locally? I do that in two projects, so yes, you can do that. cvsexportcommit is a little tricky, especially when you do not want to have an extra working directory for CVS. So this is what I do regularly: $ git --git-dir=$(pwd)/.git cvsexportcommit -c -p -u master^ master The "-c" means to really commit when the patch applies, "-p" means to check anally that the patch applies, the "-u" means that it tries to cvs update the files to the correct version first. I need to checkout the "origin" branch for that to work, though (I've been meaning to work on cvsexportcommit, but time is really scarce). Ciao, Dscho
Re: Git/SVN/CVS? was Re: [Qemu-devel] What does code_copy_enabled do?
On 2/9/08, Johannes Schindelin <[EMAIL PROTECTED]> wrote: > Hi, > > On Sat, 9 Feb 2008, Blue Swirl wrote: > > > On 2/8/08, Rob Landley <[EMAIL PROTECTED]> wrote: > > > On Thursday 07 February 2008 21:52:33 Paul Brook wrote: > > > > On Friday 08 February 2008, Rob Landley wrote: > > > > > Grepping through the source code, I can find 3 places where this > > > > > global > > > > > variable is set (it's initialized to a default value of 1, there's > > > > > a "no-code-copy" command line option that sets it to zero, and then it > > > > > shows up in the test suite once). What I can't find is any code ever > > > > > actually checking or using the value put into this variable > > > > > > > > It got ripped out a while back. > > > > > > Any news on the possible cvs->svn migration? I'd submit a cleanup > > > patch to rip out the remaining traces of code_copy_enabled, but the > > > git mirror I follow (git://git.kernel.dk/data/git/qemu.git) hasn't > > > updated in several days so I'm not actually sure it's still there in > > > cvs. > > > > > > Just checked and http://savannah.nongnu.org/svn/?group=qemu isn't > > > there either... > > > > How about git? I'd like to use git bisect. Would there be problems if it > > were possible to commit via more than one interface? > > You mean using nongnu.org's git support? And the cvsserver > emulation, so that CVS people can still access it via CVS? That's an > option, but I do not know if nongnu.org has enabled cvsserver emulation. Something like that. :-) > And I'm not a fan of _forcing_ people to switch to another SCM. You can > use git (and even cvsimport yourself, should the public git mirrors lag), > and even svn, as pbrook showed, even if the official upstream stays CVS. I'm not suggesting a forced switch either, that's why I was asking if it's possible to have R/W access enabled for several SCMs at once. I'm also still learning git, can I completely replace CVS access by using cvsimport and cvsexportcommit locally?
Re: Git/SVN/CVS? was Re: [Qemu-devel] What does code_copy_enabled do?
Hi, On Sat, 9 Feb 2008, Blue Swirl wrote: > On 2/8/08, Rob Landley <[EMAIL PROTECTED]> wrote: > > On Thursday 07 February 2008 21:52:33 Paul Brook wrote: > > > On Friday 08 February 2008, Rob Landley wrote: > > > > Grepping through the source code, I can find 3 places where this global > > > > variable is set (it's initialized to a default value of 1, there's > > > > a "no-code-copy" command line option that sets it to zero, and then it > > > > shows up in the test suite once). What I can't find is any code ever > > > > actually checking or using the value put into this variable > > > > > > It got ripped out a while back. > > > > Any news on the possible cvs->svn migration? I'd submit a cleanup > > patch to rip out the remaining traces of code_copy_enabled, but the > > git mirror I follow (git://git.kernel.dk/data/git/qemu.git) hasn't > > updated in several days so I'm not actually sure it's still there in > > cvs. > > > > Just checked and http://savannah.nongnu.org/svn/?group=qemu isn't > > there either... > > How about git? I'd like to use git bisect. Would there be problems if it > were possible to commit via more than one interface? You mean using nongnu.org's git support? And the cvsserver emulation, so that CVS people can still access it via CVS? That's an option, but I do not know if nongnu.org has enabled cvsserver emulation. And I'm not a fan of _forcing_ people to switch to another SCM. You can use git (and even cvsimport yourself, should the public git mirrors lag), and even svn, as pbrook showed, even if the official upstream stays CVS. Ciao, Dscho
Re: [Qemu-devel] Re: 2.6.24 says "serial8250: too much work for irq4" a lot.
On 2/9/08, H. Peter Anvin <[EMAIL PROTECTED]> wrote: > Blue Swirl wrote: > > On 2/9/08, Rob Landley <[EMAIL PROTECTED]> wrote: > >> Here's a patch Peter Anvin wrote so the serial I/O doesn't flood the > >> kernel. > > > > The patch looks OK, but the throttling should benefit all devices, as > > discussed here: > > http://lists.gnu.org/archive/html/qemu-devel/2007-12/msg00283.html > > I strongly disagree with the sentiments in that post. > > This is not a matter of rate throttling, but simulated FIFO exhaustion > -- they are NOT the same thing. Simulated FIFO exhaustion is > functionally equivalent to making sure there are interrupt windows > opened in an otherwise-too-long critical section; it doesn't constrain > any particular flow rate, as it still permits another interrupt to > immediately come in. > > If you look at the patch, there are no timing dependencies; the only > parameter is the depth of the virtual queue. The exhaustion is > completely controlled by target OS access patterns. Thanks, this clarified the difference. But I'll rephrase my original comment: The patch looks OK, but the simulated FIFO exhaustion should benefit all devices, as discussed here: http://lists.gnu.org/archive/html/qemu-devel/2007-12/msg00283.html
