Re: [Qemu-devel] [PATCH V1]sm501: dead code removal

[Aishwarya Kadlag]

Really glad to get a feedback so soon on my first attempt.

Yes Thomas sir, I will apply these changes in my next patch. Now that this
patch is already been implemented by Gerd sir in 2014 and it was not
applied, should I consider finding some other task or should I improve this
patch to get it merged or applied? Also as this was my first attempt, I
selected the task mentioned in the wiki page
https://wiki.qemu.org/BiteSizedTasks#Dead_code_removal
As Paolo sir said, if this is too easy then can someone please suggest me
any other task to work on so that I can create something useful to qemu??


Thanks,
Aishwarya



On Mon, Mar 12, 2018 at 6:33 PM, Peter Maydell 
wrote:

> On 12 March 2018 at 07:05, Gerd Hoffmann  wrote:
> > Might be it actually is that easy.
>
> In fact looking through the list archives I see you actually
> sent a patchset to do this for the sm501 device back in March
> last year:
> http://lists.gnu.org/archive/html/qemu-devel/2017-03/msg01172.html
>
> I think it didn't get applied mostly because it was on list
> at the same time as a significant revamp of the sm501 device
> code. So it probably won't apply cleanly to the current code,
> but it looks like a good starting point for identifying what
> the changes needed here are.
>
> thanks
> -- PMM
>

[Qemu-devel] [PATCH V1]sm501: dead code removal

[Aishwarya Kadlag]

From: Aishwarya Kadlag <aishwaryakad...@gmail.com>

Remove support for DEPTH != 32 values from hw/display/*_template.h 
files and other files that include them. Only DEPTH == 32 case is 
supported.

Signed-off-by: Aishwarya Kadlag <aishwaryakad...@gmail.com>
---
hw/display/sw501_1.c  |   36  
hw/display/sw501_template_1.h |4 +++- 
2 files changed, 3 insertions(+), 37 deletions(-)


diff -u sm501.c sm501_1.c > sm501.patch -s
--- sm501.c 2018-03-11 17:46:33.621452968 +0530
+++ sm501_1.c   2018-03-11 17:53:26.933445566 +0530
@@ -1358,22 +1358,6 @@
 int width, const uint8_t *palette,
 int c_x, int c_y);
 
-#define DEPTH 8
-#include "sm501_template.h"
-
-#define DEPTH 15
-#include "sm501_template.h"
-
-#define BGR_FORMAT
-#define DEPTH 15
-#include "sm501_template.h"
-
-#define DEPTH 16
-#include "sm501_template.h"
-
-#define BGR_FORMAT
-#define DEPTH 16
-#include "sm501_template.h"
 
 #define DEPTH 32
 #include "sm501_template.h"
@@ -1383,43 +1367,23 @@
 #include "sm501_template.h"
 
 static draw_line_func *draw_line8_funcs[] = {
-draw_line8_8,
-draw_line8_15,
-draw_line8_16,
 draw_line8_32,
 draw_line8_32bgr,
-draw_line8_15bgr,
-draw_line8_16bgr,
 };
 
 static draw_line_func *draw_line16_funcs[] = {
-draw_line16_8,
-draw_line16_15,
-draw_line16_16,
 draw_line16_32,
 draw_line16_32bgr,
-draw_line16_15bgr,
-draw_line16_16bgr,
 };
 
 static draw_line_func *draw_line32_funcs[] = {
-draw_line32_8,
-draw_line32_15,
-draw_line32_16,
 draw_line32_32,
 draw_line32_32bgr,
-draw_line32_15bgr,
-draw_line32_16bgr,
 };
 
 static draw_hwc_line_func *draw_hwc_line_funcs[] = {
-draw_hwc_line_8,
-draw_hwc_line_15,
-draw_hwc_line_16,
 draw_hwc_line_32,
 draw_hwc_line_32bgr,
-draw_hwc_line_15bgr,
-draw_hwc_line_16bgr,
 };
 
 static inline int get_depth_index(DisplaySurface *surface)



diff -u sm501_template.h sm501_template_1.h > sm501_template.patch -s
--- sm501_template.h2018-03-11 17:25:36.816653718 +0530
+++ sm501_template_1.h  2018-03-11 17:25:16.828654076 +0530
@@ -22,13 +22,15 @@
  * THE SOFTWARE.
  */
 
+/*
 #if DEPTH == 8
 #define BPP 1
 #define PIXEL_TYPE uint8_t
 #elif DEPTH == 15 || DEPTH == 16
 #define BPP 2
 #define PIXEL_TYPE uint16_t
-#elif DEPTH == 32
+*/
+#if DEPTH == 32
 #define BPP 4
 #define PIXEL_TYPE uint32_t
 #else

Re: [Qemu-devel] Qemu-devel Digest, Vol 180, Issue 211

[Aishwarya Kadlag]

I want to contribute to QEMU as a developer. I have worked on ARM Cortex
board and implemented its peripherals. I have gone through QEMU and
micro_bit board documentation. But I am not able to understand what I am
exactly supposed to do to complete any bite sized tasks. Please help me
with this.

On Sat, Mar 10, 2018 at 4:13 AM,  wrote:

> Send Qemu-devel mailing list submissions to
> qemu-devel@nongnu.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> https://lists.nongnu.org/mailman/listinfo/qemu-devel
> or, via email, send a message with subject or body 'help' to
> qemu-devel-requ...@nongnu.org
>
> You can reach the person managing the list at
> qemu-devel-ow...@nongnu.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of Qemu-devel digest..."
>
>
> Today's Topics:
>
>1. [PATCH v2] fsl-imx6: Swap Ethernet interrupt defines
>   (Guenter Roeck)
>2. Re: Apparently fpu/softfloat.c:1374 is reachable (Emilio G. Cota)
>3. Re: [PATCH 3/5] nbd/server: fix: check client->closing before
>   reply sending (Eric Blake)
>4. Re: [PATCH 4/6] luks: Turn invalid assertion into check
>   (Kevin Wolf)
>5. Re: [PATCH 3/7] qcow: Support .bdrv_co_create (Eric Blake)
>6. [Bug 1726733] Re: ?qemu-img info replication:? causes
>   segfault (Fabiano Rosas)
>7. Re: [PATCH 4/7] qed: Support .bdrv_co_create (Eric Blake)
>8. Re: [PATCH] qemu-doc: Rework the network options chapter to
>   make "-net" less prominent (Thomas Huth)
>9. Re: [PATCH 4/5] nbd/server: refactor nbd_trip: cmd_read and
>   generic reply (Eric Blake)
>   10. Re: [PATCH 5/5] nbd/server: refactor nbd_trip: split out
>   nbd_handle_request (Eric Blake)
>   11. Re: Apparently fpu/softfloat.c:1374 is reachable (Palmer Dabbelt)
>   12. Re: [PATCH] qemu-doc: Rework the network options chapter to
>   make "-net" less prominent (Eric Blake)
>   13. Re: [PATCH v2 1/3] scripts/update-linux-headers: add
>   ethtool.h and update to 4.16.0-rc4 (Michael S. Tsirkin)
>
>
> --
>
> Message: 1
> Date: Fri,  9 Mar 2018 13:47:03 -0800
> From: Guenter Roeck 
> To: Peter Maydell 
> Cc: Peter Chubb , Jason Wang
> ,  qemu-...@nongnu.org, qemu-devel@nongnu.org
> ,
> Andrey Smirnov , Chris Healy
> ,Bill Paul , Guenter
> Roeck
> 
> Subject: [Qemu-devel] [PATCH v2] fsl-imx6: Swap Ethernet interrupt
> defines
> Message-ID: <1520632024-31535-1-git-send-email-li...@roeck-us.net>
>
> The sabrelite machine model used by qemu-system-arm is based on the
> Freescale/NXP i.MX6Q processor. This SoC has an on-board ethernet
> controller which is supported in QEMU using the imx_fec.c module
> (actually called imx.enet for this model.)
>
> The include/hw/arm/fsm-imx6.h file defines the interrupt vectors for the
> imx.enet device like this:
>
>  #define FSL_IMX6_ENET_MAC_1588_IRQ 118
>  #define FSL_IMX6_ENET_MAC_IRQ 119
>
> According to https://www.nxp.com/docs/en/reference-manual/IMX6DQRM.pdf,
> page 225, in Table 3-1. ARM Cortex A9 domain interrupt summary,
> interrupts are as follows.
>
> 150 ENET MAC 0 IRQ
> 151 ENET MAC 0 1588 Timer interrupt
>
> where
>
> 150 - 32 == 118
> 151 - 32 == 119
>
> In other words, the vector definitions in the fsl-imx6.h file are reversed.
>
> Fixing the interrupts alone causes problems with older Linux kernels:
> The Ethernet interface will fail to probe with Linux v4.9 and earlier.
> Linux v4.1 and earlier will crash due to a bug in Ethernet driver probe
> error handling. This is a Linux kernel problem, not a qemu problem:
> the Linux kernel only worked by accident since it requested both
> interrupts.
>
> For backward compatibility, generate the Ethernet interrupt on both
> interrupt
> lines. This was shown to work from all Linux kernel releases starting with
> v3.16.
>
> Link: https://bugs.launchpad.net/qemu/+bug/1753309
> Signed-off-by: Guenter Roeck 
> ---
> v2: Generate Ethernet interrupts on both interrupt lines
>
>  hw/net/imx_fec.c  | 7 ++-
>  include/hw/arm/fsl-imx6.h | 4 ++--
>  2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c
> index 9506f9b..d3ae7db 100644
> --- a/hw/net/imx_fec.c
> +++ b/hw/net/imx_fec.c
> @@ -417,7 +417,12 @@ static void imx_enet_write_bd(IMXENETBufDesc *bd,
> dma_addr_t addr)
>
>  static void imx_eth_update(IMXFECState *s)
>  {
> -if (s->regs[ENET_EIR] & s->regs[ENET_EIMR] & ENET_INT_TS_TIMER) {
> +/*
> + * Generate ENET_INT_MAC interrrupts on both interrupt lines for
> + * backward compatibility with Linux kernel versions 4.9 and older.
> + */
> +if 

[Qemu-devel] Introduction

[Aishwarya Kadlag]

Hi, I am aish2k joining this mailing list today