[Qemu-devel] [PATCH] do_interrupt64 shouldn't be called when GIF is not set.

[Himanshu Chauhan]

I am not very sure about the place(s) we would need this. But I think
this is required. Please advise.

When having SVM enabled, the do_interrupt64 shouldn't be
called unless GIF is set otherwise this causes random behaviour
especially bad TR in case guest is running.

Signed-off-by: Himanshu Chauhan 
---
 target-i386/seg_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c
index 8c3f92c..c813bb9 100644
--- a/target-i386/seg_helper.c
+++ b/target-i386/seg_helper.c
@@ -1212,7 +1212,7 @@ static void do_interrupt_all(X86CPU *cpu, int intno, int 
is_int,
 }
 #endif
 #ifdef TARGET_X86_64
-if (env->hflags & HF_LMA_MASK) {
+if (env->hflags & HF_LMA_MASK && env->hflags & HF2_GIF_MASK) {
 do_interrupt64(env, intno, is_int, error_code, next_eip, is_hw);
 } else
 #endif
-- 
1.8.3.2

[Qemu-devel] [PATCH RESEND] Fixed default IRQ assignment for PL190 VIC.

[Himanshu Chauhan]

Everywhere else vect_addr[16] is returned on a read of default vector address
but updation is done only on default_addr in structure.

Signed-off-by: Himanshu Chauhan 
---
 hw/pl190.c |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/hw/pl190.c b/hw/pl190.c
index a4bc9c1..7363b87 100644
--- a/hw/pl190.c
+++ b/hw/pl190.c
@@ -187,6 +187,7 @@ static void pl190_write(void *opaque, target_phys_addr_t 
offset, uint32_t val)
 break;
 case 13: /* DEFVECTADDR */
 s->default_addr = val;
+s->vect_addr[16] = val;
 break;
 case 0xc0: /* ITCR */
 if (val) {
-- 
1.7.0.4


- End forwarded message -

[Qemu-devel] [PATCH] Fixed default IRQ assignment for PL190 VIC.

[Himanshu Chauhan]

Everywhere else vect_addr[16] is returned on a read of default vector address
but updation is done only on default_addr in structure.

Signed-off-by: Himanshu Chauhan 
---
 hw/pl190.c |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/hw/pl190.c b/hw/pl190.c
index a4bc9c1..7363b87 100644
--- a/hw/pl190.c
+++ b/hw/pl190.c
@@ -187,6 +187,7 @@ static void pl190_write(void *opaque, target_phys_addr_t 
offset, uint32_t val)
 break;
 case 13: /* DEFVECTADDR */
 s->default_addr = val;
+s->vect_addr[16] = val;
 break;
 case 0xc0: /* ITCR */
 if (val) {
-- 
1.7.0.4

[Qemu-devel] Qemu-img create problem

[Himanshu Chauhan]

Hi,

I just cloned qemu-kvm, built and installed it. But the qemu-img fails
to create any disk image above 1G. The problem as I see is use of
ssize_t for image size. When size is >2G, the check "if (sval < 0)"
succeeds and I get the error:

qemu-img: Invalid image size specified! You may use k, M, G or T suffixes for
qemu-img: kilobytes, megabytes, gigabytes and terabytes.

Regards
Himanshu