[Qemu-devel] [PATCH] Fix : Enable qemu-img QED image commit support.

2013-01-04 Thread Onkar N Mahajan
Running qemu-img commit on QED image emits the below message even if the
image is never committed. This patch fixes this. Do we need to do any
L1, L2 table cleanup here ? I see that cleanup code is commented out in
the case of qcow2 (qcow2_make_empty).

before patching - 
# qemu-img commit -f qed ss.qed 
qemu-img: Image is already committed

even before committing the image.

after patching -
# qemu-img commit -f qed ss.qed 
Image committed.

and image is actually successfully committed.

*** 

Signed-off-by: Onkar N Mahajan/India/IBM
onkar.n.maha...@linux.vnet.ibm.com

---
 block/qed.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/block/qed.c b/block/qed.c
index 6c182ca..32f1d53 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -695,7 +695,7 @@ static int coroutine_fn
bdrv_qed_co_is_allocated(BlockDriverState *bs,
 
 static int bdrv_qed_make_empty(BlockDriverState *bs)
 {
-return -ENOTSUP;
+return 0;
 }
 
 static BDRVQEDState *acb_to_s(QEDAIOCB *acb)
-- 
1.7.1

-- 




[Qemu-devel] [PATCH] Fix : Enable qemu-img QED image commit support.

2013-01-04 Thread Onkar N Mahajan
Running qemu-img commit on QED image gives this message even if the
image is never committed. This patch fixes this. Do we need to do any
L1, L2 table cleanup here ? I see that cleanup code is commented out in
the case of qcow2 (qcow2_make_empty).

before patching - 
# qemu-img commit -f qed ss.qed 
qemu-img: Image is already committed

even before committing the image.

after patching -
# qemu-img commit -f qed ss.qed 
Image committed.

and image is actually successfully committed.
---

Signed-off-by: Onkar N Mahajan/India/IBM
onkar.n.maha...@linux.vnet.ibm.com

---
 block/qed.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/block/qed.c b/block/qed.c
index 6c182ca..32f1d53 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -695,7 +695,7 @@ static int coroutine_fn
bdrv_qed_co_is_allocated(BlockDriverState *bs,
 
 static int bdrv_qed_make_empty(BlockDriverState *bs)
 {
-return -ENOTSUP;
+return 0;
 }
 
 static BDRVQEDState *acb_to_s(QEDAIOCB *acb)
-- 
1.7.1

-- 
Onkar N Mahajan
System Software Engineer
IBM Linux Technology Center
Bangalore - India




[Qemu-devel] setting up breakpoints - kernel debugging help wit gdb in qemu-kvm

2012-08-22 Thread Onkar
I am running a linux guest like this - which I wish to debug - 
but the breakpoint gets set but I am not able to stop the guest 
execution at the set breakpoint - it just hangs after I do continue. 
Can you please provide me some clues - 

# ./qemu-system-x86_64 -m 2048 -smp 4 -vga std -vnc :5 -drive
file=/sda4/bin/disk/disk0.img,cache=writeback -S -s

# gdb
GNU gdb (GDB) Fedora (7.2-52.fc14)
Copyright (C) 2010 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
http://gnu.org/licenses/gpl.html
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type show
copying
and show warranty for details.
This GDB was configured as x86_64-redhat-linux-gnu.
For bug reporting instructions, please see:
http://www.gnu.org/software/gdb/bugs/.
The target architecture is assumed to be i386:x86-64:intel
(gdb) symbol-file /sda4/kvm/vmlinux
Reading symbols from /sda4/kvm/vmlinux...done.
(gdb) target remote :1234
Remote debugging using :1234
0x in ?? ()
(gdb) b kmem_cache_alloc
Breakpoint 1 at 0x81121adb: file mm/slub.c, line 2375. (2
locations)
(gdb) c
Continuing.


Thanks, 
Onkar




[Qemu-devel] unable to set security context error ...

2011-11-02 Thread Onkar N Mahajan
I am getting  'system_u:object_r:svirt_image_t:s0:c129,c783' on 
'/var/lib/libvirt/images/vm01.img': Permission denied'

when I try to install using virt-manager.

#semanage fcontext -l | grep images
/var/lib/libvirt/images(/.*)?  all files  
system_u:object_r:svirt_image_t:s0
/var/lib/tftpboot/images(/.*)? all files  
system_u:object_r:cobbler_var_lib_t:s0
/var/lib/xen/images(/.*)?  all files  
system_u:object_r:xen_image_t:s0
/var/www/cobbler/images(/.*)?  all files  
system_u:object_r:cobbler_var_lib_t:s0


and

#ls -aZ
drwxr-xr-x. root root unconfined_u:object_r:virt_var_lib_t:s0 .
drwxr-xr-x. root root system_u:object_r:virt_var_lib_t:s0 ..
-rw---. root root system_u:object_r:svirt_image_t:s0 vm01.img


Installation fails with following error message :

Unable to complete install: 'unable to set security context 
'system_u:object_r:svirt_image_t:s0:c129,c783' on 
'/var/lib/libvirt/images/vm01.img': Permission denied'


Traceback (most recent call last):
  File /usr/local/share/virt-manager/virtManager/asyncjob.py, line 
44, in cb_wrapper

callback(asyncjob, *args, **kwargs)
  File /usr/local/share/virt-manager/virtManager/create.py, line 
1902, in do_install

guest.start_install(False, meter=meter)
  File /usr/lib/python2.7/site-packages/virtinst/Guest.py, line 1224, 
in start_install

noboot)
  File /usr/lib/python2.7/site-packages/virtinst/Guest.py, line 1292, 
in _create_guest

dom = self.conn.createLinux(start_xml or final_xml, 0)
  File /usr/lib64/python2.7/site-packages/libvirt.py, line 1277, in 
createLinux
if ret is None:raise libvirtError('virDomainCreateLinux() failed', 
conn=self)
libvirtError: unable to set security context 
'system_u:object_r:svirt_image_t:s0:c129,c783' on 
'/var/lib/libvirt/images/vm01.img': Permission denied



also,

[/usr/libexec]#which qemu-kvm
/usr/bin/qemu-kvm
[/usr/libexec]#ls -aZ /usr/bin/qemu-kvm
-rwxr-xr-x. root root unconfined_u:object_r:qemu_exec_t:s0 /usr/bin/qemu-kvm
[/usr/libexec]#which libvirtd
/usr/local/sbin/libvirtd
[/usr/libexec]#ls -aZ /usr/local/sbin/libvirtd
-rwxr-xr-x. root root system_u:object_r:bin_t:s0   
/usr/local/sbin/libvirtd



Please help me as to where I am going wrong..

Regards,
Onkar






[Qemu-devel] balloon drivers missing in virtio-win-1.1.16.vfd

2011-09-29 Thread Onkar N Mahajan

virtio_balloon drivers are missing in the virtio-win floppy disk image
found at http://alt.fedoraproject.org/pub/alt/virtio-win/latest/images/bin/
whereas they are present in the ISO image , any specific reason for
this ? Shouldn't they be ideally present ?

Regards,
Onkar





[Qemu-devel] KVM migration with different source and dest paths

2011-05-06 Thread Onkar Mahajan
Is it possible to migrate KVM guest to different paths like this:

path of the image of guest01 on host A
/home/joe/guest01.img

path of the image of guest01 on host B
/home/bill/image/temp/guest01.img


is this possible ?

if it is any pointers as to how to do this ?


Regards,
Onnm



[Qemu-devel] 10Gb Ethernet Adapters (with TOE ) port

2010-08-18 Thread Onkar Mahajan
Is there any benefit gained by  porting 10Gb Ethernet adapters to
Qemu/KVM ? The question may be naive. Please forgive me if this doesn't
make any sense.

Regards,
Onkar

-- 


Your work is going to fill a large part of your
 life, and the only way to be truly satisfied is
 to do what you believe is great work. And the
only way to do great work is to love what
 you do. If you haven’t found it yet, keep
 looking, and don’t settle. As with all matters
 of the heart, you’ll know when you find it.
-  Steve Jobs