[Qemu-devel] [PATCH] include/qemu: Add documentation to functions in include/qemu/id.h

2016-10-16 Thread Veronia Bahaa
Add documentation to the functions id_generate and id_wellformed in 
include/qemu/id.h

Signed-off-by: Veronia Bahaa <veroniaba...@gmail.com>
---
 include/qemu/id.h |   23 +++
 1 file changed, 23 insertions(+)

diff --git a/include/qemu/id.h b/include/qemu/id.h
index 40c7010..7bbcdc0 100644
--- a/include/qemu/id.h
+++ b/include/qemu/id.h
@@ -7,7 +7,30 @@ typedef enum IdSubSystems {
 ID_MAX  /* last element, used as array size */
 } IdSubSystems;
 
+/**
+ * id_generate: Generates an ID of the form PREFIX SUBSYSTEM NUMBER
+ *  where:
+ *
+ *  - PREFIX is the reserved character '#'
+ *  - SUBSYSTEM identifies the subsystem creating the ID
+ *  - NUMBER is a decimal number unique within SUBSYSTEM.
+ *
+ *Example: "#block146"
+ *
+ * Returns the generated id string for the subsystem
+ *
+ * @id: the subsystem to generate an id for
+ */
 char *id_generate(IdSubSystems id);
+
+/**
+ * id_wellformed: checks that an id starts with a letter
+ *  followed by numbers, digits, '-','.', or '_'
+ *
+ * Returns %true if the id is well-formed
+ *
+ * @id: the id to be checked
+ */
 bool id_wellformed(const char *id);
 
 #endif
-- 
1.7.9.5




[Qemu-devel] [PATCH] util: move declarations out of qemu-common.h

2016-03-20 Thread Veronia
move declarations out of qemu-common.h for functions declared in
utils/ files: e.g. include/qemu/path.h for utils/path.c.
move inline functions out of qemu-common.h and into new files (e.g.
include/qemu/bcd.h)

Signed-off-by: Veronia Bahaa<veronia@veroniaba...@gmail.com>
---
 arch_init.c   |1 +
 audio/audio.c |2 +
 block.c   |3 +-
 block/archipelago.c   |2 +-
 block/blkdebug.c  |2 +-
 block/blkverify.c |1 +
 block/block-backend.c |1 +
 block/curl.c  |1 +
 block/nbd.c   |2 +-
 block/qapi.c  |1 +
 block/qcow2-snapshot.c|2 +-
 block/qcow2.c |2 +-
 block/qed.h   |1 +
 block/raw-posix.c |2 +-
 block/raw-win32.c |2 +-
 block/rbd.c   |3 +-
 block/sheepdog.c  |2 +-
 block/vdi.c   |2 +-
 block/vmdk.c  |2 +-
 block/vvfat.c |3 +-
 blockdev.c|2 +
 bsd-user/elfload.c|1 +
 bsd-user/main.c   |3 +-
 contrib/ivshmem-server/main.c |2 +-
 disas/i386.c  |2 +
 dump.c|3 +-
 exec.c|2 +-
 gdbstub.c |3 +-
 hmp.c |1 +
 hw/9pfs/9p-proxy.c|1 +
 hw/9pfs/9p-synth.c|1 +
 hw/alpha/dp264.c  |1 +
 hw/arm/nseries.c  |2 +-
 hw/arm/omap1.c|2 +
 hw/arm/pxa2xx.c   |1 +
 hw/arm/strongarm.c|1 +
 hw/block/nvme.h   |1 +
 hw/bt/hci.c   |1 +
 hw/core/loader.c  |1 +
 hw/core/machine.c |1 +
 hw/core/qdev-properties.c |1 +
 hw/core/qdev.c|1 +
 hw/cris/boot.c|1 +
 hw/dma/pl330.c|1 +
 hw/ide/core.c |1 +
 hw/lm32/lm32_hwsetup.h|1 +
 hw/lm32/milkymist.c   |1 +
 hw/microblaze/boot.c  |1 +
 hw/mips/mips_jazz.c   |1 +
 hw/misc/ivshmem.c |1 +
 hw/misc/macio/cuda.c  |1 +
 hw/net/fsl_etsec/etsec.c  |1 +
 hw/net/fsl_etsec/rings.c  |1 +
 hw/nvram/fw_cfg.c |1 +
 hw/nvram/mac_nvram.c  |1 +
 hw/pci/pci.c  |1 +
 hw/ppc/mac_newworld.c |1 +
 hw/ppc/mac_oldworld.c |1 +
 hw/ppc/prep.c |1 +
 hw/ppc/spapr.c|2 +-
 hw/ppc/spapr_drc.c|1 +
 hw/ppc/spapr_events.c |3 +-
 hw/ppc/spapr_rtas.c   |1 +
 hw/ppc/spapr_rtc.c|1 +
 hw/scsi/scsi-bus.c|1 +
 hw/scsi/scsi-disk.c   |2 +-
 hw/scsi/vhost-scsi.c  |1 +
 hw/sparc/sun4m.c  |1 +
 hw/sparc64/sun4u.c|1 +
 hw/timer/ds1338.c |1 +
 hw/timer/exynos4210_rtc.c |1 +
 hw/timer/m48t59.c |1 +
 hw/timer/mc146818rtc.c|2 +
 hw/timer/pl031.c  |1 +
 hw/timer/twl92230.c   |1 +
 hw/usb/bus.c  |1 +
 hw/usb/dev-network.c  |1 +
 hw/usb/dev-serial.c   |1 +
 hw/usb/dev-storage.c  |1 +
 hw/usb/redirect.c |1 +
 hw/watchdog/watchdog.c|2 +-
 hw/xen/xen-host-pci-device.c  |1 +
 include/qemu-common.h |  265 -
 include/qemu/bcd.h|   10 ++
 include/qemu/cutils.h |  167 ++
 include/qemu/help_option.h|   17 +++
 include/qemu/id.h |8 ++
 include/qemu/path.h   |   47 
 include/qemu/unicode.h|5 +
 io/channel-socket.c   |1 +
 io/channel-util.c |2 +-
 linux-user/elfload.c  |1 +
 linux-user/main.c |4 +-
 linux-user/syscall.c  |2 +
 linux-user/uaccess.c  |1 +
 main-loop.c   |2 +-
 migration/migration.c |2 +-
 migration/qemu-file-unix.c|2 +-
 migration/savevm.c|3 +-
 monitor.c |2 +
 net/net.c |3 +-
 net/netmap.c  |1 +
 net/slirp.c   |1 +
 net/socket.c  |2 +-
 net/tap-bsd.c |2 +-
 net/tap-linux.c   |2 +-
 net/tap-solaris.c |1 +
 net/tap.c |1 +
 os-posix.c|1 +
 qapi/opts-visitor.c   |2 +-
 qdev-monitor.c|1 +
 qemu-char.c   |3 +-
 qemu-img.c|2 +-
 qemu-io-cmds.c|1 +
 qemu-nbd.c|3 +

[Qemu-devel] Interested in QEMU Poject for Outreachy 2016

2016-03-19 Thread Veronia Bahaa
Hello,


My name is Veronia. I'm a graduate student studying Computer and Systems
Engineering. I have used QEMU in my undergraduate graduation project and
I'm very interested in contributing to it through Outreachy.


I'm interested in the qtest-os project. Could you point me to any
additional documentation to read or small tasks to do in order to get
familiar with the project?



Thanks!


[Qemu-devel] Question in savevm.c

2014-03-13 Thread Veronia Bahaa
Hello, i need help in understanding the qemu_loadvm_state function
1- I don't get what QEMU_SECTION_START, FULL, END, PART are. I know they
are hexadecimal numbers but i don't get the meaning.
2- what's the difference between LoadStateEntry and SaveStateEntry?

Thanks!