Re: [Bug 1895399] [NEW] Docfix: add missing virtiofsd cache default 'auto'
On Mon, Sep 14, 2020 at 02:53:57PM -, Harry Coin wrote: > OK. First time for everything: > > Signed-off-by: Harry G. Coin Thank you. I posted your patch to the QEMU mailing list with your authorship information: https://patchew.org/QEMU/20200916112250.760245-1-stefa...@redhat.com/ signature.asc Description: PGP signature
Re: [Bug 1895399] [NEW] Docfix: add missing virtiofsd cache default 'auto'
On 9/14/20 5:08 AM, Stefan Hajnoczi wrote: > On Sat, Sep 12, 2020 at 04:53:54PM -, Harry Coin wrote: >> Public bug reported: >> >> The usage command line for virtiofsd has: >> >> void fuse_cmdline_help(void) >> { >> printf("-h --helpprint help\n" >> ... >>"-o cache=cache mode. could be one of >> \"auto, " >>"always, none\"\n" >>" default: auto\n" >> >> >> But the default: auto info is missing from the man page. I suggest this >> patch: >> >> --- docs/tools/virtiofsd.rst2020-09-10 18:07:45.380430677 -0500 >> +++ /tmp/virtiofsd.rst 2020-09-12 11:48:10.440815204 -0500 >> @@ -106,6 +106,7 @@ >>forbids the FUSE client from caching to achieve best coherency at the >> cost of >>performance. ``auto`` acts similar to NFS with a 1 second metadata cache >>timeout. ``always`` sets a long cache lifetime at the expense of >> coherency. >> + The default is ``auto``. >> >> Examples >> >> > Thanks, that looks good. > > Please either submit a patch > (https://wiki.qemu.org/Contribute/SubmitAPatch) or reply with a line in > the following format so I can send a patch on your behalf: > > Signed-off-by: Full Name > > The "Signed-off-by:" tag indicates that you are contributing under the > Developer Certificate of Origin (https://developercertificate.org/) that > QEMU, Linux, and other open source projects use. > OK. First time for everything: Signed-off-by: Harry G. Coin -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895399 Title: Docfix: add missing virtiofsd cache default 'auto' Status in QEMU: New Bug description: The usage command line for virtiofsd has: void fuse_cmdline_help(void) { printf("-h --helpprint help\n" ... "-o cache=cache mode. could be one of \"auto, " "always, none\"\n" " default: auto\n" But the default: auto info is missing from the man page. I suggest this patch: --- docs/tools/virtiofsd.rst2020-09-10 18:07:45.380430677 -0500 +++ /tmp/virtiofsd.rst 2020-09-12 11:48:10.440815204 -0500 @@ -106,6 +106,7 @@ forbids the FUSE client from caching to achieve best coherency at the cost of performance. ``auto`` acts similar to NFS with a 1 second metadata cache timeout. ``always`` sets a long cache lifetime at the expense of coherency. + The default is ``auto``. Examples To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1895399/+subscriptions
Re: [Bug 1895399] [NEW] Docfix: add missing virtiofsd cache default 'auto'
On Sat, Sep 12, 2020 at 04:53:54PM -, Harry Coin wrote: > Public bug reported: > > The usage command line for virtiofsd has: > > void fuse_cmdline_help(void) > { > printf("-h --helpprint help\n" > ... >"-o cache=cache mode. could be one of > \"auto, " >"always, none\"\n" >" default: auto\n" > > > But the default: auto info is missing from the man page. I suggest this > patch: > > --- docs/tools/virtiofsd.rst2020-09-10 18:07:45.380430677 -0500 > +++ /tmp/virtiofsd.rst 2020-09-12 11:48:10.440815204 -0500 > @@ -106,6 +106,7 @@ >forbids the FUSE client from caching to achieve best coherency at the cost > of >performance. ``auto`` acts similar to NFS with a 1 second metadata cache >timeout. ``always`` sets a long cache lifetime at the expense of > coherency. > + The default is ``auto``. > > Examples > > Thanks, that looks good. Please either submit a patch (https://wiki.qemu.org/Contribute/SubmitAPatch) or reply with a line in the following format so I can send a patch on your behalf: Signed-off-by: Full Name The "Signed-off-by:" tag indicates that you are contributing under the Developer Certificate of Origin (https://developercertificate.org/) that QEMU, Linux, and other open source projects use. signature.asc Description: PGP signature
[Bug 1895399] [NEW] Docfix: add missing virtiofsd cache default 'auto'
Public bug reported: The usage command line for virtiofsd has: void fuse_cmdline_help(void) { printf("-h --helpprint help\n" ... "-o cache=cache mode. could be one of \"auto, " "always, none\"\n" " default: auto\n" But the default: auto info is missing from the man page. I suggest this patch: --- docs/tools/virtiofsd.rst2020-09-10 18:07:45.380430677 -0500 +++ /tmp/virtiofsd.rst 2020-09-12 11:48:10.440815204 -0500 @@ -106,6 +106,7 @@ forbids the FUSE client from caching to achieve best coherency at the cost of performance. ``auto`` acts similar to NFS with a 1 second metadata cache timeout. ``always`` sets a long cache lifetime at the expense of coherency. + The default is ``auto``. Examples ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895399 Title: Docfix: add missing virtiofsd cache default 'auto' Status in QEMU: New Bug description: The usage command line for virtiofsd has: void fuse_cmdline_help(void) { printf("-h --helpprint help\n" ... "-o cache=cache mode. could be one of \"auto, " "always, none\"\n" " default: auto\n" But the default: auto info is missing from the man page. I suggest this patch: --- docs/tools/virtiofsd.rst2020-09-10 18:07:45.380430677 -0500 +++ /tmp/virtiofsd.rst 2020-09-12 11:48:10.440815204 -0500 @@ -106,6 +106,7 @@ forbids the FUSE client from caching to achieve best coherency at the cost of performance. ``auto`` acts similar to NFS with a 1 second metadata cache timeout. ``always`` sets a long cache lifetime at the expense of coherency. + The default is ``auto``. Examples To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1895399/+subscriptions