Re: [PATCH] Fix typo in CFI build documentation
Le 22/04/2021 à 10:33, Serge Guelton a écrit : > From: serge-sans-paille > > Signed-off-by: Serge Guelton "If you wrote the patch, make sure your "From:" and "Signed-off-by:" lines use the same spelling." https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line Please fix this. Thanks, Laurent
[PATCH] Fix typo in CFI build documentation
From: serge-sans-paille Signed-off-by: Serge Guelton Reviewed-by: Philippe Mathieu-Daudé --- docs/devel/control-flow-integrity.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/devel/control-flow-integrity.rst b/docs/devel/control-flow-integrity.rst index d89d707..e6b73a4 100644 --- a/docs/devel/control-flow-integrity.rst +++ b/docs/devel/control-flow-integrity.rst @@ -39,7 +39,7 @@ later). Given the use of LTO, a version of AR that supports LLVM IR is required. The easies way of doing this is by selecting the AR provided by LLVM:: - AR=llvm-ar-9 CC=clang-9 CXX=lang++-9 /path/to/configure --enable-cfi + AR=llvm-ar-9 CC=clang-9 CXX=clang++-9 /path/to/configure --enable-cfi CFI is enabled on every binary produced. @@ -131,7 +131,7 @@ lld with version 11+. In other words, to compile with fuzzing and CFI, clang 11+ is required, and lld needs to be used as a linker:: - AR=llvm-ar-11 CC=clang-11 CXX=lang++-11 /path/to/configure --enable-cfi \ + AR=llvm-ar-11 CC=clang-11 CXX=clang++-11 /path/to/configure --enable-cfi \ -enable-fuzzing --extra-ldflags="-fuse-ld=lld" and then, compile the fuzzers as usual. -- 1.8.3.1
Re: [PATCH] Fix typo in CFI build documentation
Hi Serge, Cc'ing qemu-trivial@ On 4/20/21 5:48 PM, serge-sans-paille wrote: > Signed-off-by: serge-sans-paille It looks your git-config is misconfigured... Maybe you used an incorrect profile :) Can you repost please? > --- > docs/devel/control-flow-integrity.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) For the fix: Reviewed-by: Philippe Mathieu-Daudé > > diff --git a/docs/devel/control-flow-integrity.rst > b/docs/devel/control-flow-integrity.rst > index d89d707..e6b73a4 100644 > --- a/docs/devel/control-flow-integrity.rst > +++ b/docs/devel/control-flow-integrity.rst > @@ -39,7 +39,7 @@ later). > Given the use of LTO, a version of AR that supports LLVM IR is required. > The easies way of doing this is by selecting the AR provided by LLVM:: > > - AR=llvm-ar-9 CC=clang-9 CXX=lang++-9 /path/to/configure --enable-cfi > + AR=llvm-ar-9 CC=clang-9 CXX=clang++-9 /path/to/configure --enable-cfi > > CFI is enabled on every binary produced. > > @@ -131,7 +131,7 @@ lld with version 11+. > In other words, to compile with fuzzing and CFI, clang 11+ is required, and > lld needs to be used as a linker:: > > - AR=llvm-ar-11 CC=clang-11 CXX=lang++-11 /path/to/configure --enable-cfi \ > + AR=llvm-ar-11 CC=clang-11 CXX=clang++-11 /path/to/configure --enable-cfi \ > -enable-fuzzing --extra-ldflags="-fuse-ld=lld" > > and then, compile the fuzzers as usual. >
[PATCH] Fix typo in CFI build documentation
Signed-off-by: serge-sans-paille --- docs/devel/control-flow-integrity.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/devel/control-flow-integrity.rst b/docs/devel/control-flow-integrity.rst index d89d707..e6b73a4 100644 --- a/docs/devel/control-flow-integrity.rst +++ b/docs/devel/control-flow-integrity.rst @@ -39,7 +39,7 @@ later). Given the use of LTO, a version of AR that supports LLVM IR is required. The easies way of doing this is by selecting the AR provided by LLVM:: - AR=llvm-ar-9 CC=clang-9 CXX=lang++-9 /path/to/configure --enable-cfi + AR=llvm-ar-9 CC=clang-9 CXX=clang++-9 /path/to/configure --enable-cfi CFI is enabled on every binary produced. @@ -131,7 +131,7 @@ lld with version 11+. In other words, to compile with fuzzing and CFI, clang 11+ is required, and lld needs to be used as a linker:: - AR=llvm-ar-11 CC=clang-11 CXX=lang++-11 /path/to/configure --enable-cfi \ + AR=llvm-ar-11 CC=clang-11 CXX=clang++-11 /path/to/configure --enable-cfi \ -enable-fuzzing --extra-ldflags="-fuse-ld=lld" and then, compile the fuzzers as usual. -- 1.8.3.1