Re: [PATCH] crypto: Fix some code style problems, add spaces around operator

[shiliyang]

Kindly ping. This patch still not on the master branch.
Please take it on your tree.

Thanks.

On 2020/12/7 18:10, Philippe Mathieu-Daudé wrote:
> On 12/7/20 9:37 AM, shiliyang wrote:
>> This patch fixes error style problems found by checkpatch.pl:
>> ERROR: spaces required around that '*'
>> ERROR: space required after that ','
>> ERROR: spaces required around that '|'
>>
>> Signed-off-by: Liyang Shi 
>> ---
>>  crypto/aes.c  | 2 +-
>>  crypto/desrfb.c   | 2 +-
>>  crypto/tlscredsx509.c | 2 +-
>>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> Reviewed-by: Philippe Mathieu-Daudé 
> 
> .
> 

Re: [PATCH] crypto: Fix some code style problems, add spaces around operator

[Philippe Mathieu-Daudé]

On 12/7/20 9:37 AM, shiliyang wrote:
> This patch fixes error style problems found by checkpatch.pl:
> ERROR: spaces required around that '*'
> ERROR: space required after that ','
> ERROR: spaces required around that '|'
> 
> Signed-off-by: Liyang Shi 
> ---
>  crypto/aes.c  | 2 +-
>  crypto/desrfb.c   | 2 +-
>  crypto/tlscredsx509.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé 

[PATCH] crypto: Fix some code style problems, add spaces around operator

[shiliyang]

This patch fixes error style problems found by checkpatch.pl:
ERROR: spaces required around that '*'
ERROR: space required after that ','
ERROR: spaces required around that '|'

Signed-off-by: Liyang Shi 
---
 crypto/aes.c  | 2 +-
 crypto/desrfb.c   | 2 +-
 crypto/tlscredsx509.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/crypto/aes.c b/crypto/aes.c
index 159800df65..56efc95196 100644
--- a/crypto/aes.c
+++ b/crypto/aes.c
@@ -1182,7 +1182,7 @@ int AES_set_decrypt_key(const unsigned char *userKey, 
const int bits,
 rk = key->rd_key;

 /* invert the order of the round keys: */
-for (i = 0, j = 4*(key->rounds); i < j; i += 4, j -= 4) {
+for (i = 0, j = 4 * (key->rounds); i < j; i += 4, j -= 4) {
 temp = rk[i]; rk[i] = rk[j]; rk[j] = temp;
 temp = rk[i + 1]; rk[i + 1] = rk[j + 1]; rk[j + 1] = temp;
 temp = rk[i + 2]; rk[i + 2] = rk[j + 2]; rk[j + 2] = temp;
diff --git a/crypto/desrfb.c b/crypto/desrfb.c
index 3274c36510..675847c93b 100644
--- a/crypto/desrfb.c
+++ b/crypto/desrfb.c
@@ -56,7 +56,7 @@ static const unsigned char pc1[56] = {
 13,  5, 60, 52, 44, 36, 28,20, 12,  4, 27, 19, 11,  3 };

 static const unsigned char totrot[16] = {
-1,2,4,6,8,10,12,14,15,17,19,21,23,25,27,28 };
+1, 2, 4, 6, 8, 10, 12, 14, 15, 17, 19, 21, 23, 25, 27, 28 };

 static const unsigned char pc2[48] = {
 13, 16, 10, 23,  0,  4,  2, 27, 14,  5, 20,  9,
diff --git a/crypto/tlscredsx509.c b/crypto/tlscredsx509.c
index dd7267ccdb..c89dd62435 100644
--- a/crypto/tlscredsx509.c
+++ b/crypto/tlscredsx509.c
@@ -143,7 +143,7 @@ qcrypto_tls_creds_check_cert_key_usage(QCryptoTLSCredsX509 
*creds,
 if (status < 0) {
 if (status == GNUTLS_E_REQUESTED_DATA_NOT_AVAILABLE) {
 usage = isCA ? GNUTLS_KEY_KEY_CERT_SIGN :
-GNUTLS_KEY_DIGITAL_SIGNATURE|GNUTLS_KEY_KEY_ENCIPHERMENT;
+GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT;
 } else {
 error_setg(errp,
"Unable to query certificate %s key usage: %s",
-- 
2.29.1.59.gf9b6481aed