Re: [PATCH] iotests: Remove 130 from the "auto" group
On Tue, 29 Oct 2019 at 14:05, Max Reitz wrote: > > On 18.10.19 18:10, Thomas Huth wrote: > > Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared > > 'write' lock - Is another process using the image [TEST_DIR/t.IMGFMT]?" > > error with 130 already twice. Looks like this test is a little bit > > shaky, and currently nobody has a real clue what could be causing this > > issue, so for the time being, let's disable it from the "auto" group so > > that it does not gate the pull requests. > > > > Signed-off-by: Thomas Huth > > --- > > tests/qemu-iotests/group | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Thanks, applied to my block branch: > > https://github.com/XanClic/qemu/commits/block I ran into this intermittent-on-s390 again this morning, so I've applied it to master in an attempt to improve the reliabliity of my merge testing. (The other current culprit for intermittent failures seems to be the various BSD builds for non-iotest reasons.) thanks -- PMM
Re: [PATCH] iotests: Remove 130 from the "auto" group
On 18.10.19 18:10, Thomas Huth wrote: > Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared > 'write' lock - Is another process using the image [TEST_DIR/t.IMGFMT]?" > error with 130 already twice. Looks like this test is a little bit > shaky, and currently nobody has a real clue what could be causing this > issue, so for the time being, let's disable it from the "auto" group so > that it does not gate the pull requests. > > Signed-off-by: Thomas Huth > --- > tests/qemu-iotests/group | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block branch: https://github.com/XanClic/qemu/commits/block Max signature.asc Description: OpenPGP digital signature
Re: [PATCH] iotests: Remove 130 from the "auto" group
On 18/10/2019 18.51, Bruce Rogers wrote: > On Fri, 2019-10-18 at 18:10 +0200, Thomas Huth wrote: >> Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared >> 'write' lock - Is another process using the image >> [TEST_DIR/t.IMGFMT]?" >> error with 130 already twice. Looks like this test is a little bit >> shaky, and currently nobody has a real clue what could be causing >> this >> issue, so for the time being, let's disable it from the "auto" group >> so >> that it does not gate the pull requests. >> > > For some time I've also needed to work around issues running 130. I > either disabled it, or I found a few properly placed sleeps got it to > reliably pass. Last week I finally got around to investigating it a bit > more and discovered that the failure was related to my using --enable- > membarrier in my configure. > > I didn't investigate whether the block io tests' _cleanup_qemu using > kill -KILL was being relied on in some way by some tests, or if that is > simply a way to speed the testing along, or what, but I've gotten test > 130 to reliably pass by changing the test to quit properly via the > monitor, and by adding a wait=1 so that _cleanup_qemu doesn't simply > kill qemu. > > I believe 153 and 161 also suffer in a similar way. Ok, thanks for the heads-up! 153 is not in the "auto" group, but 161 is, so we definitely keep that in mind if we see failure here... Thomas
Re: [PATCH] iotests: Remove 130 from the "auto" group
On 10/18/19 12:10 PM, Thomas Huth wrote: > Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared > 'write' lock - Is another process using the image [TEST_DIR/t.IMGFMT]?" > error with 130 already twice. Looks like this test is a little bit > shaky, and currently nobody has a real clue what could be causing this > issue, so for the time being, let's disable it from the "auto" group so > that it does not gate the pull requests. > > Signed-off-by: Thomas Huth Reviewed-by: John Snow > --- > tests/qemu-iotests/group | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group > index 7dac79a783..6aa4b8d098 100644 > --- a/tests/qemu-iotests/group > +++ b/tests/qemu-iotests/group > @@ -151,7 +151,7 @@ > 127 rw backing quick > 128 rw quick > 129 rw quick > -130 rw auto quick > +130 rw quick > 131 rw quick > 132 rw quick > 133 auto quick > -- —js
Re: [PATCH] iotests: Remove 130 from the "auto" group
On Fri, 2019-10-18 at 18:10 +0200, Thomas Huth wrote: > Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared > 'write' lock - Is another process using the image > [TEST_DIR/t.IMGFMT]?" > error with 130 already twice. Looks like this test is a little bit > shaky, and currently nobody has a real clue what could be causing > this > issue, so for the time being, let's disable it from the "auto" group > so > that it does not gate the pull requests. > For some time I've also needed to work around issues running 130. I either disabled it, or I found a few properly placed sleeps got it to reliably pass. Last week I finally got around to investigating it a bit more and discovered that the failure was related to my using --enable- membarrier in my configure. I didn't investigate whether the block io tests' _cleanup_qemu using kill -KILL was being relied on in some way by some tests, or if that is simply a way to speed the testing along, or what, but I've gotten test 130 to reliably pass by changing the test to quit properly via the monitor, and by adding a wait=1 so that _cleanup_qemu doesn't simply kill qemu. I believe 153 and 161 also suffer in a similar way. I haven't gotten around to fully understanding how qemu's using the kernel sys_membarrier is adversly affected by killing qemu in this way, but it seems there's an issue with that. Hopefully someone who is more familiar with qemu's use of membarrier's can add more details here. Bruce
[PATCH] iotests: Remove 130 from the "auto" group
Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared 'write' lock - Is another process using the image [TEST_DIR/t.IMGFMT]?" error with 130 already twice. Looks like this test is a little bit shaky, and currently nobody has a real clue what could be causing this issue, so for the time being, let's disable it from the "auto" group so that it does not gate the pull requests. Signed-off-by: Thomas Huth --- tests/qemu-iotests/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index 7dac79a783..6aa4b8d098 100644 --- a/tests/qemu-iotests/group +++ b/tests/qemu-iotests/group @@ -151,7 +151,7 @@ 127 rw backing quick 128 rw quick 129 rw quick -130 rw auto quick +130 rw quick 131 rw quick 132 rw quick 133 auto quick -- 2.18.1
