Re: [PATCH] scsi: Remove superfluous breaks

[Richard Henderson]

On 7/12/20 5:33 PM, Yi Wang wrote:
> From: Liao Pingfang 
> 
> Remove superfluous breaks, as there is a "return" before them.
> 
> Signed-off-by: Liao Pingfang 
> ---
>  scsi/utils.c | 4 
>  1 file changed, 4 deletions(-)

Cc: qemu-trivial
Reviewed-by: Richard Henderson 


r~

[PATCH] scsi: Remove superfluous breaks

[Yi Wang]

From: Liao Pingfang 

Remove superfluous breaks, as there is a "return" before them.

Signed-off-by: Liao Pingfang 
---
 scsi/utils.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/scsi/utils.c b/scsi/utils.c
index c50e81f..b37c283 100644
--- a/scsi/utils.c
+++ b/scsi/utils.c
@@ -32,17 +32,13 @@ uint32_t scsi_cdb_xfer(uint8_t *buf)
 switch (buf[0] >> 5) {
 case 0:
 return buf[4];
-break;
 case 1:
 case 2:
 return lduw_be_p([7]);
-break;
 case 4:
 return ldl_be_p([10]) & 0xULL;
-break;
 case 5:
 return ldl_be_p([6]) & 0xULL;
-break;
 default:
 return -1;
 }
-- 
2.9.5