Re: [PATCH] system/physmem: Fix reference to dump-guest-core

[David Hildenbrand]

On 28.06.24 06:05, Akihiko Odaki wrote:

dump_guest_core is exposed as dump-guest-core with QOM.

Signed-off-by: Akihiko Odaki 
---
  system/physmem.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/system/physmem.c b/system/physmem.c
index b7847db1a2c5..effa97184f25 100644
--- a/system/physmem.c
+++ b/system/physmem.c
@@ -1521,7 +1521,7 @@ static void qemu_ram_setup_dump(void *addr, ram_addr_t 
size)
  if (ret) {
  perror("qemu_madvise");
  fprintf(stderr, "madvise doesn't support MADV_DONTDUMP, "
-"but dump_guest_core=off specified\n");
+"but dump-guest-core=off specified\n");
  }
  }
  }

---
base-commit: 046a64b9801343e2e89eef10c7a48eec8d8c0d4f
change-id: 20240614-dump-7b73ab18c31a

Best regards,


Reviewed-by: David Hildenbrand 

--
Cheers,

David / dhildenb

Re: [PATCH] system/physmem: Fix reference to dump-guest-core

[Philippe Mathieu-Daudé]

On 28/6/24 06:05, Akihiko Odaki wrote:

dump_guest_core is exposed as dump-guest-core with QOM.

Signed-off-by: Akihiko Odaki 
---
  system/physmem.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)


Patch queued.

Re: [PATCH] system/physmem: Fix reference to dump-guest-core

[Philippe Mathieu-Daudé]

On 28/6/24 06:05, Akihiko Odaki wrote:

dump_guest_core is exposed as dump-guest-core with QOM.

Signed-off-by: Akihiko Odaki 
---
  system/physmem.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Philippe Mathieu-Daudé 

[PATCH] system/physmem: Fix reference to dump-guest-core

[Akihiko Odaki]

dump_guest_core is exposed as dump-guest-core with QOM.

Signed-off-by: Akihiko Odaki 
---
 system/physmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/system/physmem.c b/system/physmem.c
index b7847db1a2c5..effa97184f25 100644
--- a/system/physmem.c
+++ b/system/physmem.c
@@ -1521,7 +1521,7 @@ static void qemu_ram_setup_dump(void *addr, ram_addr_t 
size)
 if (ret) {
 perror("qemu_madvise");
 fprintf(stderr, "madvise doesn't support MADV_DONTDUMP, "
-"but dump_guest_core=off specified\n");
+"but dump-guest-core=off specified\n");
 }
 }
 }

---
base-commit: 046a64b9801343e2e89eef10c7a48eec8d8c0d4f
change-id: 20240614-dump-7b73ab18c31a

Best regards,
-- 
Akihiko Odaki