Re: [PATCH] target/mips: Remove spurious LOG_UNIMP of MTHC0 opcode
On Thu, Apr 22, 2021 at 10:10 AM Philippe Mathieu-Daudé wrote: > > When running with '-d unimp' all MTHC0 opcode executed > are logged as unimplemented... Add the proper 'return' > statement missed from commit 5204ea79ea7. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 1 + > 1 file changed, 1 insertion(+) Thanks, applied to mips-next.
Re: [PATCH] target/mips: Remove spurious LOG_UNIMP of MTHC0 opcode
On 4/22/21 1:10 AM, Philippe Mathieu-Daudé wrote: When running with '-d unimp' all MTHC0 opcode executed are logged as unimplemented... Add the proper 'return' statement missed from commit 5204ea79ea7. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson r~
[PATCH] target/mips: Remove spurious LOG_UNIMP of MTHC0 opcode
When running with '-d unimp' all MTHC0 opcode executed are logged as unimplemented... Add the proper 'return' statement missed from commit 5204ea79ea7. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index 71fa5ec1973..269bdba400f 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -5945,6 +5945,7 @@ static void gen_mthc0(DisasContext *ctx, TCGv arg, int reg, int sel) goto cp0_unimplemented; } trace_mips_translate_c0("mthc0", register_name, reg, sel); +return; cp0_unimplemented: qemu_log_mask(LOG_UNIMP, "mthc0 %s (reg %d sel %d)\n", -- 2.26.3