Re: [PATCH] tcg/arm: Fix tcg_out_op function signature

[no-reply]

Patchew URL: https://patchew.org/QEMU/20210610224450.23425-1-jzivi...@suse.de/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210610224450.23425-1-jzivi...@suse.de
Subject: [PATCH] tcg/arm: Fix tcg_out_op function signature

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] patchew/20210614114357.1146725-1-vinc...@bernat.ch -> 
patchew/20210614114357.1146725-1-vinc...@bernat.ch
 * [new tag] patchew/20210614144407.134243-1-mre...@redhat.com -> 
patchew/20210614144407.134243-1-mre...@redhat.com
Switched to a new branch 'test'

=== OUTPUT BEGIN ===
checkpatch.pl: no revisions returned for revlist 'base..'
=== OUTPUT END ===

Test command exited with code: 255


The full log is available at
http://patchew.org/logs/20210610224450.23425-1-jzivi...@suse.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [PATCH] tcg/arm: Fix tcg_out_op function signature

[Richard Henderson]

On 6/10/21 3:44 PM, Jose R. Ziviani wrote:

Commit 5e8892db93 fixed several function signatures but tcg_out_op for
arm is missing. This patch fixes it as well.

Signed-off-by: Jose R. Ziviani
---
  tcg/arm/tcg-target.c.inc | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)


Thanks, queued.

r~

[PATCH] tcg/arm: Fix tcg_out_op function signature

[Jose R. Ziviani]

Commit 5e8892db93 fixed several function signatures but tcg_out_op for
arm is missing. This patch fixes it as well.

Signed-off-by: Jose R. Ziviani 
---
 tcg/arm/tcg-target.c.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc
index f4c9cb8f9f..5157143246 100644
--- a/tcg/arm/tcg-target.c.inc
+++ b/tcg/arm/tcg-target.c.inc
@@ -1984,7 +1984,8 @@ static void tcg_out_qemu_st(TCGContext *s, const TCGArg 
*args, bool is64)
 static void tcg_out_epilogue(TCGContext *s);
 
 static inline void tcg_out_op(TCGContext *s, TCGOpcode opc,
-const TCGArg *args, const int *const_args)
+const TCGArg args[TCG_MAX_OP_ARGS],
+const int const_args[TCG_MAX_OP_ARGS])
 {
 TCGArg a0, a1, a2, a3, a4, a5;
 int c;
-- 
2.31.1