Re: [PATCH] tcg/riscv: Remove superfluous breaks
On Sun, Jul 12, 2020 at 5:30 PM Yi Wang wrote: > > From: Liao Pingfang > > Remove superfluous breaks, as there is a "return" before them. > > Signed-off-by: Liao Pingfang Thanks! Applied to riscv-to-apply.next Alistair > --- > tcg/riscv/tcg-target.inc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c > index 2bc0ba7..3c11ab8 100644 > --- a/tcg/riscv/tcg-target.inc.c > +++ b/tcg/riscv/tcg-target.inc.c > @@ -502,10 +502,8 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int > type, > break; > case R_RISCV_JAL: > return reloc_jimm20(code_ptr, (tcg_insn_unit *)value); > -break; > case R_RISCV_CALL: > return reloc_call(code_ptr, (tcg_insn_unit *)value); > -break; > default: > tcg_abort(); > } > -- > 2.9.5 > >
Re: [PATCH] tcg/riscv: Remove superfluous breaks
On Sun, Jul 12, 2020 at 5:30 PM Yi Wang wrote: > > From: Liao Pingfang > > Remove superfluous breaks, as there is a "return" before them. > > Signed-off-by: Liao Pingfang Reviewed-by: Alistair Francis Alistair > --- > tcg/riscv/tcg-target.inc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c > index 2bc0ba7..3c11ab8 100644 > --- a/tcg/riscv/tcg-target.inc.c > +++ b/tcg/riscv/tcg-target.inc.c > @@ -502,10 +502,8 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int > type, > break; > case R_RISCV_JAL: > return reloc_jimm20(code_ptr, (tcg_insn_unit *)value); > -break; > case R_RISCV_CALL: > return reloc_call(code_ptr, (tcg_insn_unit *)value); > -break; > default: > tcg_abort(); > } > -- > 2.9.5 > >
[PATCH] tcg/riscv: Remove superfluous breaks
From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang --- tcg/riscv/tcg-target.inc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index 2bc0ba7..3c11ab8 100644 --- a/tcg/riscv/tcg-target.inc.c +++ b/tcg/riscv/tcg-target.inc.c @@ -502,10 +502,8 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int type, break; case R_RISCV_JAL: return reloc_jimm20(code_ptr, (tcg_insn_unit *)value); -break; case R_RISCV_CALL: return reloc_call(code_ptr, (tcg_insn_unit *)value); -break; default: tcg_abort(); } -- 2.9.5