Re: [PATCH] vnc: Fix a memleak in vnc_display_connect()

2021-01-12 Thread Laurent Vivier 
Le 26/11/2020 à 07:57, Alex Chen a écrit :
> Free the 'sioc' when the qio_channel_socket_connect_sync() fails.
> 
> Reported-by: Euler Robot 
> Signed-off-by: Alex Chen 
> ---
>  ui/vnc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 49235056f7..dae56e9493 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3743,6 +3743,7 @@ static int vnc_display_connect(VncDisplay *vd,
>  sioc = qio_channel_socket_new();
>  qio_channel_set_name(QIO_CHANNEL(sioc), "vnc-reverse");
>  if (qio_channel_socket_connect_sync(sioc, saddr[0], errp) < 0) {
> +object_unref(OBJECT(sioc));
>  return -1;
>  }
>  vnc_connect(vd, sioc, false, false);
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [PATCH] vnc: Fix a memleak in vnc_display_connect()

2021-01-12 Thread Laurent Vivier 
Le 26/11/2020 à 07:57, Alex Chen a écrit :
> Free the 'sioc' when the qio_channel_socket_connect_sync() fails.
> 
> Reported-by: Euler Robot 
> Signed-off-by: Alex Chen 
> ---
>  ui/vnc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 49235056f7..dae56e9493 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3743,6 +3743,7 @@ static int vnc_display_connect(VncDisplay *vd,
>  sioc = qio_channel_socket_new();
>  qio_channel_set_name(QIO_CHANNEL(sioc), "vnc-reverse");
>  if (qio_channel_socket_connect_sync(sioc, saddr[0], errp) < 0) {
> +object_unref(OBJECT(sioc));
>  return -1;
>  }
>  vnc_connect(vd, sioc, false, false);
> 

Reviewed-by: Laurent Vivier

Re: [PATCH] vnc: Fix a memleak in vnc_display_connect()

2020-11-26 Thread Li Qiang 
Alex Chen  于2020年11月26日周四 下午3:10写道：
>
> Free the 'sioc' when the qio_channel_socket_connect_sync() fails.
>
> Reported-by: Euler Robot 
> Signed-off-by: Alex Chen 

Reviewed-by: Li Qiang 

> ---
>  ui/vnc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 49235056f7..dae56e9493 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3743,6 +3743,7 @@ static int vnc_display_connect(VncDisplay *vd,
>  sioc = qio_channel_socket_new();
>  qio_channel_set_name(QIO_CHANNEL(sioc), "vnc-reverse");
>  if (qio_channel_socket_connect_sync(sioc, saddr[0], errp) < 0) {
> +object_unref(OBJECT(sioc));
>  return -1;
>  }
>  vnc_connect(vd, sioc, false, false);
> --
> 2.19.1
>
>

[PATCH] vnc: Fix a memleak in vnc_display_connect()

2020-11-25 Thread Alex Chen 
Free the 'sioc' when the qio_channel_socket_connect_sync() fails.

Reported-by: Euler Robot 
Signed-off-by: Alex Chen 
---
 ui/vnc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui/vnc.c b/ui/vnc.c
index 49235056f7..dae56e9493 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3743,6 +3743,7 @@ static int vnc_display_connect(VncDisplay *vd,
 sioc = qio_channel_socket_new();
 qio_channel_set_name(QIO_CHANNEL(sioc), "vnc-reverse");
 if (qio_channel_socket_connect_sync(sioc, saddr[0], errp) < 0) {
+object_unref(OBJECT(sioc));
 return -1;
 }
 vnc_connect(vd, sioc, false, false);
-- 
2.19.1