Re: [PATCH v2 18/19] tests/tcg: fix typo in configure.sh test for v8.3
On 2/13/20 2:51 PM, Alex Bennée wrote: > Although most people use the docker images this can trip up on > developer systems with actual valid cross-compilers! > > Signed-off-by: Alex Bennée > --- > tests/tcg/configure.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~
Re: [PATCH v2 18/19] tests/tcg: fix typo in configure.sh test for v8.3
On 2/13/20 11:51 PM, Alex Bennée wrote: > Although most people use the docker images this can trip up on > developer systems with actual valid cross-compilers! > Oops =) Fixes: bb516dfc5b3 Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Alex Bennée > --- > tests/tcg/configure.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh > index 9eb6ba3b7ea..eaaaff6233a 100755 > --- a/tests/tcg/configure.sh > +++ b/tests/tcg/configure.sh > @@ -228,7 +228,7 @@ for target in $target_list; do > echo "CROSS_CC_HAS_SVE=y" >> $config_target_mak > fi > if do_compiler "$target_compiler" $target_compiler_cflags \ > - -march=-march=armv8.3-a -o $TMPE $TMPC; then > + -march=armv8.3-a -o $TMPE $TMPC; then > echo "CROSS_CC_HAS_ARMV8_3=y" >> $config_target_mak > fi > ;; >
[PATCH v2 18/19] tests/tcg: fix typo in configure.sh test for v8.3
Although most people use the docker images this can trip up on developer systems with actual valid cross-compilers! Signed-off-by: Alex Bennée --- tests/tcg/configure.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh index 9eb6ba3b7ea..eaaaff6233a 100755 --- a/tests/tcg/configure.sh +++ b/tests/tcg/configure.sh @@ -228,7 +228,7 @@ for target in $target_list; do echo "CROSS_CC_HAS_SVE=y" >> $config_target_mak fi if do_compiler "$target_compiler" $target_compiler_cflags \ - -march=-march=armv8.3-a -o $TMPE $TMPC; then + -march=armv8.3-a -o $TMPE $TMPC; then echo "CROSS_CC_HAS_ARMV8_3=y" >> $config_target_mak fi ;; -- 2.20.1
