Re: [PATCH 0/2] delete virtio queues in virtio_scsi_unrealize

2020-01-21 Thread Paolo Bonzini 
On 17/01/20 08:55, pannengy...@huawei.com wrote:
> From: Pan Nengyuan 
> 
> This serie patch fix memleaks when detaching virtio-scsi device. 
> 1. use old virtio_del_queue to fix memleaks, it's easier for stable branches 
> to merge.
>As the discussion in 
> https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg02903.html
> 
> 2. replace virtio_del_queue to virtio_delete_queue to make it more clear.
> 
> Pan Nengyuan (2):
>   virtio-scsi: delete vqs in unrealize to avoid memleaks
>   virtio-scsi: convert to new virtio_delete_queue
> 
>  hw/scsi/virtio-scsi.c | 6 ++
>  1 file changed, 6 insertions(+)
> 

Queued, thanks.

Paolo

Re: [PATCH 0/2] delete virtio queues in virtio_scsi_unrealize

2020-01-20 Thread Stefan Hajnoczi 
On Fri, Jan 17, 2020 at 03:55:45PM +0800, pannengy...@huawei.com wrote:
> From: Pan Nengyuan 
> 
> This serie patch fix memleaks when detaching virtio-scsi device. 
> 1. use old virtio_del_queue to fix memleaks, it's easier for stable branches 
> to merge.
>As the discussion in 
> https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg02903.html
> 
> 2. replace virtio_del_queue to virtio_delete_queue to make it more clear.
> 
> Pan Nengyuan (2):
>   virtio-scsi: delete vqs in unrealize to avoid memleaks
>   virtio-scsi: convert to new virtio_delete_queue
> 
>  hw/scsi/virtio-scsi.c | 6 ++
>  1 file changed, 6 insertions(+)
> 
> -- 
> 2.21.0.windows.1
> 
> 
> 

The patches could be squashed by the maintainer, but the code changes
are fine:

Reviewed-by: Stefan Hajnoczi 


signature.asc
Description: PGP signature

[PATCH 0/2] delete virtio queues in virtio_scsi_unrealize

2020-01-16 Thread pannengyuan 
From: Pan Nengyuan 

This serie patch fix memleaks when detaching virtio-scsi device. 
1. use old virtio_del_queue to fix memleaks, it's easier for stable branches to 
merge.
   As the discussion in 
https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg02903.html

2. replace virtio_del_queue to virtio_delete_queue to make it more clear.

Pan Nengyuan (2):
  virtio-scsi: delete vqs in unrealize to avoid memleaks
  virtio-scsi: convert to new virtio_delete_queue

 hw/scsi/virtio-scsi.c | 6 ++
 1 file changed, 6 insertions(+)

-- 
2.21.0.windows.1