Re: [PATCH 00/10] Fixed some bugs and optimized some codes for COLO
On Wed, 13 Jan 2021 10:46:25 +0800 leirao wrote: > The series of patches include: > Fixed some bugs of qemu crash. > Optimized some code to reduce the time of checkpoint. > Remove some unnecessary code to improve COLO. > The rest of the patches look good to me. Can you address my comments and send v2? I'll then run my test-suite over it and give you Reviewed-by for the whole series. Also, you should split this into two patch series: One for network and one for migration, so the respective maintainers can take it trough their trees. Regards, Lukas Straub pgpWkyGZy9kmu.pgp Description: OpenPGP digital signature
[PATCH 00/10] Fixed some bugs and optimized some codes for COLO
The series of patches include: Fixed some bugs of qemu crash. Optimized some code to reduce the time of checkpoint. Remove some unnecessary code to improve COLO. Rao, Lei (10): Remove some duplicate trace code. Fix the qemu crash when guest shutdown during checkpoint Optimize the function of filter_send Remove migrate_set_block_enabled in checkpoint Optimize the function of packet_new Add the function of colo_compare_cleanup Disable auto-coverge before entering COLO mode. Reduce the PVM stop time during Checkpoint Add the function of colo_bitmap_clear_diry Fixed calculation error of pkt->header_size in fill_pkt_tcp_info() migration/colo.c | 6 - migration/migration.c | 20 +++- migration/ram.c | 65 --- net/colo-compare.c| 32 - net/colo-compare.h| 1 + net/colo.c| 4 ++-- net/colo.h| 2 +- net/filter-mirror.c | 8 +++ net/filter-rewriter.c | 1 - net/net.c | 4 softmmu/runstate.c| 1 + 11 files changed, 110 insertions(+), 34 deletions(-) -- 1.8.3.1